Fix Lying Tests Signature Parity #3

Open
mmintel wants to merge 0 commits from fix/lying-tests-signature-parity into main
Owner

Fixes the lying tests signature parity by making the E2E tests and legacy mock tests strictly enforce create_autospec verification. This required fixing some legacy mock structures like FakeConfig and MockConfigs and updating test_carousel_zero_percent to test the proper logical path. All 243 unit tests and 50 E2E tests are perfectly green.

Fixes the lying tests signature parity by making the E2E tests and legacy mock tests strictly enforce `create_autospec` verification. This required fixing some legacy mock structures like `FakeConfig` and `MockConfigs` and updating `test_carousel_zero_percent` to test the proper logical path. All 243 unit tests and 50 E2E tests are perfectly green.
mmintel added 1 commit 2026-04-27 08:19:12 +00:00
- Fixed get_plugin_config AttributeError in MockConfigs and FakeConfig
- Adjusted test_carousel_zero_percent to assert on can_activate
- Explicitly delete missing mock config args in E2E tests for getattr coverage
mmintel added 10 commits 2026-04-27 11:40:56 +00:00
mmintel added 1 commit 2026-04-27 12:00:21 +00:00
mmintel added 1 commit 2026-04-27 12:13:08 +00:00
mmintel added 1 commit 2026-04-27 12:51:37 +00:00
mmintel added 1 commit 2026-04-27 12:52:46 +00:00
mmintel added 1 commit 2026-04-27 12:57:22 +00:00
mmintel added 1 commit 2026-04-27 12:59:49 +00:00
mmintel added 1 commit 2026-04-27 13:05:42 +00:00
mmintel added 1 commit 2026-04-27 13:08:25 +00:00
mmintel added 1 commit 2026-04-27 13:11:32 +00:00
mmintel added 1 commit 2026-04-27 13:24:12 +00:00
mmintel added 1 commit 2026-04-27 13:31:05 +00:00
mmintel added 1 commit 2026-04-27 13:41:31 +00:00
- Add _humanize_desc() regex to split '991following' → '991 following'
- Add explicit followers/following disambiguation rule to VLM prompt
- E2E test suite: 6 tests proving HD Map avoidance, SpatialParser extraction,
  VLM prompt preparation, and LIVE LLM disambiguation
- Root cause: VLM confused Instagram's concatenated content-desc values
mmintel added 1 commit 2026-04-27 13:53:08 +00:00
BREAKING: IntentResolver now resolves intents by SEEING the screenshot
instead of parsing XML text descriptions.

Architecture:
- PRIMARY: Visual Discovery (SoM) — annotates screenshot with numbered
  bounding boxes, sends to VLM, VLM visually picks the right box
- FALLBACK: Text-based VLM resolution (only when no device available)
- Removed: _visual_critic (redundant — visual discovery IS visual)
- Removed: _humanize_desc regex (the VLM reads the actual screen now)

Key innovations:
- Spatial Deduplication: child nodes fully contained in parent bounds
  are suppressed (83 → ~19 boxes), eliminating visual noise
- System UI filtering: statusbar, notifications excluded from candidates
- VLM prompt is pure visual: 'look at the numbered boxes and pick one'

Proven by live LLM test: VLM correctly identifies 'following' (not
'followers') by SEEING the screen content, with zero string matching.
mmintel added 2 commits 2026-04-27 19:47:45 +00:00
mmintel added 1 commit 2026-04-27 19:53:58 +00:00
mmintel added 1 commit 2026-04-27 20:08:32 +00:00
mmintel added 1 commit 2026-04-27 20:13:55 +00:00
mmintel added 1 commit 2026-04-27 20:28:54 +00:00
mmintel added 1 commit 2026-04-27 20:36:20 +00:00
mmintel added 1 commit 2026-04-27 20:44:57 +00:00
mmintel added 1 commit 2026-04-27 20:46:50 +00:00
mmintel added 1 commit 2026-04-27 20:51:30 +00:00
mmintel added 1 commit 2026-04-27 20:55:17 +00:00
This branch is already included in the target branch. There is nothing to merge.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/lying-tests-signature-parity:fix/lying-tests-signature-parity
git checkout fix/lying-tests-signature-parity
Sign in to join this conversation.
No Reviewers
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mmintel/instagram-bot#3