mmintel/klz-cables.com
1
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases 1 Wiki Activity

fix(contact): correct pino logger argument order to pass typescript compiler

Browse Source
This commit is contained in:
Marc Mintel
2026-07-17 15:54:35 +02:00
parent bd00175912
commit 7be2ec605c
1 changed files with 36 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

93
app/actions/contact.ts
View File

@@ -32,24 +32,18 @@ export async function sendContactFormAction(formData: FormData) {
const productName = formData.get('productName') as string | null; const productName = formData.get('productName') as string | null;
if (!name || !email || !message) { if (!name || !email || !message) {
logger.warn( logger.warn('Missing required fields in contact form', {
{ name: !!name,
name: !!name, email: !!email,
email: !!email, message: !!message,
message: !!message, });
},
'Missing required fields in contact form',
);
return { success: false, error: 'Missing required fields' }; return { success: false, error: 'Missing required fields' };
} }
logger.info( logger.info('Payload CMS saving skipped because it has been removed', {
{ type: productName ? 'product_quote' : 'contact',
type: productName ? 'product_quote' : 'contact', email,
email, });
},
'Payload CMS saving skipped because it has been removed',
);
// 1.5. Simple Fail-Safe Backup to Disk // 1.5. Simple Fail-Safe Backup to Disk
// To ensure leads are never lost if email fails or Gotify is down, we append them to a local JSON Lines file. // To ensure leads are never lost if email fails or Gotify is down, we append them to a local JSON Lines file.
@@ -68,13 +62,13 @@ export async function sendContactFormAction(formData: FormData) {
message, message,
}; };
fs.appendFileSync(backupFile, JSON.stringify(leadData) + '\n'); fs.appendFileSync(backupFile, JSON.stringify(leadData) + '\n');
logger.info({ backupFile }, 'Successfully saved lead to local backup file'); logger.info('Successfully saved lead to local backup file', { backupFile });
} catch (backupError) { } catch (backupError) {
logger.error({ error: String(backupError) }, 'Failed to write to local leads backup'); logger.error('Failed to write to local leads backup', { error: String(backupError) });
} }
// 2. Send Emails // 2. Send Emails
logger.info({ email, productName }, 'Sending branded emails'); logger.info('Sending branded emails', { email, productName });
const notificationSubject = productName const notificationSubject = productName
? `Product Inquiry: ${productName}` ? `Product Inquiry: ${productName}`
@@ -94,7 +88,7 @@ export async function sendContactFormAction(formData: FormData) {
); );
if (!isTestSubmission) { if (!isTestSubmission) {
logger.info({ recipients: env.MAIL_RECIPIENTS }, 'Sending internal notification'); logger.info('Sending internal notification', { recipients: env.MAIL_RECIPIENTS });
const notificationResult = await sendEmail({ const notificationResult = await sendEmail({
replyTo: email, replyTo: email,
subject: notificationSubject, subject: notificationSubject,
@@ -102,21 +96,15 @@ export async function sendContactFormAction(formData: FormData) {
}); });
if (notificationResult.success) { if (notificationResult.success) {
logger.info( logger.info('Notification email sent successfully', {
{ messageId: notificationResult.messageId,
messageId: notificationResult.messageId, });
},
'Notification email sent successfully',
);
} else { } else {
logger.error( logger.error('Notification email DELIVERY FAILED', {
{ error: notificationResult.error,
error: notificationResult.error, subject: notificationSubject,
subject: notificationSubject, recipients: env.MAIL_RECIPIENTS,
recipients: env.MAIL_RECIPIENTS, });
},
'Notification email DELIVERY FAILED',
);
services.errors.captureException( services.errors.captureException(
new Error(`Notification email failed: ${notificationResult.error}`), new Error(`Notification email failed: ${notificationResult.error}`),
{ {
@@ -127,7 +115,7 @@ export async function sendContactFormAction(formData: FormData) {
); );
} }
} else { } else {
logger.info({ email }, 'Skipping notification email for test submission'); logger.info('Skipping notification email for test submission', { email });
} }
// 2b. Send confirmation to Customer (branded as KLZ Cables) // 2b. Send confirmation to Customer (branded as KLZ Cables)
@@ -140,7 +128,7 @@ export async function sendContactFormAction(formData: FormData) {
); );
if (!isTestSubmission) { if (!isTestSubmission) {
logger.info({ to: email }, 'Sending customer confirmation'); logger.info('Sending customer confirmation', { to: email });
const confirmationResult = await sendEmail({ const confirmationResult = await sendEmail({
to: email, to: email,
subject: confirmationSubject, subject: confirmationSubject,
@@ -148,28 +136,22 @@ export async function sendContactFormAction(formData: FormData) {
}); });
if (confirmationResult.success) { if (confirmationResult.success) {
logger.info( logger.info('Confirmation email sent successfully', {
{ messageId: confirmationResult.messageId,
messageId: confirmationResult.messageId, });
},
'Confirmation email sent successfully',
);
} else { } else {
logger.error( logger.error('Confirmation email DELIVERY FAILED', {
{ error: confirmationResult.error,
error: confirmationResult.error, subject: confirmationSubject,
subject: confirmationSubject, to: email,
to: email, });
},
'Confirmation email DELIVERY FAILED',
);
services.errors.captureException( services.errors.captureException(
new Error(`Confirmation email failed: ${confirmationResult.error}`), new Error(`Confirmation email failed: ${confirmationResult.error}`),
{ action: 'sendContactFormAction_confirmation', email }, { action: 'sendContactFormAction_confirmation', email },
); );
} }
} else { } else {
logger.info({ email }, 'Skipping confirmation email for test submission'); logger.info('Skipping confirmation email for test submission', { email });
} }
// Notify via Gotify (Internal) // Notify via Gotify (Internal)
@@ -187,13 +169,10 @@ export async function sendContactFormAction(formData: FormData) {
return { success: true }; return { success: true };
} catch (error) { } catch (error) {
const errorMsg = error instanceof Error ? error.message : String(error); const errorMsg = error instanceof Error ? error.message : String(error);
logger.error( logger.error('Failed to send branded emails', {
{ error: errorMsg,
error: errorMsg, stack: error instanceof Error ? error.stack : undefined,
stack: error instanceof Error ? error.stack : undefined, });
},
'Failed to send branded emails',
);
services.errors.captureException(error, { action: 'sendContactFormAction', email }); services.errors.captureException(error, { action: 'sendContactFormAction', email });