code quality

This commit is contained in:
2026-01-26 11:02:19 +01:00
parent afef777961
commit f877f821ef
14 changed files with 232 additions and 87 deletions

View File

@@ -1,9 +1,11 @@
import { describe, it, expect, vi, beforeEach } from 'vitest';
import { describe, it, expect, vi, beforeEach, Mock } from 'vitest';
import { GetLeagueUseCase, GetLeagueQuery } from './GetLeagueUseCase';
import { LeagueRepository } from '../ports/LeagueRepository';
import { LeagueEventPublisher } from '../ports/LeagueEventPublisher';
describe('GetLeagueUseCase', () => {
let mockLeagueRepository: any;
let mockEventPublisher: any;
let mockLeagueRepository: LeagueRepository;
let mockEventPublisher: LeagueEventPublisher;
let useCase: GetLeagueUseCase;
const mockLeague = {
@@ -14,10 +16,53 @@ describe('GetLeagueUseCase', () => {
beforeEach(() => {
mockLeagueRepository = {
findById: vi.fn().mockResolvedValue(mockLeague),
create: vi.fn() as unknown as Mock,
findById: vi.fn().mockResolvedValue(mockLeague) as unknown as Mock,
findByName: vi.fn() as unknown as Mock,
findByOwner: vi.fn() as unknown as Mock,
search: vi.fn() as unknown as Mock,
update: vi.fn() as unknown as Mock,
delete: vi.fn() as unknown as Mock,
getStats: vi.fn() as unknown as Mock,
updateStats: vi.fn() as unknown as Mock,
getFinancials: vi.fn() as unknown as Mock,
updateFinancials: vi.fn() as unknown as Mock,
getStewardingMetrics: vi.fn() as unknown as Mock,
updateStewardingMetrics: vi.fn() as unknown as Mock,
getPerformanceMetrics: vi.fn() as unknown as Mock,
updatePerformanceMetrics: vi.fn() as unknown as Mock,
getRatingMetrics: vi.fn() as unknown as Mock,
updateRatingMetrics: vi.fn() as unknown as Mock,
getTrendMetrics: vi.fn() as unknown as Mock,
updateTrendMetrics: vi.fn() as unknown as Mock,
getSuccessRateMetrics: vi.fn() as unknown as Mock,
updateSuccessRateMetrics: vi.fn() as unknown as Mock,
getResolutionTimeMetrics: vi.fn() as unknown as Mock,
updateResolutionTimeMetrics: vi.fn() as unknown as Mock,
getComplexSuccessRateMetrics: vi.fn() as unknown as Mock,
updateComplexSuccessRateMetrics: vi.fn() as unknown as Mock,
getComplexResolutionTimeMetrics: vi.fn() as unknown as Mock,
updateComplexResolutionTimeMetrics: vi.fn() as unknown as Mock,
getLeagueMembers: vi.fn() as unknown as Mock,
getPendingRequests: vi.fn() as unknown as Mock,
addLeagueMembers: vi.fn() as unknown as Mock,
updateLeagueMember: vi.fn() as unknown as Mock,
removeLeagueMember: vi.fn() as unknown as Mock,
addPendingRequests: vi.fn() as unknown as Mock,
removePendingRequest: vi.fn() as unknown as Mock,
};
mockEventPublisher = {
emitLeagueAccessed: vi.fn().mockResolvedValue(undefined),
emitLeagueCreated: vi.fn() as unknown as Mock,
emitLeagueUpdated: vi.fn() as unknown as Mock,
emitLeagueDeleted: vi.fn() as unknown as Mock,
emitLeagueAccessed: vi.fn().mockResolvedValue(undefined) as unknown as Mock,
emitLeagueRosterAccessed: vi.fn() as unknown as Mock,
getLeagueCreatedEventCount: vi.fn() as unknown as Mock,
getLeagueUpdatedEventCount: vi.fn() as unknown as Mock,
getLeagueDeletedEventCount: vi.fn() as unknown as Mock,
getLeagueAccessedEventCount: vi.fn() as unknown as Mock,
getLeagueRosterAccessedEventCount: vi.fn() as unknown as Mock,
clear: vi.fn() as unknown as Mock,
};
useCase = new GetLeagueUseCase(mockLeagueRepository, mockEventPublisher);
});
@@ -39,14 +84,14 @@ describe('GetLeagueUseCase', () => {
});
it('should throw error if league not found', async () => {
mockLeagueRepository.findById.mockResolvedValue(null);
(mockLeagueRepository.findById as Mock).mockResolvedValue(null);
const query: GetLeagueQuery = { leagueId: 'non-existent' };
await expect(useCase.execute(query)).rejects.toThrow('League with id non-existent not found');
});
it('should throw error if leagueId is missing', async () => {
const query: any = {};
const query = {} as unknown as GetLeagueQuery;
await expect(useCase.execute(query)).rejects.toThrow('League ID is required');
});
});