code quality

core/leagues/application/use-cases/DemoteAdminUseCase.test.ts

@@ -1,7 +1,7 @@
 import { describe, it, expect, vi, beforeEach, Mock } from 'vitest';
 import { DemoteAdminUseCase } from './DemoteAdminUseCase';
 import { LeagueRepository } from '../ports/LeagueRepository';
-import { DriverRepository } from '../../racing/domain/repositories/DriverRepository';
+import { DriverRepository } from '../../../racing/domain/repositories/DriverRepository';
 import { LeagueEventPublisher } from '../ports/LeagueEventPublisher';
 
 describe('DemoteAdminUseCase', () => {
@@ -49,31 +49,13 @@ describe('DemoteAdminUseCase', () => {
     };
     mockDriverRepository = {
       findById: vi.fn() as unknown as Mock,
-      findByName: vi.fn() as unknown as Mock,
-      findByEmail: vi.fn() as unknown as Mock,
-      search: vi.fn() as unknown as Mock,
+      findByIRacingId: vi.fn() as unknown as Mock,
+      findAll: vi.fn() as unknown as Mock,
+      create: vi.fn() as unknown as Mock,
       update: vi.fn() as unknown as Mock,
       delete: vi.fn() as unknown as Mock,
-      getStats: vi.fn() as unknown as Mock,
-      updateStats: vi.fn() as unknown as Mock,
-      getPerformanceMetrics: vi.fn() as unknown as Mock,
-      updatePerformanceMetrics: vi.fn() as unknown as Mock,
-      getRatingMetrics: vi.fn() as unknown as Mock,
-      updateRatingMetrics: vi.fn() as unknown as Mock,
-      getTrendMetrics: vi.fn() as unknown as Mock,
-      updateTrendMetrics: vi.fn() as unknown as Mock,
-      getSuccessRateMetrics: vi.fn() as unknown as Mock,
-      updateSuccessRateMetrics: vi.fn() as unknown as Mock,
-      getResolutionTimeMetrics: vi.fn() as unknown as Mock,
-      updateResolutionTimeMetrics: vi.fn() as unknown as Mock,
-      getComplexSuccessRateMetrics: vi.fn() as unknown as Mock,
-      updateComplexSuccessRateMetrics: vi.fn() as unknown as Mock,
-      getComplexResolutionTimeMetrics: vi.fn() as unknown as Mock,
-      updateComplexResolutionTimeMetrics: vi.fn() as unknown as Mock,
-      getDriverMemberships: vi.fn() as unknown as Mock,
-      addDriverMembership: vi.fn() as unknown as Mock,
-      updateDriverMembership: vi.fn() as unknown as Mock,
-      removeDriverMembership: vi.fn() as unknown as Mock,
+      exists: vi.fn() as unknown as Mock,
+      existsByIRacingId: vi.fn() as unknown as Mock,
     };
     mockEventPublisher = {
       emitLeagueCreated: vi.fn() as unknown as Mock,

core/leagues/application/use-cases/GetLeagueRosterUseCase.test.ts

@@ -1,9 +1,11 @@
-import { describe, it, expect, vi, beforeEach } from 'vitest';
+import { describe, it, expect, vi, beforeEach, Mock } from 'vitest';
 import { GetLeagueRosterUseCase } from './GetLeagueRosterUseCase';
+import { LeagueRepository } from '../ports/LeagueRepository';
+import { LeagueEventPublisher } from '../ports/LeagueEventPublisher';
 
 describe('GetLeagueRosterUseCase', () => {
-  let mockLeagueRepository: any;
-  let mockEventPublisher: any;
+  let mockLeagueRepository: LeagueRepository;
+  let mockEventPublisher: LeagueEventPublisher;
   let useCase: GetLeagueRosterUseCase;
 
   const mockLeague = { id: 'league-1' };
@@ -18,12 +20,53 @@ describe('GetLeagueRosterUseCase', () => {
 
   beforeEach(() => {
     mockLeagueRepository = {
-      findById: vi.fn().mockResolvedValue(mockLeague),
-      getLeagueMembers: vi.fn().mockResolvedValue(mockMembers),
-      getPendingRequests: vi.fn().mockResolvedValue(mockRequests),
+      create: vi.fn() as unknown as Mock,
+      findById: vi.fn().mockResolvedValue(mockLeague) as unknown as Mock,
+      findByName: vi.fn() as unknown as Mock,
+      findByOwner: vi.fn() as unknown as Mock,
+      search: vi.fn() as unknown as Mock,
+      update: vi.fn() as unknown as Mock,
+      delete: vi.fn() as unknown as Mock,
+      getStats: vi.fn() as unknown as Mock,
+      updateStats: vi.fn() as unknown as Mock,
+      getFinancials: vi.fn() as unknown as Mock,
+      updateFinancials: vi.fn() as unknown as Mock,
+      getStewardingMetrics: vi.fn() as unknown as Mock,
+      updateStewardingMetrics: vi.fn() as unknown as Mock,
+      getPerformanceMetrics: vi.fn() as unknown as Mock,
+      updatePerformanceMetrics: vi.fn() as unknown as Mock,
+      getRatingMetrics: vi.fn() as unknown as Mock,
+      updateRatingMetrics: vi.fn() as unknown as Mock,
+      getTrendMetrics: vi.fn() as unknown as Mock,
+      updateTrendMetrics: vi.fn() as unknown as Mock,
+      getSuccessRateMetrics: vi.fn() as unknown as Mock,
+      updateSuccessRateMetrics: vi.fn() as unknown as Mock,
+      getResolutionTimeMetrics: vi.fn() as unknown as Mock,
+      updateResolutionTimeMetrics: vi.fn() as unknown as Mock,
+      getComplexSuccessRateMetrics: vi.fn() as unknown as Mock,
+      updateComplexSuccessRateMetrics: vi.fn() as unknown as Mock,
+      getComplexResolutionTimeMetrics: vi.fn() as unknown as Mock,
+      updateComplexResolutionTimeMetrics: vi.fn() as unknown as Mock,
+      getLeagueMembers: vi.fn().mockResolvedValue(mockMembers) as unknown as Mock,
+      getPendingRequests: vi.fn().mockResolvedValue(mockRequests) as unknown as Mock,
+      addLeagueMembers: vi.fn() as unknown as Mock,
+      updateLeagueMember: vi.fn() as unknown as Mock,
+      removeLeagueMember: vi.fn() as unknown as Mock,
+      addPendingRequests: vi.fn() as unknown as Mock,
+      removePendingRequest: vi.fn() as unknown as Mock,
     };
     mockEventPublisher = {
-      emitLeagueRosterAccessed: vi.fn().mockResolvedValue(undefined),
+      emitLeagueCreated: vi.fn() as unknown as Mock,
+      emitLeagueUpdated: vi.fn() as unknown as Mock,
+      emitLeagueDeleted: vi.fn() as unknown as Mock,
+      emitLeagueAccessed: vi.fn() as unknown as Mock,
+      emitLeagueRosterAccessed: vi.fn().mockResolvedValue(undefined) as unknown as Mock,
+      getLeagueCreatedEventCount: vi.fn() as unknown as Mock,
+      getLeagueUpdatedEventCount: vi.fn() as unknown as Mock,
+      getLeagueDeletedEventCount: vi.fn() as unknown as Mock,
+      getLeagueAccessedEventCount: vi.fn() as unknown as Mock,
+      getLeagueRosterAccessedEventCount: vi.fn() as unknown as Mock,
+      clear: vi.fn() as unknown as Mock,
     };
     useCase = new GetLeagueRosterUseCase(mockLeagueRepository, mockEventPublisher);
   });
@@ -39,7 +82,7 @@ describe('GetLeagueRosterUseCase', () => {
   });
 
   it('should throw error if league not found', async () => {
-    mockLeagueRepository.findById.mockResolvedValue(null);
+    (mockLeagueRepository.findById as Mock).mockResolvedValue(null);
     await expect(useCase.execute({ leagueId: 'invalid' })).rejects.toThrow('League with id invalid not found');
   });
 });

core/leagues/application/use-cases/GetLeagueUseCase.test.ts

@@ -1,9 +1,11 @@
-import { describe, it, expect, vi, beforeEach } from 'vitest';
+import { describe, it, expect, vi, beforeEach, Mock } from 'vitest';
 import { GetLeagueUseCase, GetLeagueQuery } from './GetLeagueUseCase';
+import { LeagueRepository } from '../ports/LeagueRepository';
+import { LeagueEventPublisher } from '../ports/LeagueEventPublisher';
 
 describe('GetLeagueUseCase', () => {
-  let mockLeagueRepository: any;
-  let mockEventPublisher: any;
+  let mockLeagueRepository: LeagueRepository;
+  let mockEventPublisher: LeagueEventPublisher;
   let useCase: GetLeagueUseCase;
 
   const mockLeague = {
@@ -14,10 +16,53 @@ describe('GetLeagueUseCase', () => {
 
   beforeEach(() => {
     mockLeagueRepository = {
-      findById: vi.fn().mockResolvedValue(mockLeague),
+      create: vi.fn() as unknown as Mock,
+      findById: vi.fn().mockResolvedValue(mockLeague) as unknown as Mock,
+      findByName: vi.fn() as unknown as Mock,
+      findByOwner: vi.fn() as unknown as Mock,
+      search: vi.fn() as unknown as Mock,
+      update: vi.fn() as unknown as Mock,
+      delete: vi.fn() as unknown as Mock,
+      getStats: vi.fn() as unknown as Mock,
+      updateStats: vi.fn() as unknown as Mock,
+      getFinancials: vi.fn() as unknown as Mock,
+      updateFinancials: vi.fn() as unknown as Mock,
+      getStewardingMetrics: vi.fn() as unknown as Mock,
+      updateStewardingMetrics: vi.fn() as unknown as Mock,
+      getPerformanceMetrics: vi.fn() as unknown as Mock,
+      updatePerformanceMetrics: vi.fn() as unknown as Mock,
+      getRatingMetrics: vi.fn() as unknown as Mock,
+      updateRatingMetrics: vi.fn() as unknown as Mock,
+      getTrendMetrics: vi.fn() as unknown as Mock,
+      updateTrendMetrics: vi.fn() as unknown as Mock,
+      getSuccessRateMetrics: vi.fn() as unknown as Mock,
+      updateSuccessRateMetrics: vi.fn() as unknown as Mock,
+      getResolutionTimeMetrics: vi.fn() as unknown as Mock,
+      updateResolutionTimeMetrics: vi.fn() as unknown as Mock,
+      getComplexSuccessRateMetrics: vi.fn() as unknown as Mock,
+      updateComplexSuccessRateMetrics: vi.fn() as unknown as Mock,
+      getComplexResolutionTimeMetrics: vi.fn() as unknown as Mock,
+      updateComplexResolutionTimeMetrics: vi.fn() as unknown as Mock,
+      getLeagueMembers: vi.fn() as unknown as Mock,
+      getPendingRequests: vi.fn() as unknown as Mock,
+      addLeagueMembers: vi.fn() as unknown as Mock,
+      updateLeagueMember: vi.fn() as unknown as Mock,
+      removeLeagueMember: vi.fn() as unknown as Mock,
+      addPendingRequests: vi.fn() as unknown as Mock,
+      removePendingRequest: vi.fn() as unknown as Mock,
     };
     mockEventPublisher = {
-      emitLeagueAccessed: vi.fn().mockResolvedValue(undefined),
+      emitLeagueCreated: vi.fn() as unknown as Mock,
+      emitLeagueUpdated: vi.fn() as unknown as Mock,
+      emitLeagueDeleted: vi.fn() as unknown as Mock,
+      emitLeagueAccessed: vi.fn().mockResolvedValue(undefined) as unknown as Mock,
+      emitLeagueRosterAccessed: vi.fn() as unknown as Mock,
+      getLeagueCreatedEventCount: vi.fn() as unknown as Mock,
+      getLeagueUpdatedEventCount: vi.fn() as unknown as Mock,
+      getLeagueDeletedEventCount: vi.fn() as unknown as Mock,
+      getLeagueAccessedEventCount: vi.fn() as unknown as Mock,
+      getLeagueRosterAccessedEventCount: vi.fn() as unknown as Mock,
+      clear: vi.fn() as unknown as Mock,
     };
     useCase = new GetLeagueUseCase(mockLeagueRepository, mockEventPublisher);
   });
@@ -39,14 +84,14 @@ describe('GetLeagueUseCase', () => {
   });
 
   it('should throw error if league not found', async () => {
-    mockLeagueRepository.findById.mockResolvedValue(null);
+    (mockLeagueRepository.findById as Mock).mockResolvedValue(null);
     const query: GetLeagueQuery = { leagueId: 'non-existent' };
 
     await expect(useCase.execute(query)).rejects.toThrow('League with id non-existent not found');
   });
 
   it('should throw error if leagueId is missing', async () => {
-    const query: any = {};
+    const query = {} as unknown as GetLeagueQuery;
     await expect(useCase.execute(query)).rejects.toThrow('League ID is required');
   });
 });

core/leagues/application/use-cases/JoinLeagueUseCase.test.ts

@@ -1,19 +1,60 @@
-import { describe, it, expect, vi, beforeEach } from 'vitest';
+import { describe, it, expect, vi, beforeEach, Mock } from 'vitest';
 import { JoinLeagueUseCase } from './JoinLeagueUseCase';
 import type { JoinLeagueCommand } from '../ports/JoinLeagueCommand';
+import { LeagueRepository } from '../ports/LeagueRepository';
+import { DriverRepository } from '../../../racing/domain/repositories/DriverRepository';
+import { EventPublisher } from '../../../shared/ports/EventPublisher';
 
-const mockLeagueRepository = {
-  findById: vi.fn(),
-  addPendingRequests: vi.fn(),
-  addLeagueMembers: vi.fn(),
+const mockLeagueRepository: LeagueRepository = {
+  create: vi.fn() as unknown as Mock,
+  findById: vi.fn() as unknown as Mock,
+  findByName: vi.fn() as unknown as Mock,
+  findByOwner: vi.fn() as unknown as Mock,
+  search: vi.fn() as unknown as Mock,
+  update: vi.fn() as unknown as Mock,
+  delete: vi.fn() as unknown as Mock,
+  getStats: vi.fn() as unknown as Mock,
+  updateStats: vi.fn() as unknown as Mock,
+  getFinancials: vi.fn() as unknown as Mock,
+  updateFinancials: vi.fn() as unknown as Mock,
+  getStewardingMetrics: vi.fn() as unknown as Mock,
+  updateStewardingMetrics: vi.fn() as unknown as Mock,
+  getPerformanceMetrics: vi.fn() as unknown as Mock,
+  updatePerformanceMetrics: vi.fn() as unknown as Mock,
+  getRatingMetrics: vi.fn() as unknown as Mock,
+  updateRatingMetrics: vi.fn() as unknown as Mock,
+  getTrendMetrics: vi.fn() as unknown as Mock,
+  updateTrendMetrics: vi.fn() as unknown as Mock,
+  getSuccessRateMetrics: vi.fn() as unknown as Mock,
+  updateSuccessRateMetrics: vi.fn() as unknown as Mock,
+  getResolutionTimeMetrics: vi.fn() as unknown as Mock,
+  updateResolutionTimeMetrics: vi.fn() as unknown as Mock,
+  getComplexSuccessRateMetrics: vi.fn() as unknown as Mock,
+  updateComplexSuccessRateMetrics: vi.fn() as unknown as Mock,
+  getComplexResolutionTimeMetrics: vi.fn() as unknown as Mock,
+  updateComplexResolutionTimeMetrics: vi.fn() as unknown as Mock,
+  getLeagueMembers: vi.fn() as unknown as Mock,
+  getPendingRequests: vi.fn() as unknown as Mock,
+  addLeagueMembers: vi.fn() as unknown as Mock,
+  updateLeagueMember: vi.fn() as unknown as Mock,
+  removeLeagueMember: vi.fn() as unknown as Mock,
+  addPendingRequests: vi.fn() as unknown as Mock,
+  removePendingRequest: vi.fn() as unknown as Mock,
 };
 
-const mockDriverRepository = {
-  findDriverById: vi.fn(),
+const mockDriverRepository: DriverRepository = {
+  findById: vi.fn() as unknown as Mock,
+  findByIRacingId: vi.fn() as unknown as Mock,
+  findAll: vi.fn() as unknown as Mock,
+  create: vi.fn() as unknown as Mock,
+  update: vi.fn() as unknown as Mock,
+  delete: vi.fn() as unknown as Mock,
+  exists: vi.fn() as unknown as Mock,
+  existsByIRacingId: vi.fn() as unknown as Mock,
 };
 
-const mockEventPublisher = {
-  publish: vi.fn(),
+const mockEventPublisher: EventPublisher = {
+  publish: vi.fn() as unknown as Mock,
 };
 
 describe('JoinLeagueUseCase', () => {
@@ -24,9 +65,9 @@ describe('JoinLeagueUseCase', () => {
     vi.clearAllMocks();
 
     useCase = new JoinLeagueUseCase(
-      mockLeagueRepository as any,
-      mockDriverRepository as any,
-      mockEventPublisher as any
+      mockLeagueRepository,
+      mockDriverRepository,
+      mockEventPublisher
     );
   });
 
@@ -38,7 +79,7 @@ describe('JoinLeagueUseCase', () => {
         driverId: 'driver-456',
       };
 
-      mockLeagueRepository.findById.mockImplementation(() => Promise.resolve(null));
+      (mockLeagueRepository.findById as Mock).mockImplementation(() => Promise.resolve(null));
 
       // When & Then
       await expect(useCase.execute(command)).rejects.toThrow('League not found');
@@ -82,13 +123,13 @@ describe('JoinLeagueUseCase', () => {
         tags: null,
       };
 
-      mockLeagueRepository.findById.mockImplementation(() => Promise.resolve(mockLeague));
-      mockDriverRepository.findDriverById.mockImplementation(() => Promise.resolve(null));
+      (mockLeagueRepository.findById as Mock).mockImplementation(() => Promise.resolve(mockLeague));
+      (mockDriverRepository.findById as Mock).mockImplementation(() => Promise.resolve(null));
 
       // When & Then
       await expect(useCase.execute(command)).rejects.toThrow('Driver not found');
       expect(mockLeagueRepository.findById).toHaveBeenCalledWith('league-123');
-      expect(mockDriverRepository.findDriverById).toHaveBeenCalledWith('driver-456');
+      expect(mockDriverRepository.findById).toHaveBeenCalledWith('driver-456');
     });
   });
 
@@ -141,8 +182,8 @@ describe('JoinLeagueUseCase', () => {
       const frozenTime = new Date('2024-01-01T00:00:00.000Z');
       vi.setSystemTime(frozenTime);
 
-      mockLeagueRepository.findById.mockResolvedValue(mockLeague);
-      mockDriverRepository.findDriverById.mockResolvedValue(mockDriver);
+      (mockLeagueRepository.findById as Mock).mockResolvedValue(mockLeague);
+      (mockDriverRepository.findById as Mock).mockResolvedValue(mockDriver);
 
       // When
       await useCase.execute(command);
@@ -213,8 +254,8 @@ describe('JoinLeagueUseCase', () => {
         updatedAt: new Date(),
       };
 
-      mockLeagueRepository.findById.mockResolvedValue(mockLeague);
-      mockDriverRepository.findDriverById.mockResolvedValue(mockDriver);
+      (mockLeagueRepository.findById as Mock).mockResolvedValue(mockLeague);
+      (mockDriverRepository.findById as Mock).mockResolvedValue(mockDriver);
 
       // When
       await useCase.execute(command);

core/leagues/application/use-cases/SearchLeaguesUseCase.test.ts

@@ -1,8 +1,9 @@
-import { describe, it, expect, vi, beforeEach } from 'vitest';
+import { describe, it, expect, vi, beforeEach, Mock } from 'vitest';
 import { SearchLeaguesUseCase, SearchLeaguesQuery } from './SearchLeaguesUseCase';
+import { LeagueRepository } from '../ports/LeagueRepository';
 
 describe('SearchLeaguesUseCase', () => {
-  let mockLeagueRepository: any;
+  let mockLeagueRepository: LeagueRepository;
   let useCase: SearchLeaguesUseCase;
 
   const mockLeagues = [
@@ -13,7 +14,40 @@ describe('SearchLeaguesUseCase', () => {
 
   beforeEach(() => {
     mockLeagueRepository = {
-      search: vi.fn().mockResolvedValue([...mockLeagues]),
+      create: vi.fn() as unknown as Mock,
+      findById: vi.fn() as unknown as Mock,
+      findByName: vi.fn() as unknown as Mock,
+      findByOwner: vi.fn() as unknown as Mock,
+      search: vi.fn().mockResolvedValue([...mockLeagues]) as unknown as Mock,
+      update: vi.fn() as unknown as Mock,
+      delete: vi.fn() as unknown as Mock,
+      getStats: vi.fn() as unknown as Mock,
+      updateStats: vi.fn() as unknown as Mock,
+      getFinancials: vi.fn() as unknown as Mock,
+      updateFinancials: vi.fn() as unknown as Mock,
+      getStewardingMetrics: vi.fn() as unknown as Mock,
+      updateStewardingMetrics: vi.fn() as unknown as Mock,
+      getPerformanceMetrics: vi.fn() as unknown as Mock,
+      updatePerformanceMetrics: vi.fn() as unknown as Mock,
+      getRatingMetrics: vi.fn() as unknown as Mock,
+      updateRatingMetrics: vi.fn() as unknown as Mock,
+      getTrendMetrics: vi.fn() as unknown as Mock,
+      updateTrendMetrics: vi.fn() as unknown as Mock,
+      getSuccessRateMetrics: vi.fn() as unknown as Mock,
+      updateSuccessRateMetrics: vi.fn() as unknown as Mock,
+      getResolutionTimeMetrics: vi.fn() as unknown as Mock,
+      updateResolutionTimeMetrics: vi.fn() as unknown as Mock,
+      getComplexSuccessRateMetrics: vi.fn() as unknown as Mock,
+      updateComplexSuccessRateMetrics: vi.fn() as unknown as Mock,
+      getComplexResolutionTimeMetrics: vi.fn() as unknown as Mock,
+      updateComplexResolutionTimeMetrics: vi.fn() as unknown as Mock,
+      getLeagueMembers: vi.fn() as unknown as Mock,
+      getPendingRequests: vi.fn() as unknown as Mock,
+      addLeagueMembers: vi.fn() as unknown as Mock,
+      updateLeagueMember: vi.fn() as unknown as Mock,
+      removeLeagueMember: vi.fn() as unknown as Mock,
+      addPendingRequests: vi.fn() as unknown as Mock,
+      removePendingRequest: vi.fn() as unknown as Mock,
     };
     useCase = new SearchLeaguesUseCase(mockLeagueRepository);
   });
@@ -35,7 +69,7 @@ describe('SearchLeaguesUseCase', () => {
   });
 
   it('should throw error if query is missing', async () => {
-    const query: any = { query: '' };
+    const query = { query: '' } as unknown as SearchLeaguesQuery;
     await expect(useCase.execute(query)).rejects.toThrow('Search query is required');
   });
 });