view data fixes

apps/website/lib/view-models/CreateLeagueViewModel.ts

@@ -9,19 +9,19 @@ import { LeagueCreationStatusDisplay } from '../display-objects/LeagueCreationSt
  * Composes Display Objects and transforms ViewData for UI consumption.
  */
 export class CreateLeagueViewModel extends ViewModel {
-  readonly leagueId: string;
-  readonly success: boolean;
+  private readonly data: CreateLeagueViewData;
 
-  // UI-specific derived fields (primitive outputs only)
-  readonly successMessage: string;
-
-  constructor(viewData: CreateLeagueViewData) {
+  constructor(data: CreateLeagueViewData) {
     super();
-    this.leagueId = viewData.leagueId;
-    this.success = viewData.success;
+    this.data = data;
+  }
 
-    // Derive UI-specific fields using Display Object
-    this.successMessage = LeagueCreationStatusDisplay.statusMessage(this.success);
+  get leagueId(): string { return this.data.leagueId; }
+  get success(): boolean { return this.data.success; }
+
+  /** UI-specific: Success message using Display Object */
+  get successMessage(): string {
+    return LeagueCreationStatusDisplay.statusMessage(this.success);
   }
 
   /** UI-specific: Whether league creation was successful */