refactor

core/payments/application/use-cases/GetMembershipFeesUseCase.test.ts

@@ -1,14 +1,7 @@
 import { describe, it, expect, vi, type Mock } from 'vitest';
 import { GetMembershipFeesUseCase, type GetMembershipFeesInput } from './GetMembershipFeesUseCase';
 import type { IMembershipFeeRepository, IMemberPaymentRepository } from '../../domain/repositories/IMembershipFeeRepository';
-import type { IGetMembershipFeesPresenter, GetMembershipFeesResultDTO, GetMembershipFeesViewModel } from '../presenters/IGetMembershipFeesPresenter';
-
-interface TestPresenter extends IGetMembershipFeesPresenter {
-  reset: Mock;
-  present: Mock;
-  lastDto?: GetMembershipFeesResultDTO;
-  viewModel?: GetMembershipFeesViewModel;
-}
+import type { UseCaseOutputPort } from '@core/shared/application/UseCaseOutputPort';
 
 describe('GetMembershipFeesUseCase', () => {
   let membershipFeeRepository: {
@@ -17,7 +10,9 @@ describe('GetMembershipFeesUseCase', () => {
   let memberPaymentRepository: {
     findByLeagueIdAndDriverId: Mock;
   };
-  let presenter: TestPresenter;
+  let output: {
+    present: Mock;
+  };
   let useCase: GetMembershipFeesUseCase;
 
   beforeEach(() => {
@@ -29,28 +24,24 @@ describe('GetMembershipFeesUseCase', () => {
       findByLeagueIdAndDriverId: vi.fn(),
     } as unknown as IMemberPaymentRepository as any;
 
-    presenter = {
-      reset: vi.fn(),
-      present: vi.fn((dto: GetMembershipFeesResultDTO) => {
-        presenter.lastDto = dto;
-      }),
-      toViewModel: vi.fn((dto: GetMembershipFeesResultDTO) => ({
-        fee: dto.fee,
-        payments: dto.payments,
-      })),
-    } as unknown as TestPresenter;
+    output = {
+      present: vi.fn(),
+    };
 
     useCase = new GetMembershipFeesUseCase(
       membershipFeeRepository as unknown as IMembershipFeeRepository,
       memberPaymentRepository as unknown as IMemberPaymentRepository,
+      output as unknown as UseCaseOutputPort<any>,
     );
   });
 
-  it('throws when leagueId is missing', async () => {
+  it('returns error when leagueId is missing', async () => {
     const input = { leagueId: '' } as GetMembershipFeesInput;
 
-    await expect(useCase.execute(input, presenter)).rejects.toThrow('leagueId is required');
-    expect(presenter.reset).toHaveBeenCalled();
+    const result = await useCase.execute(input);
+
+    expect(result.isErr()).toBe(true);
+    expect(result.unwrapErr().code).toBe('INVALID_INPUT');
   });
 
   it('returns null fee and empty payments when no fee exists', async () => {
@@ -58,11 +49,12 @@ describe('GetMembershipFeesUseCase', () => {
 
     membershipFeeRepository.findByLeagueId.mockResolvedValue(null);
 
-    await useCase.execute(input, presenter);
+    const result = await useCase.execute(input);
 
+    expect(result.isOk()).toBe(true);
     expect(membershipFeeRepository.findByLeagueId).toHaveBeenCalledWith('league-1');
     expect(memberPaymentRepository.findByLeagueIdAndDriverId).not.toHaveBeenCalled();
-    expect(presenter.present).toHaveBeenCalledWith({
+    expect(output.present).toHaveBeenCalledWith({
       fee: null,
       payments: [],
     });
@@ -99,35 +91,15 @@ describe('GetMembershipFeesUseCase', () => {
     membershipFeeRepository.findByLeagueId.mockResolvedValue(fee);
     memberPaymentRepository.findByLeagueIdAndDriverId.mockResolvedValue(payments);
 
-    await useCase.execute(input, presenter);
+    const result = await useCase.execute(input);
 
+    expect(result.isOk()).toBe(true);
     expect(membershipFeeRepository.findByLeagueId).toHaveBeenCalledWith('league-1');
     expect(memberPaymentRepository.findByLeagueIdAndDriverId).toHaveBeenCalledWith('league-1', 'driver-1', membershipFeeRepository as unknown as IMembershipFeeRepository);
 
-    expect(presenter.present).toHaveBeenCalledWith({
-      fee: {
-        id: fee.id,
-        leagueId: fee.leagueId,
-        seasonId: fee.seasonId,
-        type: fee.type,
-        amount: fee.amount,
-        enabled: fee.enabled,
-        createdAt: fee.createdAt,
-        updatedAt: fee.updatedAt,
-      },
-      payments: [
-        {
-          id: 'pay-1',
-          feeId: 'fee-1',
-          driverId: 'driver-1',
-          amount: 100,
-          platformFee: 5,
-          netAmount: 95,
-          status: 'paid',
-          dueDate: payments[0].dueDate,
-          paidAt: payments[0].paidAt,
-        },
-      ],
+    expect(output.present).toHaveBeenCalledWith({
+      fee,
+      payments,
     });
   });
 });