refactor

core/racing/application/use-cases/DashboardOverviewUseCase.test.ts

@@ -1,34 +1,14 @@
 import { describe, it, expect } from 'vitest';
 
-import { GetDashboardOverviewUseCase } from '@core/racing/application/use-cases/GetDashboardOverviewUseCase';
+import { DashboardOverviewUseCase } from '@core/racing/application/use-cases/DashboardOverviewUseCase';
 import { Driver } from '@core/racing/domain/entities/Driver';
 import { Race } from '@core/racing/domain/entities/Race';
 import { Result } from '@core/racing/domain/entities/Result';
 import { League } from '@core/racing/domain/entities/League';
 import { Standing } from '@core/racing/domain/entities/Standing';
+import { LeagueMembership, JoinRequest } from '@core/racing/domain/entities/LeagueMembership';
 
 import type { FeedItem } from '@core/social/domain/types/FeedItem';
-import type {
-  IDashboardOverviewPresenter,
-  DashboardOverviewViewModel,
-  DashboardFeedItemSummaryViewModel,
-} from '@core/racing/application/presenters/IDashboardOverviewPresenter';
-
-class FakeDashboardOverviewPresenter implements IDashboardOverviewPresenter {
-  viewModel: DashboardOverviewViewModel | null = null;
-
-  reset(): void {
-    this.viewModel = null;
-  }
-
-  present(viewModel: DashboardOverviewViewModel): void {
-    this.viewModel = viewModel;
-  }
-
-  getViewModel(): DashboardOverviewViewModel | null {
-    return this.viewModel;
-  }
-}
 
 interface TestImageService {
   getDriverAvatar(driverId: string): string;
@@ -46,7 +26,7 @@ function createTestImageService(): TestImageService {
   };
 }
 
-describe('GetDashboardOverviewUseCase', () => {
+describe('DashboardOverviewUseCase', () => {
   it('partitions upcoming races into myUpcomingRaces and otherUpcomingRaces and selects nextRace from myUpcomingRaces', async () => {
     // Given a driver with memberships in two leagues and future races with mixed registration
     const driverId = 'driver-1';
@@ -189,10 +169,10 @@ describe('GetDashboardOverviewUseCase', () => {
         );
       },
       getLeagueMembers: async (): Promise<LeagueMembership[]> => [],
-      getJoinRequests: async (): Promise<any[]> => [],
+      getJoinRequests: async (): Promise<JoinRequest[]> => [],
       saveMembership: async (): Promise<LeagueMembership> => { throw new Error('Not implemented'); },
       removeMembership: async (): Promise<void> => { throw new Error('Not implemented'); },
-      saveJoinRequest: async (): Promise<any> => { throw new Error('Not implemented'); },
+      saveJoinRequest: async (): Promise<JoinRequest> => { throw new Error('Not implemented'); },
       removeJoinRequest: async (): Promise<void> => { throw new Error('Not implemented'); },
     };
  
@@ -234,9 +214,7 @@ describe('GetDashboardOverviewUseCase', () => {
           }
         : null;
 
-    const presenter = new FakeDashboardOverviewPresenter();
-
-    const useCase = new GetDashboardOverviewUseCase(
+    const useCase = new DashboardOverviewUseCase(
       driverRepository,
       raceRepository,
       resultRepository,
@@ -251,12 +229,10 @@ describe('GetDashboardOverviewUseCase', () => {
     );
 
     // When
-    await useCase.execute({ driverId }, presenter);
+    const result = await useCase.execute({ driverId });
+    expect(result.isOk()).toBe(true);
 
-    const viewModel = presenter.getViewModel();
-    expect(viewModel).not.toBeNull();
-
-    const vm = viewModel!;
+    const vm = result.unwrap();
 
     // Then myUpcomingRaces only contains registered races from the driver's leagues
     expect(vm.myUpcomingRaces.map((r) => r.id)).toEqual(['race-1', 'race-3']);
@@ -422,10 +398,10 @@ describe('GetDashboardOverviewUseCase', () => {
         );
       },
       getLeagueMembers: async (): Promise<LeagueMembership[]> => [],
-      getJoinRequests: async (): Promise<any[]> => [],
+      getJoinRequests: async (): Promise<JoinRequest[]> => [],
       saveMembership: async (): Promise<LeagueMembership> => { throw new Error('Not implemented'); },
       removeMembership: async (): Promise<void> => { throw new Error('Not implemented'); },
-      saveJoinRequest: async (): Promise<any> => { throw new Error('Not implemented'); },
+      saveJoinRequest: async (): Promise<JoinRequest> => { throw new Error('Not implemented'); },
       removeJoinRequest: async (): Promise<void> => { throw new Error('Not implemented'); },
     };
  
@@ -464,9 +440,7 @@ describe('GetDashboardOverviewUseCase', () => {
           }
         : null;
 
-    const presenter = new FakeDashboardOverviewPresenter();
-
-    const useCase = new GetDashboardOverviewUseCase(
+    const useCase = new DashboardOverviewUseCase(
       driverRepository,
       raceRepository,
       resultRepository,
@@ -481,12 +455,10 @@ describe('GetDashboardOverviewUseCase', () => {
     );
 
     // When
-    await useCase.execute({ driverId }, presenter);
+    const result = await useCase.execute({ driverId });
+    expect(result.isOk()).toBe(true);
 
-    const viewModel = presenter.getViewModel();
-    expect(viewModel).not.toBeNull();
-
-    const vm = viewModel!;
+    const vm = result.unwrap();
 
     // Then recentResults are sorted by finishedAt descending (newest first)
     expect(vm.recentResults.length).toBe(2);
@@ -584,10 +556,10 @@ describe('GetDashboardOverviewUseCase', () => {
     const leagueMembershipRepository = {
       getMembership: async (): Promise<LeagueMembership | null> => null,
       getLeagueMembers: async (): Promise<LeagueMembership[]> => [],
-      getJoinRequests: async (): Promise<any[]> => [],
+      getJoinRequests: async (): Promise<JoinRequest[]> => [],
       saveMembership: async (): Promise<LeagueMembership> => { throw new Error('Not implemented'); },
       removeMembership: async (): Promise<void> => { throw new Error('Not implemented'); },
-      saveJoinRequest: async (): Promise<any> => { throw new Error('Not implemented'); },
+      saveJoinRequest: async (): Promise<JoinRequest> => { throw new Error('Not implemented'); },
       removeJoinRequest: async (): Promise<void> => { throw new Error('Not implemented'); },
     };
  
@@ -616,9 +588,7 @@ describe('GetDashboardOverviewUseCase', () => {
 
     const getDriverStats = () => null;
 
-    const presenter = new FakeDashboardOverviewPresenter();
-
-    const useCase = new GetDashboardOverviewUseCase(
+    const useCase = new DashboardOverviewUseCase(
       driverRepository,
       raceRepository,
       resultRepository,
@@ -633,12 +603,10 @@ describe('GetDashboardOverviewUseCase', () => {
     );
 
     // When
-    await useCase.execute({ driverId }, presenter);
+    const result = await useCase.execute({ driverId });
+    expect(result.isOk()).toBe(true);
 
-    const viewModel = presenter.getViewModel();
-    expect(viewModel).not.toBeNull();
-
-    const vm = viewModel!;
+    const vm = result.unwrap();
 
     // Then collections are empty and no errors are thrown
     expect(vm.myUpcomingRaces).toEqual([]);