refactor

core/racing/application/use-cases/ApproveTeamJoinRequestUseCase.ts

@@ -1,4 +1,3 @@
-import type { Logger } from '@core/shared/application';
 import type { ITeamMembershipRepository } from '../../domain/repositories/ITeamMembershipRepository';
 import type {
   TeamMembership,
@@ -8,36 +7,24 @@ import type {
 } from '../../domain/types/TeamMembership';
 import type { ApproveTeamJoinRequestCommandDTO } from '../dto/TeamCommandAndQueryDTO';
 import type { AsyncUseCase } from '@core/shared/application';
+import { Result } from '@core/shared/result/Result';
+import { RacingDomainValidationError } from '../../domain/errors/RacingDomainError';
 
 export class ApproveTeamJoinRequestUseCase
-  implements AsyncUseCase<ApproveTeamJoinRequestCommandDTO, void> {
+  implements AsyncUseCase<ApproveTeamJoinRequestCommandDTO, Result<void, RacingDomainValidationError>> {
   constructor(
     private readonly membershipRepository: ITeamMembershipRepository,
-    private readonly logger: Logger,
   ) {}
 
-  async execute(command: ApproveTeamJoinRequestCommandDTO): Promise<void> {
-    const { requestId } = command;
-    this.logger.debug(
-      `Attempting to approve team join request with ID: ${requestId}`,
-    );
+  async execute(command: ApproveTeamJoinRequestCommandDTO): Promise<Result<void, RacingDomainValidationError>> {
+    const { teamId, requestId } = command;
 
-    // There is no repository method to look up a single request by ID,
-    try {
-      // There is no repository method to look up a single request by ID,
-      // so we rely on the repository implementation to surface all relevant
-      // requests via getJoinRequests and search by ID here.
-      const allRequests: TeamJoinRequest[] = await this.membershipRepository.getJoinRequests(
-        // For the in-memory fake used in tests, the teamId argument is ignored
-        // and all requests are returned.'
-        '' as string,
-      );
-      const request = allRequests.find((r) => r.id === requestId);
+    const allRequests: TeamJoinRequest[] = await this.membershipRepository.getJoinRequests(teamId);
+    const request = allRequests.find((r) => r.id === requestId);
 
-      if (!request) {
-        this.logger.warn(`Team join request with ID ${requestId} not found`);
-        throw new Error('Join request not found');
-      }
+    if (!request) {
+      return Result.err(new RacingDomainValidationError('Join request not found'));
+    }
 
     const membership: TeamMembership = {
       teamId: request.teamId,
@@ -48,14 +35,7 @@ export class ApproveTeamJoinRequestUseCase
     };
 
     await this.membershipRepository.saveMembership(membership);
-    this.logger.info(
-      `Team membership created for driver ${request.driverId} in team ${request.teamId} from request ${requestId}`,
-    );
     await this.membershipRepository.removeJoinRequest(requestId);
-    this.logger.info(`Team join request with ID ${requestId} removed`);
-   } catch (error) {
-     this.logger.error(`Failed to approve team join request ${requestId}`, error instanceof Error ? error : new Error(String(error)));
-     throw error;
-   }
+    return Result.ok(undefined);
   }
 }