presenter refactoring

apps/api/src/domain/analytics/AnalyticsController.test.ts

@@ -42,8 +42,8 @@ describe('AnalyticsController', () => {
         userAgent: 'Mozilla/5.0',
         country: 'US',
       };
-      const output = { pageViewId: 'pv-123' };
-      service.recordPageView.mockResolvedValue(output);
+      const presenterMock = { viewModel: { pageViewId: 'pv-123' } };
+      service.recordPageView.mockResolvedValue(presenterMock as any);
 
       const mockRes: ReturnType<typeof vi.mocked<Response>> = {
         status: vi.fn().mockReturnThis(),
@@ -54,7 +54,7 @@ describe('AnalyticsController', () => {
 
       expect(service.recordPageView).toHaveBeenCalledWith(input);
       expect(mockRes.status).toHaveBeenCalledWith(201);
-      expect(mockRes.json).toHaveBeenCalledWith(output);
+      expect(mockRes.json).toHaveBeenCalledWith(presenterMock.viewModel);
     });
   });
 
@@ -69,8 +69,8 @@ describe('AnalyticsController', () => {
         actorId: 'actor-789',
         metadata: { key: 'value' },
       };
-      const output = { eventId: 'event-123', engagementWeight: 10 };
-      service.recordEngagement.mockResolvedValue(output);
+      const presenterMock = { eventId: 'event-123', engagementWeight: 10 };
+      service.recordEngagement.mockResolvedValue(presenterMock as any);
 
       const mockRes: ReturnType<typeof vi.mocked<Response>> = {
         status: vi.fn().mockReturnThis(),
@@ -81,41 +81,45 @@ describe('AnalyticsController', () => {
 
       expect(service.recordEngagement).toHaveBeenCalledWith(input);
       expect(mockRes.status).toHaveBeenCalledWith(201);
-      expect(mockRes.json).toHaveBeenCalledWith(output);
+      expect(mockRes.json).toHaveBeenCalledWith((presenterMock as any).viewModel);
     });
   });
 
   describe('getDashboardData', () => {
     it('should return dashboard data', async () => {
-      const output = {
-        totalUsers: 100,
-        activeUsers: 50,
-        totalRaces: 20,
-        totalLeagues: 5,
+      const presenterMock = {
+        viewModel: {
+          totalUsers: 100,
+          activeUsers: 50,
+          totalRaces: 20,
+          totalLeagues: 5,
+        },
       };
-      service.getDashboardData.mockResolvedValue(output);
+      service.getDashboardData.mockResolvedValue(presenterMock as any);
 
       const result = await controller.getDashboardData();
 
       expect(service.getDashboardData).toHaveBeenCalled();
-      expect(result).toEqual(output);
+      expect(result).toEqual(presenterMock.viewModel);
     });
   });
 
   describe('getAnalyticsMetrics', () => {
     it('should return analytics metrics', async () => {
-      const output = {
-        pageViews: 1000,
-        uniqueVisitors: 500,
-        averageSessionDuration: 300,
-        bounceRate: 0.4,
+      const presenterMock = {
+        viewModel: {
+          pageViews: 1000,
+          uniqueVisitors: 500,
+          averageSessionDuration: 300,
+          bounceRate: 0.4,
+        },
       };
-      service.getAnalyticsMetrics.mockResolvedValue(output);
+      service.getAnalyticsMetrics.mockResolvedValue(presenterMock as any);
 
       const result = await controller.getAnalyticsMetrics();
 
       expect(service.getAnalyticsMetrics).toHaveBeenCalled();
-      expect(result).toEqual(output);
+      expect(result).toEqual(presenterMock.viewModel);
     });
   });
 });