fix issues in core
This commit is contained in:
@@ -58,10 +58,10 @@ export class ReviewProtestUseCase {
|
||||
// Validate steward has authority (owner or admin of the league)
|
||||
const memberships = await this.leagueMembershipRepository.getLeagueMembers(race.leagueId);
|
||||
const stewardMembership = memberships.find(
|
||||
m => m.driverId === input.stewardId && m.status === 'active'
|
||||
m => m.driverId.toString() === input.stewardId && m.status.toString() === 'active'
|
||||
);
|
||||
|
||||
if (!stewardMembership || (stewardMembership.role !== 'owner' && stewardMembership.role !== 'admin')) {
|
||||
if (!stewardMembership || (stewardMembership.role.toString() !== 'owner' && stewardMembership.role.toString() !== 'admin')) {
|
||||
this.logger.warn('Unauthorized steward attempting to review protest', { stewardId: input.stewardId, leagueId: race.leagueId });
|
||||
return Result.err({ code: 'NOT_LEAGUE_ADMIN', details: { message: 'Only league owners and admins can review protests' } });
|
||||
}
|
||||
@@ -90,7 +90,7 @@ export class ReviewProtestUseCase {
|
||||
return Result.ok(undefined);
|
||||
} catch (error) {
|
||||
const message = error instanceof Error ? error.message : 'Failed to review protest';
|
||||
this.logger.error('Failed to review protest', { error: message });
|
||||
this.logger.error('Failed to review protest', new Error(message));
|
||||
return Result.err({ code: 'REPOSITORY_ERROR', details: { message } });
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user