refactor

apps/api/src/domain/league/presenters/GetLeagueMembershipsPresenter.ts

@@ -1,5 +1,5 @@
 import { IGetLeagueMembershipsPresenter, GetLeagueMembershipsResultDTO, GetLeagueMembershipsViewModel } from '@core/racing/application/presenters/IGetLeagueMembershipsPresenter';
-import { LeagueMembershipsViewModel } from '../dto/LeagueDto';
+import { LeagueMembershipsDTO } from '../dtos/LeagueMembershipsDTO';
 
 export class GetLeagueMembershipsPresenter implements IGetLeagueMembershipsPresenter {
   private result: GetLeagueMembershipsViewModel | null = null;
@@ -40,7 +40,7 @@ export class GetLeagueMembershipsPresenter implements IGetLeagueMembershipsPrese
   }
 
   // API-specific method
-  get apiViewModel(): LeagueMembershipsViewModel | null {
+  get apiViewModel(): LeagueMembershipsDTO | null {
     if (!this.result?.memberships) return null;
     return this.result.memberships as LeagueMembershipsViewModel;
   }

apps/api/src/domain/league/presenters/LeagueAdminPresenter.ts

@@ -1,7 +1,7 @@
-import { LeagueAdminViewModel } from '../dto/LeagueDto';
+import { LeagueAdminDTO } from '../dtos/LeagueAdminDTO';
 
 export class LeagueAdminPresenter {
-  private result: LeagueAdminViewModel | null = null;
+  private result: LeagueAdminDTO | null = null;
 
   reset() {
     this.result = null;
@@ -23,7 +23,7 @@ export class LeagueAdminPresenter {
     };
   }
 
-  getViewModel(): LeagueAdminViewModel {
+  getViewModel(): LeagueAdminDTO {
     if (!this.result) throw new Error('Presenter not presented');
     return this.result;
   }

apps/api/src/domain/league/presenters/LeagueConfigPresenter.ts

@@ -1,5 +1,5 @@
 import { ILeagueFullConfigPresenter, LeagueFullConfigData, LeagueConfigFormViewModel } from '@core/racing/application/presenters/ILeagueFullConfigPresenter';
-import { LeagueConfigFormModelDto } from '../dto/LeagueDto';
+import { LeagueConfigFormModelDTO } from '../dtos/LeagueConfigFormModelDTO';
 
 export class LeagueConfigPresenter implements ILeagueFullConfigPresenter {
   private result: LeagueConfigFormViewModel | null = null;
@@ -65,7 +65,7 @@ export class LeagueConfigPresenter implements ILeagueFullConfigPresenter {
   }
 
   // API-specific method to get the DTO
-  get viewModel(): LeagueConfigFormModelDto | null {
+  get viewModel(): LeagueConfigFormModelDTO | null {
     if (!this.result) return null;
 
     // Map from LeagueConfigFormViewModel to LeagueConfigFormModelDto

apps/api/src/domain/league/presenters/LeagueScoringConfigPresenter.ts

@@ -0,0 +1,150 @@
+import type { ChampionshipConfig } from '@core/racing/domain/types/ChampionshipConfig';
+import type { BonusRule } from '@core/racing/domain/types/BonusRule';
+import type {
+  ILeagueScoringConfigPresenter,
+  LeagueScoringConfigData,
+  LeagueScoringConfigViewModel,
+  LeagueScoringChampionshipViewModel,
+} from '@core/racing/application/presenters/ILeagueScoringConfigPresenter';
+
+export class LeagueScoringConfigPresenter implements ILeagueScoringConfigPresenter {
+  private viewModel: LeagueScoringConfigViewModel | null = null;
+
+  reset(): void {
+    this.viewModel = null;
+  }
+
+  present(data: LeagueScoringConfigData): LeagueScoringConfigViewModel {
+    const championships: LeagueScoringChampionshipViewModel[] =
+      data.championships.map((champ) => this.mapChampionship(champ));
+
+    const dropPolicySummary =
+      data.preset?.dropPolicySummary ??
+      this.deriveDropPolicyDescriptionFromChampionships(data.championships);
+
+    this.viewModel = {
+      leagueId: data.leagueId,
+      seasonId: data.seasonId,
+      gameId: data.gameId,
+      gameName: data.gameName,
+      scoringPresetId: data.scoringPresetId ?? 'custom',
+      scoringPresetName: data.preset?.name ?? 'Custom',
+      dropPolicySummary,
+      championships,
+    };
+
+    return this.viewModel;
+  }
+
+  getViewModel(): LeagueScoringConfigViewModel | null {
+    return this.viewModel;
+  }
+
+  private mapChampionship(championship: ChampionshipConfig): LeagueScoringChampionshipViewModel {
+    const sessionTypes = championship.sessionTypes.map((s) => s.toString());
+    const pointsPreview = this.buildPointsPreview(championship.pointsTableBySessionType);
+    const bonusSummary = this.buildBonusSummary(
+      championship.bonusRulesBySessionType ?? {},
+    );
+    const dropPolicyDescription = this.deriveDropPolicyDescription(
+      championship.dropScorePolicy,
+    );
+
+    return {
+      id: championship.id,
+      name: championship.name,
+      type: championship.type,
+      sessionTypes,
+      pointsPreview,
+      bonusSummary,
+      dropPolicyDescription,
+    };
+  }
+
+  private buildPointsPreview(
+    tables: Record<string, { getPointsForPosition: (position: number) => number }>,
+  ): Array<{ sessionType: string; position: number; points: number }> {
+    const preview: Array<{
+      sessionType: string;
+      position: number;
+      points: number;
+    }> = [];
+
+    const maxPositions = 10;
+
+    for (const [sessionType, table] of Object.entries(tables)) {
+      for (let pos = 1; pos <= maxPositions; pos++) {
+        const points = table.getPointsForPosition(pos);
+        if (points && points !== 0) {
+          preview.push({
+            sessionType,
+            position: pos,
+            points,
+          });
+        }
+      }
+    }
+
+    return preview;
+  }
+
+  private buildBonusSummary(
+    bonusRulesBySessionType: Record<string, BonusRule[]>,
+  ): string[] {
+    const summaries: string[] = [];
+
+    for (const [sessionType, rules] of Object.entries(bonusRulesBySessionType)) {
+      for (const rule of rules) {
+        if (rule.type === 'fastestLap') {
+          const base = `Fastest lap in ${sessionType}`;
+          if (rule.requiresFinishInTopN) {
+            summaries.push(
+              `${base} +${rule.points} points if finishing P${rule.requiresFinishInTopN} or better`,
+            );
+          } else {
+            summaries.push(`${base} +${rule.points} points`);
+          }
+        } else {
+          summaries.push(
+            `${rule.type} bonus in ${sessionType} worth ${rule.points} points`,
+          );
+        }
+      }
+    }
+
+    return summaries;
+  }
+
+  private deriveDropPolicyDescriptionFromChampionships(
+    championships: ChampionshipConfig[],
+  ): string {
+    const first = championships[0];
+    if (!first) {
+      return 'All results count';
+    }
+    return this.deriveDropPolicyDescription(first.dropScorePolicy);
+  }
+
+  private deriveDropPolicyDescription(policy: {
+    strategy: string;
+    count?: number;
+    dropCount?: number;
+  }): string {
+    if (!policy || policy.strategy === 'none') {
+      return 'All results count';
+    }
+
+    if (policy.strategy === 'bestNResults' && typeof policy.count === 'number') {
+      return `Best ${policy.count} results count towards the championship`;
+    }
+
+    if (
+      policy.strategy === 'dropWorstN' &&
+      typeof policy.dropCount === 'number'
+    ) {
+      return `Worst ${policy.dropCount} results are dropped from the championship total`;
+    }
+
+    return 'Custom drop score rules apply';
+  }
+}

apps/api/src/domain/league/presenters/LeagueScoringPresetsPresenter.ts

@@ -0,0 +1,23 @@
+import type {
+  ILeagueScoringPresetsPresenter,
+  LeagueScoringPresetsResultDTO,
+  LeagueScoringPresetsViewModel,
+} from '@core/racing/application/presenters/ILeagueScoringPresetsPresenter';
+
+export class LeagueScoringPresetsPresenter implements ILeagueScoringPresetsPresenter {
+  private viewModel: LeagueScoringPresetsViewModel | null = null;
+
+  reset(): void {
+    this.viewModel = null;
+  }
+
+  present(dto: LeagueScoringPresetsResultDTO): void {
+    this.viewModel = {
+      presets: dto.presets,
+    };
+  }
+
+  getViewModel(): LeagueScoringPresetsViewModel | null {
+    return this.viewModel;
+  }
+}

apps/api/src/domain/league/presenters/TotalLeaguesPresenter.ts

@@ -1,5 +1,5 @@
 import { IGetTotalLeaguesPresenter, GetTotalLeaguesResultDTO, GetTotalLeaguesViewModel } from '@core/racing/application/presenters/IGetTotalLeaguesPresenter';
-import { LeagueStatsDto } from '../dto/LeagueDto';
+import { LeagueStatsDTO } from '../dtos/LeagueStatsDTO';
 
 export class TotalLeaguesPresenter implements IGetTotalLeaguesPresenter {
   private result: LeagueStatsDto | null = null;