view data fixes

apps/website/lib/view-models/CreateLeagueViewModel.test.ts

@@ -1,36 +1,102 @@
 import { describe, it, expect } from 'vitest';
 import { CreateLeagueViewModel } from './CreateLeagueViewModel';
-import type { CreateLeagueOutputDTO } from '../types/generated/CreateLeagueOutputDTO';
+import type { CreateLeagueViewData } from '../view-data/CreateLeagueViewData';
 
-const createDto = (overrides: Partial<CreateLeagueOutputDTO> = {}): CreateLeagueOutputDTO => ({
+const createViewData = (overrides: Partial<CreateLeagueViewData> = {}): CreateLeagueViewData => ({
   leagueId: 'league-1',
   success: true,
   ...overrides,
-} as CreateLeagueOutputDTO);
+} as CreateLeagueViewData);
 
 describe('CreateLeagueViewModel', () => {
-  it('maps leagueId and success from DTO', () => {
-    const dto = createDto({ leagueId: 'league-123', success: true });
+  describe('constructor', () => {
+    it('should create instance with success flag', () => {
+      const viewData: CreateLeagueViewData = {
+        leagueId: 'league-123',
+        success: true,
+        successMessage: 'League created successfully!',
+      };
 
-    const vm = new CreateLeagueViewModel(dto);
+      const viewModel = new CreateLeagueViewModel(viewData);
 
-    expect(vm.leagueId).toBe('league-123');
-    expect(vm.success).toBe(true);
+      expect(viewModel.success).toBe(true);
+    });
+
+    it('should create instance with leagueId', () => {
+      const viewData: CreateLeagueViewData = {
+        leagueId: 'league-123',
+        success: true,
+        successMessage: 'League created successfully!',
+      };
+
+      const viewModel = new CreateLeagueViewModel(viewData);
+
+      expect(viewModel.leagueId).toBe('league-123');
+    });
+
+    it('should create instance with all fields', () => {
+      const viewData: CreateLeagueViewData = {
+        leagueId: 'test-league',
+        success: false,
+        successMessage: 'Failed to create league.',
+      };
+
+      const viewModel = new CreateLeagueViewModel(viewData);
+
+      expect(viewModel.leagueId).toBe('test-league');
+      expect(viewModel.success).toBe(false);
+    });
   });
 
-  it('returns success successMessage when creation succeeded', () => {
-    const dto = createDto({ success: true });
+  describe('UI-specific getters', () => {
+    it('should expose isSuccessful as true when success is true', () => {
+      const viewData: CreateLeagueViewData = {
+        leagueId: 'league-123',
+        success: true,
+        successMessage: 'League created successfully!',
+      };
 
-    const vm = new CreateLeagueViewModel(dto);
+      const viewModel = new CreateLeagueViewModel(viewData);
 
-    expect(vm.successMessage).toBe('League created successfully!');
+      expect(viewModel.isSuccessful).toBe(true);
+    });
+
+    it('should expose isSuccessful as false when success is false', () => {
+      const viewData: CreateLeagueViewData = {
+        leagueId: 'league-123',
+        success: false,
+        successMessage: 'Failed to create league.',
+      };
+
+      const viewModel = new CreateLeagueViewModel(viewData);
+
+      expect(viewModel.isSuccessful).toBe(false);
+    });
   });
 
-  it('returns failure successMessage when creation failed', () => {
-    const dto = createDto({ success: false });
+  describe('Display Object composition', () => {
+    it('should derive successMessage from success', () => {
+      const viewData: CreateLeagueViewData = {
+        leagueId: 'league-123',
+        success: true,
+        successMessage: 'League created successfully!',
+      };
 
-    const vm = new CreateLeagueViewModel(dto);
+      const viewModel = new CreateLeagueViewModel(viewData);
 
-    expect(vm.successMessage).toBe('Failed to create league.');
+      expect(viewModel.successMessage).toBe('League created successfully!');
+    });
+
+    it('should derive successMessage from failure', () => {
+      const viewData: CreateLeagueViewData = {
+        leagueId: 'league-123',
+        success: false,
+        successMessage: 'Failed to create league.',
+      };
+
+      const viewModel = new CreateLeagueViewModel(viewData);
+
+      expect(viewModel.successMessage).toBe('Failed to create league.');
+    });
   });
 });