code quality

adapters/notifications/gateways/DiscordNotificationGateway.test.ts

@@ -1,6 +1,7 @@
 import { describe, it, expect, beforeEach, vi } from 'vitest';
 import { DiscordNotificationAdapter } from './DiscordNotificationGateway';
 import { Notification } from '@core/notifications/domain/entities/Notification';
+import type { NotificationChannel } from '@core/notifications/domain/types/NotificationTypes';
 
 describe('DiscordNotificationAdapter', () => {
   const webhookUrl = 'https://discord.com/api/webhooks/123/abc';
@@ -11,7 +12,7 @@ describe('DiscordNotificationAdapter', () => {
     vi.spyOn(console, 'log').mockImplementation(() => {});
   });
 
-  const createNotification = (overrides: any = {}) => {
+  const createNotification = (overrides: Partial<Parameters<typeof Notification.create>[0]> = {}) => {
     return Notification.create({
       id: 'notif-123',
       recipientId: 'driver-456',
@@ -58,7 +59,7 @@ describe('DiscordNotificationAdapter', () => {
     });
 
     it('should return false for other channels', () => {
-      expect(adapter.supportsChannel('email' as any)).toBe(false);
+      expect(adapter.supportsChannel('email' as unknown as NotificationChannel)).toBe(false);
     });
   });
 

adapters/notifications/gateways/EmailNotificationGateway.test.ts

@@ -1,6 +1,7 @@
 import { describe, it, expect, beforeEach, vi } from 'vitest';
 import { EmailNotificationAdapter } from './EmailNotificationGateway';
 import { Notification } from '@core/notifications/domain/entities/Notification';
+import type { NotificationChannel } from '@core/notifications/domain/types/NotificationTypes';
 
 describe('EmailNotificationAdapter', () => {
   const config = {
@@ -14,7 +15,7 @@ describe('EmailNotificationAdapter', () => {
     vi.spyOn(console, 'log').mockImplementation(() => {});
   });
 
-  const createNotification = (overrides: any = {}) => {
+  const createNotification = (overrides: Partial<Parameters<typeof Notification.create>[0]> = {}) => {
     return Notification.create({
       id: 'notif-123',
       recipientId: 'driver-456',

adapters/notifications/gateways/InAppNotificationGateway.test.ts

@@ -1,6 +1,7 @@
 import { describe, it, expect, beforeEach, vi } from 'vitest';
 import { InAppNotificationAdapter } from './InAppNotificationGateway';
 import { Notification } from '@core/notifications/domain/entities/Notification';
+import type { NotificationChannel } from '@core/notifications/domain/types/NotificationTypes';
 
 describe('InAppNotificationAdapter', () => {
   let adapter: InAppNotificationAdapter;
@@ -10,7 +11,7 @@ describe('InAppNotificationAdapter', () => {
     vi.spyOn(console, 'log').mockImplementation(() => {});
   });
 
-  const createNotification = (overrides: any = {}) => {
+  const createNotification = (overrides: Partial<Parameters<typeof Notification.create>[0]> = {}) => {
     return Notification.create({
       id: 'notif-123',
       recipientId: 'driver-456',

adapters/notifications/gateways/NotificationGatewayRegistry.test.ts

@@ -2,7 +2,6 @@ import { describe, it, expect, beforeEach, vi } from 'vitest';
 import { NotificationGatewayRegistry } from './NotificationGatewayRegistry';
 import { Notification } from '@core/notifications/domain/entities/Notification';
 import type { NotificationGateway, NotificationDeliveryResult } from '@core/notifications/application/ports/NotificationGateway';
-import type { NotificationChannel } from '@core/notifications/domain/types/NotificationTypes';
 
 describe('NotificationGatewayRegistry', () => {
   let registry: NotificationGatewayRegistry;
@@ -18,7 +17,7 @@ describe('NotificationGatewayRegistry', () => {
     registry = new NotificationGatewayRegistry([mockGateway]);
   });
 
-  const createNotification = (overrides: any = {}) => {
+  const createNotification = (overrides: Partial<Parameters<typeof Notification.create>[0]> = {}) => {
     return Notification.create({
       id: 'notif-123',
       recipientId: 'driver-456',
@@ -35,7 +34,7 @@ describe('NotificationGatewayRegistry', () => {
       const discordGateway = {
         ...mockGateway,
         getChannel: vi.fn().mockReturnValue('discord'),
-      } as any;
+      } as unknown as NotificationGateway;
       
       registry.register(discordGateway);
       expect(registry.getGateway('discord')).toBe(discordGateway);