refactor racing use cases

core/racing/application/use-cases/RegisterForRaceUseCase.ts

@@ -1,26 +1,33 @@
 import type { IRaceRegistrationRepository } from '@core/racing/domain/repositories/IRaceRegistrationRepository';
 import type { ILeagueMembershipRepository } from '@core/racing/domain/repositories/ILeagueMembershipRepository';
 import { RaceRegistration } from '@core/racing/domain/entities/RaceRegistration';
-import type { AsyncUseCase } from '@core/shared/application';
+import { Logger, UseCaseOutputPort } from '@core/shared/application';
 import { Result } from '@core/shared/application/Result';
 import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
-import { Logger } from '@core/shared/application';
 
-export interface RegisterForRaceParams {
+export type RegisterForRaceInput = {
   raceId: string;
   leagueId: string;
   driverId: string;
-}
+};
 
-type RegisterForRaceErrorCode = 'ALREADY_REGISTERED' | 'NOT_ACTIVE_MEMBER';
+export type RegisterForRaceResult = {
+  raceId: string;
+  driverId: string;
+  status: 'registered';
+};
 
-export class RegisterForRaceUseCase
-  implements AsyncUseCase<RegisterForRaceParams, void, RegisterForRaceErrorCode>
-{
+export type RegisterForRaceErrorCode =
+  | 'ALREADY_REGISTERED'
+  | 'NOT_ACTIVE_MEMBER'
+  | 'REPOSITORY_ERROR';
+
+export class RegisterForRaceUseCase {
   constructor(
     private readonly registrationRepository: IRaceRegistrationRepository,
     private readonly membershipRepository: ILeagueMembershipRepository,
     private readonly logger: Logger,
+    private readonly output: UseCaseOutputPort<RegisterForRaceResult>,
   ) {}
 
   /**
@@ -29,30 +36,75 @@ export class RegisterForRaceUseCase
    * - validates active league membership
    * - registers driver for race
    */
-  async execute(params: RegisterForRaceParams): Promise<Result<void, ApplicationErrorCode<RegisterForRaceErrorCode>>> {
-    const { raceId, leagueId, driverId } = params;
+  async execute(
+    input: RegisterForRaceInput,
+  ): Promise<
+    Result<
+      void,
+      ApplicationErrorCode<
+        RegisterForRaceErrorCode,
+        {
+          message: string;
+        }
+      >
+    >
+  > {
+    const { raceId, leagueId, driverId } = input;
     this.logger.debug('RegisterForRaceUseCase: executing params', { raceId, leagueId, driverId });
 
-    const alreadyRegistered = await this.registrationRepository.isRegistered(raceId, driverId);
-    if (alreadyRegistered) {
-      this.logger.warn(`RegisterForRaceUseCase: driver ${driverId} already registered for race ${raceId}`);
-      return Result.err({ code: 'ALREADY_REGISTERED', details: { message: 'Already registered for this race' } });
+    try {
+      const alreadyRegistered = await this.registrationRepository.isRegistered(raceId, driverId);
+      if (alreadyRegistered) {
+        this.logger.warn(`RegisterForRaceUseCase: driver ${driverId} already registered for race ${raceId}`);
+        return Result.err({
+          code: 'ALREADY_REGISTERED',
+          details: { message: 'Already registered for this race' },
+        });
+      }
+
+      const membership = await this.membershipRepository.getMembership(leagueId, driverId);
+      if (!membership || membership.status !== 'active') {
+        this.logger.error(`RegisterForRaceUseCase: driver ${driverId} not an active member of league ${leagueId}`);
+        return Result.err({
+          code: 'NOT_ACTIVE_MEMBER',
+          details: { message: 'Must be an active league member to register for races' },
+        });
+      }
+
+      const registration = RaceRegistration.create({
+        raceId,
+        driverId,
+      });
+
+      await this.registrationRepository.register(registration);
+      this.logger.info(`RegisterForRaceUseCase: driver ${driverId} successfully registered for race ${raceId}`);
+
+      const result: RegisterForRaceResult = {
+        raceId: registration.raceId.toString(),
+        driverId: registration.driverId.toString(),
+        status: 'registered',
+      };
+
+      this.output.present(result);
+
+      return Result.ok(undefined);
+    } catch (error) {
+      const message =
+        error instanceof Error && error.message
+          ? error.message
+          : 'Failed to register for race';
+
+      this.logger.error('RegisterForRaceUseCase: unexpected error during registration', {
+        raceId,
+        leagueId,
+        driverId,
+        error,
+      });
+
+      return Result.err({
+        code: 'REPOSITORY_ERROR',
+        details: { message },
+      });
     }
-
-    const membership = await this.membershipRepository.getMembership(leagueId, driverId);
-    if (!membership || membership.status !== 'active') {
-      this.logger.error(`RegisterForRaceUseCase: driver ${driverId} not an active member of league ${leagueId}`);
-      return Result.err({ code: 'NOT_ACTIVE_MEMBER', details: { message: 'Must be an active league member to register for races' } });
-    }
-
-    const registration = RaceRegistration.create({
-      raceId,
-      driverId,
-    });
-
-    await this.registrationRepository.register(registration);
-    this.logger.info(`RegisterForRaceUseCase: driver ${driverId} successfully registered for race ${raceId}`);
-
-    return Result.ok(undefined);
   }
 }