refactor racing use cases

core/racing/application/use-cases/GetTeamDetailsUseCase.test.ts

@@ -1,8 +1,16 @@
 import { describe, it, expect, beforeEach, vi, Mock } from 'vitest';
-import { GetTeamDetailsUseCase } from './GetTeamDetailsUseCase';
+import {
+  GetTeamDetailsUseCase,
+  type GetTeamDetailsInput,
+  type GetTeamDetailsResult,
+  type GetTeamDetailsErrorCode,
+} from './GetTeamDetailsUseCase';
 import { ITeamRepository } from '../../domain/repositories/ITeamRepository';
 import { ITeamMembershipRepository } from '../../domain/repositories/ITeamMembershipRepository';
 import { Team } from '../../domain/entities/Team';
+import type { TeamMembership } from '../../domain/types/TeamMembership';
+import type { UseCaseOutputPort } from '@core/shared/application/UseCaseOutputPort';
+import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
 
 describe('GetTeamDetailsUseCase', () => {
   let useCase: GetTeamDetailsUseCase;
@@ -12,6 +20,7 @@ describe('GetTeamDetailsUseCase', () => {
   let membershipRepository: {
     getMembership: Mock;
   };
+  let output: UseCaseOutputPort<GetTeamDetailsResult> & { present: Mock };
 
   beforeEach(() => {
     teamRepository = {
@@ -20,9 +29,13 @@ describe('GetTeamDetailsUseCase', () => {
     membershipRepository = {
       getMembership: vi.fn(),
     };
+    output = {
+      present: vi.fn(),
+    } as unknown as UseCaseOutputPort<GetTeamDetailsResult> & { present: Mock };
     useCase = new GetTeamDetailsUseCase(
       teamRepository as unknown as ITeamRepository,
       membershipRepository as unknown as ITeamMembershipRepository,
+      output,
     );
   });
 
@@ -37,23 +50,28 @@ describe('GetTeamDetailsUseCase', () => {
       ownerId: 'owner-1',
       leagues: [],
     });
-    const membership = {
+    const membership: TeamMembership = {
+      teamId,
       driverId,
-      role: 'member' as const,
-      status: 'active' as const,
+      role: 'driver',
+      status: 'active',
       joinedAt: new Date(),
     };
 
     teamRepository.findById.mockResolvedValue(team);
     membershipRepository.getMembership.mockResolvedValue(membership);
 
-    const result = await useCase.execute({ teamId, driverId });
+    const input: GetTeamDetailsInput = { teamId, driverId };
+
+    const result = await useCase.execute(input);
 
     expect(result.isOk()).toBe(true);
-    const viewModel = result.unwrap();
-    expect(viewModel.team.id).toBe(teamId);
-    expect(viewModel.membership?.role).toBe('member');
-    expect(viewModel.canManage).toBe(false);
+    expect(result.unwrap()).toBeUndefined();
+    expect(output.present).toHaveBeenCalledTimes(1);
+    const presented = output.present.mock.calls[0][0] as GetTeamDetailsResult;
+    expect(presented.team).toBe(team);
+    expect(presented.membership).toEqual(membership);
+    expect(presented.canManage).toBe(false);
   });
 
   it('should return team details for owner', async () => {
@@ -67,21 +85,26 @@ describe('GetTeamDetailsUseCase', () => {
       ownerId: driverId,
       leagues: [],
     });
-    const membership = {
+    const membership: TeamMembership = {
+      teamId,
       driverId,
-      role: 'owner' as const,
-      status: 'active' as const,
+      role: 'owner',
+      status: 'active',
       joinedAt: new Date(),
     };
 
     teamRepository.findById.mockResolvedValue(team);
     membershipRepository.getMembership.mockResolvedValue(membership);
 
-    const result = await useCase.execute({ teamId, driverId });
+    const input: GetTeamDetailsInput = { teamId, driverId };
+
+    const result = await useCase.execute(input);
 
     expect(result.isOk()).toBe(true);
-    const viewModel = result.unwrap();
-    expect(viewModel.canManage).toBe(true);
+    expect(result.unwrap()).toBeUndefined();
+    expect(output.present).toHaveBeenCalledTimes(1);
+    const presented = output.present.mock.calls[0][0] as GetTeamDetailsResult;
+    expect(presented.canManage).toBe(true);
   });
 
   it('should return error for non-existing team', async () => {
@@ -89,13 +112,18 @@ describe('GetTeamDetailsUseCase', () => {
     const driverId = 'driver-1';
     teamRepository.findById.mockResolvedValue(null);
 
-    const result = await useCase.execute({ teamId, driverId });
+    const input: GetTeamDetailsInput = { teamId, driverId };
+
+    const result = await useCase.execute(input);
 
     expect(result.isErr()).toBe(true);
-    expect(result.unwrapErr()).toEqual({
-      code: 'TEAM_NOT_FOUND',
-      message: 'Team not found',
-    });
+    const errorResult = result.unwrapErr() as ApplicationErrorCode<
+      GetTeamDetailsErrorCode,
+      { message: string }
+    >;
+    expect(errorResult.code).toBe('TEAM_NOT_FOUND');
+    expect(errorResult.details?.message).toBe('Team not found');
+    expect(output.present).not.toHaveBeenCalled();
   });
 
   it('should return error on repository failure', async () => {
@@ -103,12 +131,17 @@ describe('GetTeamDetailsUseCase', () => {
     const driverId = 'driver-1';
     teamRepository.findById.mockRejectedValue(new Error('DB error'));
 
-    const result = await useCase.execute({ teamId, driverId });
+    const input: GetTeamDetailsInput = { teamId, driverId };
+
+    const result = await useCase.execute(input);
 
     expect(result.isErr()).toBe(true);
-    expect(result.unwrapErr()).toEqual({
-      code: 'REPOSITORY_ERROR',
-      message: 'Failed to fetch team details',
-    });
+    const errorResult = result.unwrapErr() as ApplicationErrorCode<
+      GetTeamDetailsErrorCode,
+      { message: string }
+    >;
+    expect(errorResult.code).toBe('REPOSITORY_ERROR');
+    expect(errorResult.details?.message).toBe('Failed to load team details');
+    expect(output.present).not.toHaveBeenCalled();
   });
 });