refactor racing use cases

core/racing/application/use-cases/GetLeagueStatsUseCase.test.ts

@@ -1,7 +1,14 @@
-import { describe, it, expect, beforeEach, vi, Mock } from 'vitest';
-import { GetLeagueStatsUseCase } from './GetLeagueStatsUseCase';
+import { describe, it, expect, beforeEach, vi, type Mock } from 'vitest';
+import {
+  GetLeagueStatsUseCase,
+  type GetLeagueStatsInput,
+  type GetLeagueStatsResult,
+  type GetLeagueStatsErrorCode,
+} from './GetLeagueStatsUseCase';
 import { ILeagueMembershipRepository } from '../../domain/repositories/ILeagueMembershipRepository';
 import { IRaceRepository } from '../../domain/repositories/IRaceRepository';
+import type { UseCaseOutputPort } from '@core/shared/application/UseCaseOutputPort';
+import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
 
 describe('GetLeagueStatsUseCase', () => {
   let useCase: GetLeagueStatsUseCase;
@@ -12,6 +19,7 @@ describe('GetLeagueStatsUseCase', () => {
     findByLeagueId: Mock;
   };
   let getDriverRating: Mock;
+  let output: UseCaseOutputPort<GetLeagueStatsResult> & { present: Mock };
 
   beforeEach(() => {
     leagueMembershipRepository = {
@@ -21,15 +29,20 @@ describe('GetLeagueStatsUseCase', () => {
       findByLeagueId: vi.fn(),
     };
     getDriverRating = vi.fn();
+    output = {
+      present: vi.fn(),
+    } as unknown as UseCaseOutputPort<GetLeagueStatsResult> & { present: Mock };
+
     useCase = new GetLeagueStatsUseCase(
       leagueMembershipRepository as unknown as ILeagueMembershipRepository,
       raceRepository as unknown as IRaceRepository,
       getDriverRating,
+      output,
     );
   });
 
   it('should return league stats with average rating', async () => {
-    const leagueId = 'league-1';
+    const input: GetLeagueStatsInput = { leagueId: 'league-1' };
     const memberships = [
       { driverId: 'driver-1' },
       { driverId: 'driver-2' },
@@ -39,25 +52,29 @@ describe('GetLeagueStatsUseCase', () => {
 
     leagueMembershipRepository.getLeagueMembers.mockResolvedValue(memberships);
     raceRepository.findByLeagueId.mockResolvedValue(races);
-    getDriverRating.mockImplementation((input) => {
-      if (input.driverId === 'driver-1') return Promise.resolve({ rating: 1500, ratingChange: null });
-      if (input.driverId === 'driver-2') return Promise.resolve({ rating: 1600, ratingChange: null });
-      if (input.driverId === 'driver-3') return Promise.resolve({ rating: null, ratingChange: null });
+    getDriverRating.mockImplementation((driverInput: { driverId: string }) => {
+      if (driverInput.driverId === 'driver-1') return Promise.resolve({ rating: 1500, ratingChange: null });
+      if (driverInput.driverId === 'driver-2') return Promise.resolve({ rating: 1600, ratingChange: null });
+      if (driverInput.driverId === 'driver-3') return Promise.resolve({ rating: null, ratingChange: null });
       return Promise.resolve({ rating: null, ratingChange: null });
     });
 
-    const result = await useCase.execute({ leagueId });
+    const result = await useCase.execute(input);
 
     expect(result.isOk()).toBe(true);
-    expect(result.unwrap()).toEqual({
-      totalMembers: 3,
-      totalRaces: 2,
-      averageRating: 1550, // (1500 + 1600) / 2
-    });
+    expect(result.unwrap()).toBeUndefined();
+    expect(output.present).toHaveBeenCalledTimes(1);
+
+    const presented = (output.present as Mock).mock.calls[0]?.[0] as GetLeagueStatsResult;
+
+    expect(presented.leagueId).toBe(input.leagueId);
+    expect(presented.driverCount).toBe(3);
+    expect(presented.raceCount).toBe(2);
+    expect(presented.averageRating).toBe(1550); // (1500 + 1600) / 2
   });
 
   it('should return 0 average rating when no valid ratings', async () => {
-    const leagueId = 'league-1';
+    const input: GetLeagueStatsInput = { leagueId: 'league-1' };
     const memberships = [{ driverId: 'driver-1' }];
     const races = [{ id: 'race-1' }];
 
@@ -65,26 +82,50 @@ describe('GetLeagueStatsUseCase', () => {
     raceRepository.findByLeagueId.mockResolvedValue(races);
     getDriverRating.mockResolvedValue({ rating: null, ratingChange: null });
 
-    const result = await useCase.execute({ leagueId });
+    const result = await useCase.execute(input);
 
     expect(result.isOk()).toBe(true);
-    expect(result.unwrap()).toEqual({
-      totalMembers: 1,
-      totalRaces: 1,
-      averageRating: 0,
-    });
+    expect(result.unwrap()).toBeUndefined();
+    expect(output.present).toHaveBeenCalledTimes(1);
+
+    const presented = (output.present as Mock).mock.calls[0]?.[0] as GetLeagueStatsResult;
+
+    expect(presented.leagueId).toBe(input.leagueId);
+    expect(presented.driverCount).toBe(1);
+    expect(presented.raceCount).toBe(1);
+    expect(presented.averageRating).toBe(0);
+  });
+
+  it('should return error when league has no members', async () => {
+    const input: GetLeagueStatsInput = { leagueId: 'league-1' };
+
+    leagueMembershipRepository.getLeagueMembers.mockResolvedValue([]);
+
+    const result = await useCase.execute(input);
+
+    expect(result.isErr()).toBe(true);
+    const error = result.unwrapErr() as ApplicationErrorCode<
+      GetLeagueStatsErrorCode,
+      { message: string }
+    >;
+    expect(error.code).toBe('LEAGUE_NOT_FOUND');
+    expect(error.details.message).toBe('League not found');
+    expect(output.present).not.toHaveBeenCalled();
   });
 
   it('should return error when repository fails', async () => {
-    const leagueId = 'league-1';
+    const input: GetLeagueStatsInput = { leagueId: 'league-1' };
     leagueMembershipRepository.getLeagueMembers.mockRejectedValue(new Error('DB error'));
 
-    const result = await useCase.execute({ leagueId });
+    const result = await useCase.execute(input);
 
     expect(result.isErr()).toBe(true);
-    expect(result.unwrapErr()).toEqual({
-      code: 'REPOSITORY_ERROR',
-      message: 'Failed to fetch league stats',
-    });
+    const error = result.unwrapErr() as ApplicationErrorCode<
+      GetLeagueStatsErrorCode,
+      { message: string }
+    >;
+    expect(error.code).toBe('REPOSITORY_ERROR');
+    expect(error.details.message).toBe('DB error');
+    expect(output.present).not.toHaveBeenCalled();
   });
-});
+});