refactor racing use cases

core/racing/application/use-cases/CompleteDriverOnboardingUseCase.test.ts

@@ -1,8 +1,9 @@
 import { describe, it, expect, beforeEach, vi, Mock } from 'vitest';
-import { CompleteDriverOnboardingUseCase } from './CompleteDriverOnboardingUseCase';
+import { CompleteDriverOnboardingUseCase, type CompleteDriverOnboardingResult } from './CompleteDriverOnboardingUseCase';
 import type { IDriverRepository } from '../../domain/repositories/IDriverRepository';
 import { Driver } from '../../domain/entities/Driver';
-import type { CompleteDriverOnboardingCommand } from '../dto/CompleteDriverOnboardingCommand';
+import type { CompleteDriverOnboardingInput } from './CompleteDriverOnboardingUseCase';
+import type { UseCaseOutputPort } from '@core/shared/application/UseCaseOutputPort';
 
 describe('CompleteDriverOnboardingUseCase', () => {
   let useCase: CompleteDriverOnboardingUseCase;
@@ -10,19 +11,22 @@ describe('CompleteDriverOnboardingUseCase', () => {
     findById: Mock;
     create: Mock;
   };
+  let output: { present: Mock };
 
   beforeEach(() => {
     driverRepository = {
       findById: vi.fn(),
       create: vi.fn(),
     };
+    output = { present: vi.fn() };
     useCase = new CompleteDriverOnboardingUseCase(
       driverRepository as unknown as IDriverRepository,
+      output as unknown as UseCaseOutputPort<CompleteDriverOnboardingResult>,
     );
   });
 
   it('should create driver successfully when driver does not exist', async () => {
-    const command: CompleteDriverOnboardingCommand = {
+    const command: CompleteDriverOnboardingInput = {
       userId: 'user-1',
       firstName: 'John',
       lastName: 'Doe',
@@ -44,7 +48,9 @@ describe('CompleteDriverOnboardingUseCase', () => {
     const result = await useCase.execute(command);
 
     expect(result.isOk()).toBe(true);
-    expect(result.unwrap()).toEqual({ driverId: 'user-1' });
+    expect(result.unwrap()).toBeUndefined();
+    expect(output.present).toHaveBeenCalledTimes(1);
+    expect(output.present).toHaveBeenCalledWith({ driver: createdDriver });
     expect(driverRepository.findById).toHaveBeenCalledWith('user-1');
     expect(driverRepository.create).toHaveBeenCalledWith(
       expect.objectContaining({
@@ -58,7 +64,7 @@ describe('CompleteDriverOnboardingUseCase', () => {
   });
 
   it('should return error when driver already exists', async () => {
-    const command: CompleteDriverOnboardingCommand = {
+    const command: CompleteDriverOnboardingInput = {
       userId: 'user-1',
       firstName: 'John',
       lastName: 'Doe',
@@ -79,10 +85,11 @@ describe('CompleteDriverOnboardingUseCase', () => {
     expect(result.isErr()).toBe(true);
     expect(result.unwrapErr().code).toBe('DRIVER_ALREADY_EXISTS');
     expect(driverRepository.create).not.toHaveBeenCalled();
+    expect(output.present).not.toHaveBeenCalled();
   });
 
   it('should return error when repository create throws', async () => {
-    const command: CompleteDriverOnboardingCommand = {
+    const command: CompleteDriverOnboardingInput = {
       userId: 'user-1',
       firstName: 'John',
       lastName: 'Doe',
@@ -96,11 +103,14 @@ describe('CompleteDriverOnboardingUseCase', () => {
     const result = await useCase.execute(command);
 
     expect(result.isErr()).toBe(true);
-    expect(result.unwrapErr().code).toBe('UNKNOWN_ERROR');
+    const error = result.unwrapErr() as { code: 'REPOSITORY_ERROR'; details?: { message: string } };
+    expect(error.code).toBe('REPOSITORY_ERROR');
+    expect(error.details?.message).toBe('DB error');
+    expect(output.present).not.toHaveBeenCalled();
   });
 
   it('should handle bio being undefined', async () => {
-    const command: CompleteDriverOnboardingCommand = {
+    const command: CompleteDriverOnboardingInput = {
       userId: 'user-1',
       firstName: 'John',
       lastName: 'Doe',
@@ -120,6 +130,7 @@ describe('CompleteDriverOnboardingUseCase', () => {
     const result = await useCase.execute(command);
 
     expect(result.isOk()).toBe(true);
+    expect(result.unwrap()).toBeUndefined();
     expect(driverRepository.create).toHaveBeenCalledWith(
       expect.objectContaining({
         id: 'user-1',
@@ -129,5 +140,7 @@ describe('CompleteDriverOnboardingUseCase', () => {
         bio: undefined,
       })
     );
+    expect(output.present).toHaveBeenCalledTimes(1);
+    expect(output.present).toHaveBeenCalledWith({ driver: createdDriver });
   });
 });