From bf2c0fdb0cac1862ec212590a010e0e32e5bf833 Mon Sep 17 00:00:00 2001 From: Marc Mintel Date: Mon, 26 Jan 2026 01:54:57 +0100 Subject: [PATCH] code quality --- .../queries/GetUserRatingLedgerQuery.test.ts | 2 +- .../use-cases/CloseAdminVoteSessionUseCase.test.ts | 4 ---- .../application/use-cases/GetDriverRankingsUseCase.ts | 1 - .../application/use-cases/GetTeamRankingsUseCase.ts | 1 - .../application/use-cases/JoinLeagueUseCase.test.ts | 3 --- .../application/use-cases/JoinLeagueUseCase.ts | 2 +- .../use-cases/ResolveMediaReferenceUseCase.test.ts | 1 - .../application/ports/NotificationGateway.test.ts | 9 --------- .../NotificationPreferenceRepository.test.ts | 11 ----------- .../media/MediaResolverPort.comprehensive.test.ts | 8 +++----- .../application/use-cases/GetDriverUseCase.test.ts | 1 - .../use-cases/GetTeamsLeaderboardUseCase.test.ts | 1 - .../application/use-cases/RankingUseCase.test.ts | 2 +- .../application/utils/RaceResultGenerator.test.ts | 2 +- .../domain/services/ChampionshipAggregator.test.ts | 1 - .../use-cases/CalculateRatingUseCase.test.ts | 2 -- .../use-cases/GetRatingLeaderboardUseCase.ts | 4 ---- core/shared/domain/DomainEvent.test.ts | 2 +- 18 files changed, 8 insertions(+), 49 deletions(-) diff --git a/core/identity/application/queries/GetUserRatingLedgerQuery.test.ts b/core/identity/application/queries/GetUserRatingLedgerQuery.test.ts index 8bbe43eed..d757f6c1f 100644 --- a/core/identity/application/queries/GetUserRatingLedgerQuery.test.ts +++ b/core/identity/application/queries/GetUserRatingLedgerQuery.test.ts @@ -4,7 +4,7 @@ import { describe, it, expect, vi, beforeEach } from 'vitest'; import { GetUserRatingLedgerQueryHandler } from './GetUserRatingLedgerQuery'; -import { RatingEventRepository, RatingEventFilter } from '../../domain/repositories/RatingEventRepository'; +import { RatingEventRepository } from '../../domain/repositories/RatingEventRepository'; // Mock repository const createMockRepository = () => ({ diff --git a/core/identity/application/use-cases/CloseAdminVoteSessionUseCase.test.ts b/core/identity/application/use-cases/CloseAdminVoteSessionUseCase.test.ts index 2a1fb3e0d..a83e9e428 100644 --- a/core/identity/application/use-cases/CloseAdminVoteSessionUseCase.test.ts +++ b/core/identity/application/use-cases/CloseAdminVoteSessionUseCase.test.ts @@ -6,10 +6,6 @@ import { describe, it, expect, vi, beforeEach } from 'vitest'; import { CloseAdminVoteSessionUseCase } from './CloseAdminVoteSessionUseCase'; -import { AdminVoteSessionRepository } from '../../domain/repositories/AdminVoteSessionRepository'; -import { RatingEventRepository } from '../../domain/repositories/RatingEventRepository'; -import { UserRatingRepository } from '../../domain/repositories/UserRatingRepository'; -import { AdminVoteSession } from '../../domain/entities/AdminVoteSession'; import { RatingEventFactory } from '../../domain/services/RatingEventFactory'; import { RatingSnapshotCalculator } from '../../domain/services/RatingSnapshotCalculator'; diff --git a/core/leaderboards/application/use-cases/GetDriverRankingsUseCase.ts b/core/leaderboards/application/use-cases/GetDriverRankingsUseCase.ts index 4291525d0..d77c004ba 100644 --- a/core/leaderboards/application/use-cases/GetDriverRankingsUseCase.ts +++ b/core/leaderboards/application/use-cases/GetDriverRankingsUseCase.ts @@ -11,7 +11,6 @@ import { DriverRankingsQuery, DriverRankingsResult, DriverRankingEntry, - PaginationMetadata, } from '../ports/DriverRankingsQuery'; import { ValidationError } from '../../../shared/errors/ValidationError'; diff --git a/core/leaderboards/application/use-cases/GetTeamRankingsUseCase.ts b/core/leaderboards/application/use-cases/GetTeamRankingsUseCase.ts index 3e66368b7..2dc621ec7 100644 --- a/core/leaderboards/application/use-cases/GetTeamRankingsUseCase.ts +++ b/core/leaderboards/application/use-cases/GetTeamRankingsUseCase.ts @@ -11,7 +11,6 @@ import { TeamRankingsQuery, TeamRankingsResult, TeamRankingEntry, - PaginationMetadata, } from '../ports/TeamRankingsQuery'; import { ValidationError } from '../../../shared/errors/ValidationError'; diff --git a/core/leagues/application/use-cases/JoinLeagueUseCase.test.ts b/core/leagues/application/use-cases/JoinLeagueUseCase.test.ts index d70ca83e1..c312356b5 100644 --- a/core/leagues/application/use-cases/JoinLeagueUseCase.test.ts +++ b/core/leagues/application/use-cases/JoinLeagueUseCase.test.ts @@ -1,8 +1,5 @@ import { describe, it, expect, vi, beforeEach } from 'vitest'; import { JoinLeagueUseCase } from './JoinLeagueUseCase'; -import type { LeagueRepository } from '../ports/LeagueRepository'; -import type { DriverRepository } from '../../../racing/domain/repositories/DriverRepository'; -import type { EventPublisher } from '../../../shared/ports/EventPublisher'; import type { JoinLeagueCommand } from '../ports/JoinLeagueCommand'; const mockLeagueRepository = { diff --git a/core/leagues/application/use-cases/JoinLeagueUseCase.ts b/core/leagues/application/use-cases/JoinLeagueUseCase.ts index 6ee028bb3..14d9c7849 100644 --- a/core/leagues/application/use-cases/JoinLeagueUseCase.ts +++ b/core/leagues/application/use-cases/JoinLeagueUseCase.ts @@ -1,4 +1,4 @@ -import { LeagueRepository, LeagueData } from '../ports/LeagueRepository'; +import { LeagueRepository } from '../ports/LeagueRepository'; import { DriverRepository } from '../../../racing/domain/repositories/DriverRepository'; import { EventPublisher } from '../../../shared/ports/EventPublisher'; import { JoinLeagueCommand } from '../ports/JoinLeagueCommand'; diff --git a/core/media/application/use-cases/ResolveMediaReferenceUseCase.test.ts b/core/media/application/use-cases/ResolveMediaReferenceUseCase.test.ts index d28eac283..110f27681 100644 --- a/core/media/application/use-cases/ResolveMediaReferenceUseCase.test.ts +++ b/core/media/application/use-cases/ResolveMediaReferenceUseCase.test.ts @@ -1,4 +1,3 @@ -import { Result } from '@core/shared/domain/Result'; import { describe, expect, it, vi, type Mock } from 'vitest'; import type { MediaResolverPort } from '@core/ports/media/MediaResolverPort'; import { ResolveMediaReferenceUseCase } from './ResolveMediaReferenceUseCase'; diff --git a/core/notifications/application/ports/NotificationGateway.test.ts b/core/notifications/application/ports/NotificationGateway.test.ts index e29ce7af6..6909e0a2e 100644 --- a/core/notifications/application/ports/NotificationGateway.test.ts +++ b/core/notifications/application/ports/NotificationGateway.test.ts @@ -19,15 +19,6 @@ describe('NotificationGateway - Interface Contract', () => { getChannel: vi.fn().mockReturnValue('in_app'), }; - const notification = Notification.create({ - id: 'test-id', - recipientId: 'driver-1', - type: 'system_announcement', - title: 'Test', - body: 'Test body', - channel: 'in_app', - }); - expect(mockGateway.send).toBeDefined(); expect(typeof mockGateway.send).toBe('function'); }); diff --git a/core/notifications/domain/repositories/NotificationPreferenceRepository.test.ts b/core/notifications/domain/repositories/NotificationPreferenceRepository.test.ts index f4be10577..b5411b006 100644 --- a/core/notifications/domain/repositories/NotificationPreferenceRepository.test.ts +++ b/core/notifications/domain/repositories/NotificationPreferenceRepository.test.ts @@ -201,17 +201,6 @@ describe('NotificationPreferenceRepository - Integration', () => { it('handles workflow: get or create, then update', async () => { const defaultPreference = NotificationPreference.createDefault('driver-1'); - const updatedPreference = NotificationPreference.create({ - id: 'driver-1', - driverId: 'driver-1', - channels: { - in_app: { enabled: true }, - email: { enabled: true }, - discord: { enabled: false }, - push: { enabled: false }, - }, - }); - const mockRepository: NotificationPreferenceRepository = { findByDriverId: vi.fn().mockResolvedValue(null), save: vi.fn().mockResolvedValue(undefined), diff --git a/core/ports/media/MediaResolverPort.comprehensive.test.ts b/core/ports/media/MediaResolverPort.comprehensive.test.ts index 290313201..42182b4b9 100644 --- a/core/ports/media/MediaResolverPort.comprehensive.test.ts +++ b/core/ports/media/MediaResolverPort.comprehensive.test.ts @@ -24,7 +24,7 @@ describe('MediaResolverPort - Comprehensive Tests', () => { it('should define resolve method signature correctly', () => { // Verify the interface has the correct method signature const testInterface: MediaResolverPort = { - resolve: async (ref: MediaReference): Promise => { + resolve: async (): Promise => { return null; }, }; @@ -124,7 +124,6 @@ describe('MediaResolverPort - Comprehensive Tests', () => { it('should return null for generated reference without generationRequestId', () => { // Create a reference with missing generationRequestId - const ref = MediaReference.createGenerated('valid-id'); // Manually create an invalid reference const invalidRef = { type: 'generated' } as MediaReference; const result = ResolutionStrategies.generated(invalidRef); @@ -164,7 +163,6 @@ describe('MediaResolverPort - Comprehensive Tests', () => { it('should return null for uploaded reference without mediaId', () => { // Create a reference with missing mediaId - const ref = MediaReference.createUploaded('valid-id'); // Manually create an invalid reference const invalidRef = { type: 'uploaded' } as MediaReference; const result = ResolutionStrategies.uploaded(invalidRef); @@ -284,7 +282,7 @@ describe('MediaResolverPort - Comprehensive Tests', () => { describe('isMediaResolverPort Type Guard', () => { it('should return true for valid MediaResolverPort implementation', () => { const validResolver: MediaResolverPort = { - resolve: async (ref: MediaReference): Promise => { + resolve: async (): Promise => { return '/test/path'; }, }; @@ -332,7 +330,7 @@ describe('MediaResolverPort - Comprehensive Tests', () => { it('should return true for object with resolve method and other properties', () => { const validResolver = { - resolve: async (ref: MediaReference): Promise => { + resolve: async (): Promise => { return '/test/path'; }, extraProperty: 'value', diff --git a/core/racing/application/use-cases/GetDriverUseCase.test.ts b/core/racing/application/use-cases/GetDriverUseCase.test.ts index 3181cb92b..fead88b82 100644 --- a/core/racing/application/use-cases/GetDriverUseCase.test.ts +++ b/core/racing/application/use-cases/GetDriverUseCase.test.ts @@ -1,6 +1,5 @@ import { describe, it, expect, vi } from 'vitest'; import { GetDriverUseCase } from './GetDriverUseCase'; -import { Result } from '@core/shared/domain/Result'; import type { DriverRepository } from '../../domain/repositories/DriverRepository'; import type { Driver } from '../../domain/entities/Driver'; diff --git a/core/racing/application/use-cases/GetTeamsLeaderboardUseCase.test.ts b/core/racing/application/use-cases/GetTeamsLeaderboardUseCase.test.ts index 9e202b9eb..8c71092fc 100644 --- a/core/racing/application/use-cases/GetTeamsLeaderboardUseCase.test.ts +++ b/core/racing/application/use-cases/GetTeamsLeaderboardUseCase.test.ts @@ -1,6 +1,5 @@ import { describe, it, expect, vi } from 'vitest'; import { GetTeamsLeaderboardUseCase } from './GetTeamsLeaderboardUseCase'; -import { Result } from '@core/shared/domain/Result'; import type { TeamRepository } from '../../domain/repositories/TeamRepository'; import type { TeamMembershipRepository } from '../../domain/repositories/TeamMembershipRepository'; import type { Logger } from '@core/shared/domain/Logger'; diff --git a/core/racing/application/use-cases/RankingUseCase.test.ts b/core/racing/application/use-cases/RankingUseCase.test.ts index ab449c29e..0d9da0f30 100644 --- a/core/racing/application/use-cases/RankingUseCase.test.ts +++ b/core/racing/application/use-cases/RankingUseCase.test.ts @@ -1,5 +1,5 @@ import { describe, it, expect, vi } from 'vitest'; -import { RankingUseCase, type DriverRanking } from './RankingUseCase'; +import { RankingUseCase } from './RankingUseCase'; import type { StandingRepository } from '../../domain/repositories/StandingRepository'; import type { DriverRepository } from '../../domain/repositories/DriverRepository'; import type { DriverStatsRepository } from '../../domain/repositories/DriverStatsRepository'; diff --git a/core/racing/application/utils/RaceResultGenerator.test.ts b/core/racing/application/utils/RaceResultGenerator.test.ts index 7084ff131..26334f927 100644 --- a/core/racing/application/utils/RaceResultGenerator.test.ts +++ b/core/racing/application/utils/RaceResultGenerator.test.ts @@ -1,4 +1,4 @@ -import { describe, it, expect, vi } from 'vitest'; +import { describe, it, expect } from 'vitest'; import { RaceResultGenerator } from './RaceResultGenerator'; describe('RaceResultGenerator', () => { diff --git a/core/racing/domain/services/ChampionshipAggregator.test.ts b/core/racing/domain/services/ChampionshipAggregator.test.ts index cf500779e..213dcfa24 100644 --- a/core/racing/domain/services/ChampionshipAggregator.test.ts +++ b/core/racing/domain/services/ChampionshipAggregator.test.ts @@ -1,7 +1,6 @@ import { describe, it, expect, vi } from 'vitest'; import { ChampionshipAggregator } from './ChampionshipAggregator'; import type { DropScoreApplier } from './DropScoreApplier'; -import { Points } from '../value-objects/Points'; describe('ChampionshipAggregator', () => { const mockDropScoreApplier = { diff --git a/core/rating/application/use-cases/CalculateRatingUseCase.test.ts b/core/rating/application/use-cases/CalculateRatingUseCase.test.ts index 80ee0110c..d576cd270 100644 --- a/core/rating/application/use-cases/CalculateRatingUseCase.test.ts +++ b/core/rating/application/use-cases/CalculateRatingUseCase.test.ts @@ -9,8 +9,6 @@ import { CalculateRatingUseCase } from './CalculateRatingUseCase'; import { Driver } from '../../../racing/domain/entities/Driver'; import { Race } from '../../../racing/domain/entities/Race'; import { Result } from '../../../racing/domain/entities/result/Result'; -import { Rating } from '../../domain/Rating'; -import { RatingCalculatedEvent } from '../../domain/events/RatingCalculatedEvent'; // Mock repositories and publisher const mockDriverRepository = { diff --git a/core/rating/application/use-cases/GetRatingLeaderboardUseCase.ts b/core/rating/application/use-cases/GetRatingLeaderboardUseCase.ts index 8c96fc0bd..5e20bba5b 100644 --- a/core/rating/application/use-cases/GetRatingLeaderboardUseCase.ts +++ b/core/rating/application/use-cases/GetRatingLeaderboardUseCase.ts @@ -40,10 +40,6 @@ export class GetRatingLeaderboardUseCase { const { limit = 50, offset = 0 } = request; try { - // Get all ratings - const allRatings: Rating[] = []; - const driverIds = new Set(); - // Group ratings by driver and get latest rating for each driver const driverRatings = new Map(); diff --git a/core/shared/domain/DomainEvent.test.ts b/core/shared/domain/DomainEvent.test.ts index bb0f5869b..6953a2ee6 100644 --- a/core/shared/domain/DomainEvent.test.ts +++ b/core/shared/domain/DomainEvent.test.ts @@ -95,7 +95,7 @@ describe('DomainEvent', () => { describe('DomainEventPublisher interface', () => { it('should have publish method', async () => { const mockPublisher: DomainEventPublisher = { - publish: async (event: DomainEvent) => { + publish: async () => { // Mock implementation return Promise.resolve(); }