view data fixes

apps/website/lib/builders/view-data/LeagueRosterAdminViewDataBuilder.ts

@@ -2,26 +2,16 @@ import type { LeagueRosterMemberDTO } from '@/lib/types/generated/LeagueRosterMe
 import type { LeagueRosterJoinRequestDTO } from '@/lib/types/generated/LeagueRosterJoinRequestDTO';
 import type { LeagueRosterAdminViewData, RosterMemberData, JoinRequestData } from '@/lib/view-data/LeagueRosterAdminViewData';
 import { DateDisplay } from '@/lib/display-objects/DateDisplay';
+import type { ViewDataBuilder } from '@/lib/contracts/builders/ViewDataBuilder';
 
-/**
- * LeagueRosterAdminViewDataBuilder
- *
- * Transforms API DTOs into LeagueRosterAdminViewData for server-side rendering.
- * Deterministic; side-effect free; no HTTP calls.
- */
-import { ViewDataBuilder } from "../../contracts/builders/ViewDataBuilder";
+type LeagueRosterAdminInputDTO = {
+  leagueId: string;
+  members: LeagueRosterMemberDTO[];
+  joinRequests: LeagueRosterJoinRequestDTO[];
+}
 
-export class LeagueRosterAdminViewDataBuilder implements ViewDataBuilder<any, any> {
-  build(input: any): any {
-    return LeagueRosterAdminViewDataBuilder.build(input);
-  }
-
-  static build(
-  static build(input: {
-    leagueId: string;
-    members: LeagueRosterMemberDTO[];
-    joinRequests: LeagueRosterJoinRequestDTO[];
-  }): LeagueRosterAdminViewData {
+export class LeagueRosterAdminViewDataBuilder {
+  public static build(input: LeagueRosterAdminInputDTO): LeagueRosterAdminViewData {
     const { leagueId, members, joinRequests } = input;
     
     // Transform members
@@ -29,7 +19,7 @@ export class LeagueRosterAdminViewDataBuilder implements ViewDataBuilder<any, an
       driverId: member.driverId,
       driver: {
         id: member.driverId,
-        name: member.driver?.name || 'Unknown Driver',
+        name: (member.driver as { name?: string })?.name || 'Unknown Driver',
       },
       role: member.role,
       joinedAt: member.joinedAt,
@@ -41,11 +31,11 @@ export class LeagueRosterAdminViewDataBuilder implements ViewDataBuilder<any, an
       id: req.id,
       driver: {
         id: req.driverId,
-        name: 'Unknown Driver', // driver field is unknown type
+        name: (req as { driver?: { name?: string } }).driver?.name || 'Unknown Driver',
       },
       requestedAt: req.requestedAt,
       formattedRequestedAt: DateDisplay.formatShort(req.requestedAt),
-      message: req.message,
+      message: req.message ?? undefined,
     }));
     
     return {
@@ -54,4 +44,6 @@ export class LeagueRosterAdminViewDataBuilder implements ViewDataBuilder<any, an
       joinRequests: requests,
     };
   }
-}
+}
+
+LeagueRosterAdminViewDataBuilder satisfies ViewDataBuilder<LeagueRosterAdminInputDTO, LeagueRosterAdminViewData>;