website refactor

apps/website/lib/services/teams/TeamService.ts

@@ -1,11 +1,12 @@
 import { TeamsApiClient } from '@/lib/api/teams/TeamsApiClient';
-import { TeamSummaryViewModel } from '@/lib/view-models/TeamSummaryViewModel';
+import type { TeamListItemDTO } from '@/lib/types/generated/TeamListItemDTO';
 import { TeamMemberViewModel } from '@/lib/view-models/TeamMemberViewModel';
 import { Result } from '@/lib/contracts/Result';
 import { DomainError, Service } from '@/lib/contracts/services/Service';
 import { ConsoleLogger } from '@/lib/infrastructure/logging/ConsoleLogger';
 import { EnhancedErrorReporter } from '@/lib/infrastructure/EnhancedErrorReporter';
 import { getWebsiteApiBaseUrl } from '@/lib/config/apiBaseUrl';
+import { isProductionEnvironment } from '@/lib/config/env';
 
 /**
  * Team Service - DTO Only
@@ -22,7 +23,7 @@ export class TeamService implements Service {
     const errorReporter = new EnhancedErrorReporter(logger, {
       showUserNotifications: true,
       logToConsole: true,
-      reportToExternal: process.env.NODE_ENV === 'production',
+      reportToExternal: isProductionEnvironment(),
     });
     this.apiClient = new TeamsApiClient(baseUrl, errorReporter, logger);
   }
@@ -31,20 +32,20 @@ export class TeamService implements Service {
     try {
       const result = await this.apiClient.getAll();
       return Result.ok(result.teams);
-    } catch (error) {
-      return Result.err({ type: 'unknown', message: 'Failed to fetch teams' });
+    } catch (error: unknown) {
+      return Result.err({ type: 'unknown', message: (error as Error).message || 'Failed to fetch teams' });
     }
   }
 
-  async getTeamDetails(_teamId: string, _currentDriverId: string): Promise<Result<any, DomainError>> {
+  async getTeamDetails(teamId: string, _: string): Promise<Result<unknown, DomainError>> {
     try {
-      const result = await this.apiClient.getDetails(_teamId);
+      const result = await this.apiClient.getDetails(teamId);
       if (!result) {
         return Result.err({ type: 'notFound', message: 'Team not found' });
       }
       return Result.ok(result);
-    } catch (error) {
-      return Result.err({ type: 'unknown', message: 'Failed to fetch team details' });
+    } catch (error: unknown) {
+      return Result.err({ type: 'unknown', message: (error as Error).message || 'Failed to fetch team details' });
     }
   }
 
@@ -52,28 +53,28 @@ export class TeamService implements Service {
     try {
       const result = await this.apiClient.getMembers(teamId);
       return Result.ok(result.members.map(member => new TeamMemberViewModel(member, currentDriverId, ownerId)));
-    } catch (error) {
-      return Result.err({ type: 'unknown', message: 'Failed to fetch team members' });
+    } catch (error: unknown) {
+      return Result.err({ type: 'unknown', message: (error as Error).message || 'Failed to fetch team members' });
     }
   }
 
-  async getTeamJoinRequests(_teamId: string): Promise<Result<any, DomainError>> {
+  async getTeamJoinRequests(_: string): Promise<Result<unknown, DomainError>> {
     return Result.err({ type: 'notImplemented', message: 'getTeamJoinRequests' });
   }
 
-  async createTeam(_input: any): Promise<Result<any, DomainError>> {
+  async createTeam(__: unknown): Promise<Result<unknown, DomainError>> {
     return Result.err({ type: 'notImplemented', message: 'createTeam' });
   }
 
-  async updateTeam(_teamId: string, _input: any): Promise<Result<any, DomainError>> {
+  async updateTeam(_: string, __: unknown): Promise<Result<unknown, DomainError>> {
     return Result.err({ type: 'notImplemented', message: 'updateTeam' });
   }
 
-  async getDriverTeam(_driverId: string): Promise<Result<any, DomainError>> {
+  async getDriverTeam(_: string): Promise<Result<unknown, DomainError>> {
     return Result.err({ type: 'notImplemented', message: 'getDriverTeam' });
   }
 
-  async getMembership(_teamId: string, _driverId: string): Promise<Result<any, DomainError>> {
+  async getMembership(_: string, __: string): Promise<Result<unknown, DomainError>> {
     return Result.err({ type: 'notImplemented', message: 'getMembership' });
   }
-}
+}