code quality

apps/website/lib/services/auth/AuthService.ts

@@ -5,6 +5,7 @@ import { DomainError, Service } from '@/lib/contracts/services/Service';
 import { AuthApiClient } from '@/lib/gateways/api/auth/AuthApiClient';
 import { EnhancedErrorReporter } from '@/lib/infrastructure/EnhancedErrorReporter';
 import { ConsoleLogger } from '@/lib/infrastructure/logging/ConsoleLogger';
+import type { ForgotPasswordDTO } from '@/lib/types/generated/ForgotPasswordDTO';
 import type { LoginParamsDTO } from '@/lib/types/generated/LoginParamsDTO';
 import type { ResetPasswordDTO } from '@/lib/types/generated/ResetPasswordDTO';
 import type { SignupParamsDTO } from '@/lib/types/generated/SignupParamsDTO';

apps/website/lib/services/drivers/DriverService.ts

@@ -3,10 +3,12 @@ import { Result } from '@/lib/contracts/Result';
 import { DomainError, Service } from '@/lib/contracts/services/Service';
 import { DriversApiClient } from '@/lib/gateways/api/drivers/DriversApiClient';
 import { ConsoleLogger } from '@/lib/infrastructure/logging/ConsoleLogger';
-import type { CompleteOnboardingInputDTO } from '@/lib/types/generated/CompleteOnboardingInputDTO';
-import type { DriverDTO } from '@/lib/types/generated/DriverDTO';
-import type { GetDriverOutputDTO } from '@/lib/types/generated/GetDriverOutputDTO';
-import type { GetDriverProfileOutputDTO } from '@/lib/types/generated/GetDriverProfileOutputDTO';
+import type {
+  CompleteOnboardingInputDTO,
+  DriverDTO,
+  GetDriverOutputDTO,
+  GetDriverProfileOutputDTO
+} from '@/lib/types/generated';
 import { CompleteOnboardingViewModel } from '@/lib/view-models/CompleteOnboardingViewModel';
 import { DriverLeaderboardViewModel } from '@/lib/view-models/DriverLeaderboardViewModel';
 import { DriverViewModel } from '@/lib/view-models/DriverViewModel';
@@ -28,7 +30,11 @@ export class DriverService implements Service {
     } else {
       const baseUrl = getWebsiteApiBaseUrl();
       const logger = new ConsoleLogger();
-      const errorReporter = new EnhancedErrorReporter(logger);
+      const errorReporter = new EnhancedErrorReporter(logger, {
+        showUserNotifications: false,
+        logToConsole: true,
+        reportToExternal: false,
+      });
       this.apiClient = new DriversApiClient(baseUrl, errorReporter, logger);
     }
   }

apps/website/lib/services/onboarding/OnboardingService.ts

@@ -14,11 +14,13 @@ import { DomainError, Service } from '@/lib/contracts/services/Service';
 import { DriversApiClient } from '@/lib/gateways/api/drivers/DriversApiClient';
 import { EnhancedErrorReporter } from '@/lib/infrastructure/EnhancedErrorReporter';
 import { ConsoleLogger } from '@/lib/infrastructure/logging/ConsoleLogger';
-import { CompleteOnboardingInputDTO } from '@/lib/types/generated/CompleteOnboardingInputDTO';
-import { CompleteOnboardingOutputDTO } from '@/lib/types/generated/CompleteOnboardingOutputDTO';
-import { GetDriverOutputDTO } from '@/lib/types/generated/GetDriverOutputDTO';
-import { RequestAvatarGenerationInputDTO } from '@/lib/types/generated/RequestAvatarGenerationInputDTO';
-import { RequestAvatarGenerationOutputDTO } from '@/lib/types/generated/RequestAvatarGenerationOutputDTO';
+import {
+  CompleteOnboardingInputDTO,
+  CompleteOnboardingOutputDTO,
+  GetDriverOutputDTO,
+  RequestAvatarGenerationInputDTO,
+  RequestAvatarGenerationOutputDTO
+} from '@/lib/types/generated';
 
 export class OnboardingService implements Service {
   private apiClient: DriversApiClient;

apps/website/lib/services/protests/ProtestService.ts

@@ -3,6 +3,7 @@ import { Service } from '@/lib/contracts/services/Service';
 import { ProtestsApiClient } from '@/lib/gateways/api/protests/ProtestsApiClient';
 import { EnhancedErrorReporter } from '@/lib/infrastructure/EnhancedErrorReporter';
 import { ConsoleLogger } from '@/lib/infrastructure/logging/ConsoleLogger';
+import type { ApplyPenaltyCommandDTO } from '@/lib/types/generated/ApplyPenaltyCommandDTO';
 import type { RequestProtestDefenseCommandDTO } from '@/lib/types/generated/RequestProtestDefenseCommandDTO';
 import type { ReviewProtestCommandDTO } from '@/lib/types/generated/ReviewProtestCommandDTO';
 import { ProtestDriverViewModel } from '@/lib/view-models/ProtestDriverViewModel';

apps/website/lib/services/teams/TeamService.ts

@@ -5,12 +5,15 @@ import { DomainError, Service } from '@/lib/contracts/services/Service';
 import { TeamsApiClient } from '@/lib/gateways/api/teams/TeamsApiClient';
 import { EnhancedErrorReporter } from '@/lib/infrastructure/EnhancedErrorReporter';
 import { ConsoleLogger } from '@/lib/infrastructure/logging/ConsoleLogger';
-import type { CreateTeamOutputDTO } from '@/lib/types/generated/CreateTeamOutputDTO';
-import type { GetTeamDetailsOutputDTO } from '@/lib/types/generated/GetTeamDetailsOutputDTO';
-import type { GetTeamMembershipOutputDTO } from '@/lib/types/generated/GetTeamMembershipOutputDTO';
-import type { TeamListItemDTO } from '@/lib/types/generated/TeamListItemDTO';
-import type { UpdateTeamInputDTO } from '@/lib/types/generated/UpdateTeamInputDTO';
-import type { UpdateTeamOutputDTO } from '@/lib/types/generated/UpdateTeamOutputDTO';
+import type {
+  CreateTeamInputDTO,
+  CreateTeamOutputDTO,
+  GetTeamDetailsOutputDTO,
+  GetTeamMembershipOutputDTO,
+  TeamListItemDTO,
+  UpdateTeamInputDTO,
+  UpdateTeamOutputDTO
+} from '@/lib/types/generated';
 import { TeamMemberViewModel } from '@/lib/view-models/TeamMemberViewModel';
 import { injectable, unmanaged } from 'inversify';
 
@@ -82,7 +85,11 @@ export class TeamService implements Service {
     try {
       const result = await this.apiClient.getMembers(teamId);
       const members = (result as any).members || result;
-      const viewModels = members.map((member: any) => new TeamMemberViewModel(member, currentDriverId, ownerId));
+      const viewModels = members.map((member: any) => new TeamMemberViewModel({
+        ...member,
+        currentUserId: currentDriverId,
+        teamOwnerId: ownerId
+      }));
       return Result.ok(viewModels);
     } catch (error: unknown) {
       return Result.err({ type: 'unknown', message: (error as Error).message || 'Failed to fetch team members' });