refactor core presenters
This commit is contained in:
@@ -2,7 +2,7 @@ import type { ITeamMembershipRepository } from '../../domain/repositories/ITeamM
|
||||
import type { IDriverRepository } from '../../domain/repositories/IDriverRepository';
|
||||
import type { GetDriverAvatarInputPort } from '../ports/input/GetDriverAvatarInputPort';
|
||||
import type { GetDriverAvatarOutputPort } from '../ports/output/GetDriverAvatarOutputPort';
|
||||
import type { TeamMembersResultDTO } from '../presenters/ITeamMembersPresenter';
|
||||
import type { TeamMembersOutputPort } from '../ports/output/TeamMembersOutputPort';
|
||||
import { Result } from '@core/shared/application/Result';
|
||||
import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
|
||||
import type { AsyncUseCase } from '@core/shared/application';
|
||||
@@ -11,7 +11,7 @@ import type { Logger } from '@core/shared/application';
|
||||
/**
|
||||
* Use Case for retrieving team members.
|
||||
*/
|
||||
export class GetTeamMembersUseCase implements AsyncUseCase<{ teamId: string }, TeamMembersResultDTO, 'REPOSITORY_ERROR'>
|
||||
export class GetTeamMembersUseCase implements AsyncUseCase<{ teamId: string }, TeamMembersOutputPort, 'REPOSITORY_ERROR'>
|
||||
{
|
||||
constructor(
|
||||
private readonly membershipRepository: ITeamMembershipRepository,
|
||||
@@ -20,7 +20,7 @@ export class GetTeamMembersUseCase implements AsyncUseCase<{ teamId: string }, T
|
||||
private readonly logger: Logger,
|
||||
) {}
|
||||
|
||||
async execute(input: { teamId: string }): Promise<Result<TeamMembersResultDTO, ApplicationErrorCode<'REPOSITORY_ERROR'>>> {
|
||||
async execute(input: { teamId: string }): Promise<Result<TeamMembersOutputPort, ApplicationErrorCode<'REPOSITORY_ERROR'>>> {
|
||||
this.logger.debug(`Executing GetTeamMembersUseCase for teamId: ${input.teamId}`);
|
||||
|
||||
try {
|
||||
@@ -34,7 +34,7 @@ export class GetTeamMembersUseCase implements AsyncUseCase<{ teamId: string }, T
|
||||
this.logger.debug(`Processing membership for driverId: ${membership.driverId}`);
|
||||
const driver = await this.driverRepository.findById(membership.driverId);
|
||||
if (driver) {
|
||||
driverNames[membership.driverId] = driver.name;
|
||||
driverNames[membership.driverId] = driver.name.value;
|
||||
} else {
|
||||
this.logger.warn(`Driver with ID ${membership.driverId} not found while fetching team members for team ${input.teamId}.`);
|
||||
}
|
||||
@@ -43,13 +43,24 @@ export class GetTeamMembersUseCase implements AsyncUseCase<{ teamId: string }, T
|
||||
avatarUrls[membership.driverId] = avatarResult.avatarUrl;
|
||||
}
|
||||
|
||||
const dto: TeamMembersResultDTO = {
|
||||
memberships,
|
||||
driverNames,
|
||||
avatarUrls,
|
||||
const members = memberships.map(membership => ({
|
||||
driverId: membership.driverId,
|
||||
driverName: driverNames[membership.driverId] || 'Unknown',
|
||||
role: membership.role as 'owner' | 'manager' | 'member',
|
||||
joinedAt: membership.joinedAt instanceof Date ? membership.joinedAt : new Date(membership.joinedAt),
|
||||
isActive: membership.status === 'active',
|
||||
avatarUrl: avatarUrls[membership.driverId] || '',
|
||||
}));
|
||||
|
||||
const outputPort: TeamMembersOutputPort = {
|
||||
members,
|
||||
totalCount: memberships.length,
|
||||
ownerCount: memberships.filter(m => m.role === 'owner').length,
|
||||
managerCount: memberships.filter(m => m.role === 'manager').length,
|
||||
memberCount: memberships.filter(m => m.role === 'member').length,
|
||||
};
|
||||
|
||||
return Result.ok(dto);
|
||||
return Result.ok(outputPort);
|
||||
} catch (error) {
|
||||
this.logger.error(`Error in GetTeamMembersUseCase for teamId: ${input.teamId}`, error as Error, { teamId: input.teamId });
|
||||
return Result.err({ code: 'REPOSITORY_ERROR', details: { message: 'Failed to retrieve team members' } });
|
||||
|
||||
Reference in New Issue
Block a user