refactor use cases

core/notifications/application/use-cases/SendNotificationUseCase.ts

@@ -5,7 +5,9 @@
  * based on their preferences.
  */
 
-import type { AsyncUseCase, Logger } from '@core/shared/application';
+import type { Logger, UseCaseOutputPort } from '@core/shared/application';
+import { Result } from '@core/shared/application/Result';
+import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
 import { v4 as uuid } from 'uuid';
 import type { NotificationData } from '../../domain/entities/Notification';
 import { Notification } from '../../domain/entities/Notification';
@@ -43,17 +45,22 @@ export interface SendNotificationResult {
   deliveryResults: NotificationDeliveryResult[];
 }
 
-export class SendNotificationUseCase implements AsyncUseCase<SendNotificationCommand, SendNotificationResult> {
+export type SendNotificationErrorCode = 'REPOSITORY_ERROR';
+
+export class SendNotificationUseCase {
   constructor(
     private readonly notificationRepository: INotificationRepository,
     private readonly preferenceRepository: INotificationPreferenceRepository,
     private readonly gatewayRegistry: NotificationGatewayRegistry,
+    private readonly output: UseCaseOutputPort<SendNotificationResult>,
     private readonly logger: Logger,
   ) {
     this.logger.debug('SendNotificationUseCase initialized.');
   }
 
-  async execute(command: SendNotificationCommand): Promise<SendNotificationResult> {
+  async execute(
+    command: SendNotificationCommand,
+  ): Promise<Result<void, ApplicationErrorCode<SendNotificationErrorCode, { message: string }>>> {
     this.logger.debug('Executing SendNotificationUseCase', { command });
     try {
       // Get recipient's preferences
@@ -84,7 +91,8 @@ export class SendNotificationUseCase implements AsyncUseCase<SendNotificationCom
       }
   
       // Determine which channels to use
-      const channels = command.forceChannels ?? preferences.getEnabledChannelsForType(command.type);
+      const channels =
+        command.forceChannels ?? preferences.getEnabledChannelsForType(command.type);
   
       // Check quiet hours (skip external channels during quiet hours)
       const effectiveChannels = preferences.isInQuietHours()
@@ -133,13 +141,19 @@ export class SendNotificationUseCase implements AsyncUseCase<SendNotificationCom
         }
       }
   
-      return {
+      this.output.present({
         notification: primaryNotification!,
         deliveryResults,
-      };
+      });
+
+      return Result.ok(undefined);
     } catch (error) {
-      this.logger.error('Error sending notification', error as Error);
-      throw error;
+      const err = error instanceof Error ? error : new Error(String(error));
+      this.logger.error('Error sending notification', err);
+      return Result.err({
+        code: 'REPOSITORY_ERROR',
+        details: { message: err.message },
+      });
     }
   }
 }