refactor use cases
This commit is contained in:
@@ -5,10 +5,22 @@ import {
|
||||
UpdateTypePreferenceUseCase,
|
||||
UpdateQuietHoursUseCase,
|
||||
SetDigestModeUseCase,
|
||||
type GetNotificationPreferencesInput,
|
||||
type GetNotificationPreferencesResult,
|
||||
type UpdateChannelPreferenceCommand,
|
||||
type UpdateChannelPreferenceResult,
|
||||
type UpdateTypePreferenceCommand,
|
||||
type UpdateTypePreferenceResult,
|
||||
type UpdateQuietHoursCommand,
|
||||
type UpdateQuietHoursResult,
|
||||
type SetDigestModeCommand,
|
||||
type SetDigestModeResult,
|
||||
} from './NotificationPreferencesUseCases';
|
||||
import type { INotificationPreferenceRepository } from '../../domain/repositories/INotificationPreferenceRepository';
|
||||
import type { NotificationPreference , ChannelPreference, TypePreference } from '../../domain/entities/NotificationPreference';
|
||||
import type { Logger } from '@core/shared/application';
|
||||
import type { Logger, UseCaseOutputPort } from '@core/shared/application';
|
||||
import { Result } from '@core/shared/application/Result';
|
||||
import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
|
||||
import type { NotificationChannel, NotificationType } from '../../domain/types/NotificationTypes';
|
||||
import { NotificationDomainError } from '../../domain/errors/NotificationDomainError';
|
||||
|
||||
@@ -19,38 +31,46 @@ describe('NotificationPreferencesUseCases', () => {
|
||||
};
|
||||
let logger: Logger;
|
||||
|
||||
beforeEach(() => {
|
||||
preferenceRepository = {
|
||||
getOrCreateDefault: vi.fn(),
|
||||
save: vi.fn(),
|
||||
} as unknown as INotificationPreferenceRepository as any;
|
||||
|
||||
logger = {
|
||||
debug: vi.fn(),
|
||||
info: vi.fn(),
|
||||
warn: vi.fn(),
|
||||
error: vi.fn(),
|
||||
} as unknown as Logger;
|
||||
});
|
||||
|
||||
it('GetNotificationPreferencesQuery returns preferences from repository', async () => {
|
||||
const preference = {
|
||||
id: 'pref-1',
|
||||
} as unknown as NotificationPreference;
|
||||
|
||||
preferenceRepository.getOrCreateDefault.mockResolvedValue(preference);
|
||||
|
||||
const useCase = new GetNotificationPreferencesQuery(
|
||||
preferenceRepository as unknown as INotificationPreferenceRepository,
|
||||
logger,
|
||||
);
|
||||
|
||||
const result = await useCase.execute('driver-1');
|
||||
|
||||
expect(preferenceRepository.getOrCreateDefault).toHaveBeenCalledWith('driver-1');
|
||||
expect(result).toBe(preference);
|
||||
});
|
||||
|
||||
|
||||
beforeEach(() => {
|
||||
preferenceRepository = {
|
||||
getOrCreateDefault: vi.fn(),
|
||||
save: vi.fn(),
|
||||
} as unknown as INotificationPreferenceRepository as any;
|
||||
|
||||
logger = {
|
||||
debug: vi.fn(),
|
||||
info: vi.fn(),
|
||||
warn: vi.fn(),
|
||||
error: vi.fn(),
|
||||
} as unknown as Logger;
|
||||
});
|
||||
|
||||
it('GetNotificationPreferencesQuery returns preferences from repository', async () => {
|
||||
const preference = {
|
||||
id: 'pref-1',
|
||||
} as unknown as NotificationPreference;
|
||||
|
||||
preferenceRepository.getOrCreateDefault.mockResolvedValue(preference);
|
||||
|
||||
const output: UseCaseOutputPort<GetNotificationPreferencesResult> & { present: Mock } = {
|
||||
present: vi.fn(),
|
||||
} as any;
|
||||
|
||||
const useCase = new GetNotificationPreferencesQuery(
|
||||
preferenceRepository as unknown as INotificationPreferenceRepository,
|
||||
output,
|
||||
logger,
|
||||
);
|
||||
|
||||
const input: GetNotificationPreferencesInput = { driverId: 'driver-1' };
|
||||
const result = await useCase.execute(input);
|
||||
|
||||
expect(preferenceRepository.getOrCreateDefault).toHaveBeenCalledWith('driver-1');
|
||||
expect(result).toBeInstanceOf(Result);
|
||||
expect(result.isOk()).toBe(true);
|
||||
expect(output.present).toHaveBeenCalledWith({ preference });
|
||||
});
|
||||
it('UpdateChannelPreferenceUseCase updates channel preference', async () => {
|
||||
const preference = {
|
||||
updateChannel: vi.fn().mockReturnThis(),
|
||||
@@ -58,19 +78,28 @@ describe('NotificationPreferencesUseCases', () => {
|
||||
|
||||
preferenceRepository.getOrCreateDefault.mockResolvedValue(preference);
|
||||
|
||||
const output: UseCaseOutputPort<UpdateChannelPreferenceResult> & { present: Mock } = {
|
||||
present: vi.fn(),
|
||||
} as any;
|
||||
|
||||
const useCase = new UpdateChannelPreferenceUseCase(
|
||||
preferenceRepository as unknown as INotificationPreferenceRepository,
|
||||
output,
|
||||
logger,
|
||||
);
|
||||
|
||||
await useCase.execute({
|
||||
const command: UpdateChannelPreferenceCommand = {
|
||||
driverId: 'driver-1',
|
||||
channel: 'email' as NotificationChannel,
|
||||
preference: 'enabled' as ChannelPreference,
|
||||
});
|
||||
preference: { enabled: true } as ChannelPreference,
|
||||
};
|
||||
|
||||
const result = await useCase.execute(command);
|
||||
|
||||
expect(result.isOk()).toBe(true);
|
||||
expect(preference.updateChannel).toHaveBeenCalled();
|
||||
expect(preferenceRepository.save).toHaveBeenCalledWith(preference);
|
||||
expect(output.present).toHaveBeenCalledWith({ driverId: 'driver-1', channel: 'email' });
|
||||
});
|
||||
|
||||
it('UpdateTypePreferenceUseCase updates type preference', async () => {
|
||||
@@ -80,19 +109,28 @@ describe('NotificationPreferencesUseCases', () => {
|
||||
|
||||
preferenceRepository.getOrCreateDefault.mockResolvedValue(preference);
|
||||
|
||||
const output: UseCaseOutputPort<UpdateTypePreferenceResult> & { present: Mock } = {
|
||||
present: vi.fn(),
|
||||
} as any;
|
||||
|
||||
const useCase = new UpdateTypePreferenceUseCase(
|
||||
preferenceRepository as unknown as INotificationPreferenceRepository,
|
||||
output,
|
||||
logger,
|
||||
);
|
||||
|
||||
await useCase.execute({
|
||||
const command: UpdateTypePreferenceCommand = {
|
||||
driverId: 'driver-1',
|
||||
type: 'info' as NotificationType,
|
||||
preference: 'enabled' as TypePreference,
|
||||
});
|
||||
type: 'system_announcement' as NotificationType,
|
||||
preference: { enabled: true } as TypePreference,
|
||||
};
|
||||
|
||||
const result = await useCase.execute(command);
|
||||
|
||||
expect(result.isOk()).toBe(true);
|
||||
expect(preference.updateTypePreference).toHaveBeenCalled();
|
||||
expect(preferenceRepository.save).toHaveBeenCalledWith(preference);
|
||||
expect(output.present).toHaveBeenCalledWith({ driverId: 'driver-1', type: 'system_announcement' });
|
||||
});
|
||||
|
||||
it('UpdateQuietHoursUseCase validates hours and updates preferences', async () => {
|
||||
@@ -102,34 +140,56 @@ describe('NotificationPreferencesUseCases', () => {
|
||||
|
||||
preferenceRepository.getOrCreateDefault.mockResolvedValue(preference);
|
||||
|
||||
const output: UseCaseOutputPort<UpdateQuietHoursResult> & { present: Mock } = {
|
||||
present: vi.fn(),
|
||||
} as any;
|
||||
|
||||
const useCase = new UpdateQuietHoursUseCase(
|
||||
preferenceRepository as unknown as INotificationPreferenceRepository,
|
||||
output,
|
||||
logger,
|
||||
);
|
||||
|
||||
await useCase.execute({
|
||||
const command: UpdateQuietHoursCommand = {
|
||||
driverId: 'driver-1',
|
||||
startHour: 22,
|
||||
endHour: 7,
|
||||
};
|
||||
|
||||
const result = await useCase.execute(command);
|
||||
|
||||
expect(result.isOk()).toBe(true);
|
||||
expect(preference.updateQuietHours).toHaveBeenCalledWith(22, 7);
|
||||
expect(preferenceRepository.save).toHaveBeenCalledWith(preference);
|
||||
expect(output.present).toHaveBeenCalledWith({
|
||||
driverId: 'driver-1',
|
||||
startHour: 22,
|
||||
endHour: 7,
|
||||
});
|
||||
|
||||
expect(preference.updateQuietHours).toHaveBeenCalledWith(22, 7);
|
||||
expect(preferenceRepository.save).toHaveBeenCalledWith(preference);
|
||||
});
|
||||
|
||||
it('UpdateQuietHoursUseCase throws on invalid hours', async () => {
|
||||
it('UpdateQuietHoursUseCase returns error on invalid hours', async () => {
|
||||
const output: UseCaseOutputPort<UpdateQuietHoursResult> & { present: Mock } = {
|
||||
present: vi.fn(),
|
||||
} as any;
|
||||
|
||||
const useCase = new UpdateQuietHoursUseCase(
|
||||
preferenceRepository as unknown as INotificationPreferenceRepository,
|
||||
output,
|
||||
logger,
|
||||
);
|
||||
|
||||
await expect(
|
||||
useCase.execute({ driverId: 'd1', startHour: -1, endHour: 10 }),
|
||||
).rejects.toThrow(NotificationDomainError);
|
||||
const badStart: UpdateQuietHoursCommand = { driverId: 'd1', startHour: -1, endHour: 10 };
|
||||
const result1 = await useCase.execute(badStart);
|
||||
expect(result1.isErr()).toBe(true);
|
||||
const err1 = result1.unwrapErr() as ApplicationErrorCode<'INVALID_START_HOUR', { message: string }>;
|
||||
expect(err1.code).toBe('INVALID_START_HOUR');
|
||||
|
||||
await expect(
|
||||
useCase.execute({ driverId: 'd1', startHour: 10, endHour: 24 }),
|
||||
).rejects.toThrow(NotificationDomainError);
|
||||
const badEnd: UpdateQuietHoursCommand = { driverId: 'd1', startHour: 10, endHour: 24 };
|
||||
const result2 = await useCase.execute(badEnd);
|
||||
expect(result2.isErr()).toBe(true);
|
||||
const err2 = result2.unwrapErr() as ApplicationErrorCode<'INVALID_END_HOUR', { message: string }>;
|
||||
expect(err2.code).toBe('INVALID_END_HOUR');
|
||||
});
|
||||
|
||||
it('SetDigestModeUseCase sets digest mode with valid frequency', async () => {
|
||||
@@ -139,27 +199,52 @@ describe('NotificationPreferencesUseCases', () => {
|
||||
|
||||
preferenceRepository.getOrCreateDefault.mockResolvedValue(preference);
|
||||
|
||||
const output: UseCaseOutputPort<SetDigestModeResult> & { present: Mock } = {
|
||||
present: vi.fn(),
|
||||
} as any;
|
||||
|
||||
const useCase = new SetDigestModeUseCase(
|
||||
preferenceRepository as unknown as INotificationPreferenceRepository,
|
||||
output,
|
||||
);
|
||||
|
||||
await useCase.execute({
|
||||
const command: SetDigestModeCommand = {
|
||||
driverId: 'driver-1',
|
||||
enabled: true,
|
||||
frequencyHours: 4,
|
||||
};
|
||||
|
||||
const result = await useCase.execute(command);
|
||||
|
||||
expect(result.isOk()).toBe(true);
|
||||
expect(preference.setDigestMode).toHaveBeenCalledWith(true, 4);
|
||||
expect(preferenceRepository.save).toHaveBeenCalledWith(preference);
|
||||
expect(output.present).toHaveBeenCalledWith({
|
||||
driverId: 'driver-1',
|
||||
enabled: true,
|
||||
frequencyHours: 4,
|
||||
});
|
||||
|
||||
expect(preference.setDigestMode).toHaveBeenCalledWith(true, 4);
|
||||
expect(preferenceRepository.save).toHaveBeenCalledWith(preference);
|
||||
});
|
||||
|
||||
it('SetDigestModeUseCase throws on invalid frequency', async () => {
|
||||
it('SetDigestModeUseCase returns error on invalid frequency', async () => {
|
||||
const output: UseCaseOutputPort<SetDigestModeResult> & { present: Mock } = {
|
||||
present: vi.fn(),
|
||||
} as any;
|
||||
|
||||
const useCase = new SetDigestModeUseCase(
|
||||
preferenceRepository as unknown as INotificationPreferenceRepository,
|
||||
output,
|
||||
);
|
||||
|
||||
await expect(
|
||||
useCase.execute({ driverId: 'driver-1', enabled: true, frequencyHours: 0 }),
|
||||
).rejects.toThrow(NotificationDomainError);
|
||||
const command: SetDigestModeCommand = {
|
||||
driverId: 'driver-1',
|
||||
enabled: true,
|
||||
frequencyHours: 0,
|
||||
};
|
||||
|
||||
const result = await useCase.execute(command);
|
||||
expect(result.isErr()).toBe(true);
|
||||
const err = result.unwrapErr() as ApplicationErrorCode<'INVALID_FREQUENCY', { message: string }>;
|
||||
expect(err.code).toBe('INVALID_FREQUENCY');
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user