refactor use cases

core/media/application/use-cases/GetMediaUseCase.test.ts

@@ -1,13 +1,20 @@
 import { describe, it, expect, vi, type Mock } from 'vitest';
-import { GetMediaUseCase } from './GetMediaUseCase';
+import {
+  GetMediaUseCase,
+  type GetMediaInput,
+  type GetMediaResult,
+  type GetMediaErrorCode,
+} from './GetMediaUseCase';
 import type { IMediaRepository } from '../../domain/repositories/IMediaRepository';
-import type { IGetMediaPresenter } from '../presenters/IGetMediaPresenter';
-import type { Logger } from '@core/shared/application';
+import type { Logger, UseCaseOutputPort } from '@core/shared/application';
+import { Result } from '@core/shared/application/Result';
+import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
 import { Media } from '../../domain/entities/Media';
 import { MediaUrl } from '../../domain/value-objects/MediaUrl';
 
-interface TestPresenter extends IGetMediaPresenter {
-  result?: any;
+interface TestOutputPort extends UseCaseOutputPort<GetMediaResult> {
+  present: Mock;
+  result?: GetMediaResult;
 }
 
 describe('GetMediaUseCase', () => {
@@ -15,7 +22,7 @@ describe('GetMediaUseCase', () => {
     findById: Mock;
   };
   let logger: Logger;
-  let presenter: TestPresenter;
+  let output: TestOutputPort;
   let useCase: GetMediaUseCase;
 
   beforeEach(() => {
@@ -30,28 +37,31 @@ describe('GetMediaUseCase', () => {
       error: vi.fn(),
     } as unknown as Logger;
 
-    presenter = {
-      present: vi.fn((result) => {
-        presenter.result = result;
+    output = {
+      present: vi.fn((result: GetMediaResult) => {
+        output.result = result;
       }),
-    } as unknown as TestPresenter;
+    } as unknown as TestOutputPort;
 
     useCase = new GetMediaUseCase(
       mediaRepo as unknown as IMediaRepository,
+      output,
       logger,
     );
   });
 
-  it('presents error when media is not found', async () => {
+  it('returns MEDIA_NOT_FOUND when media is not found', async () => {
     mediaRepo.findById.mockResolvedValue(null);
 
-    await useCase.execute({ mediaId: 'missing' }, presenter);
+    const input: GetMediaInput = { mediaId: 'missing' };
+    const result = await useCase.execute(input);
 
     expect(mediaRepo.findById).toHaveBeenCalledWith('missing');
-    expect((presenter.present as unknown as Mock)).toHaveBeenCalledWith({
-      success: false,
-      errorMessage: 'Media not found',
-    });
+    expect(result).toBeInstanceOf(Result);
+    expect(result.isErr()).toBe(true);
+    const err = result.unwrapErr() as ApplicationErrorCode<GetMediaErrorCode, { message: string }>;
+    expect(err.code).toBe('MEDIA_NOT_FOUND');
+    expect(output.present).not.toHaveBeenCalled();
   });
 
   it('presents media details when media exists', async () => {
@@ -68,11 +78,12 @@ describe('GetMediaUseCase', () => {
 
     mediaRepo.findById.mockResolvedValue(media);
 
-    await useCase.execute({ mediaId: 'media-1' }, presenter);
+    const input: GetMediaInput = { mediaId: 'media-1' };
+    const result = await useCase.execute(input);
 
+    expect(result.isOk()).toBe(true);
     expect(mediaRepo.findById).toHaveBeenCalledWith('media-1');
-    expect((presenter.present as unknown as Mock)).toHaveBeenCalledWith({
-      success: true,
+    expect(output.present).toHaveBeenCalledWith({
       media: {
         id: media.id,
         filename: media.filename,
@@ -88,15 +99,15 @@ describe('GetMediaUseCase', () => {
     });
   });
 
-  it('handles errors by logging and presenting failure', async () => {
+  it('handles repository errors by returning REPOSITORY_ERROR', async () => {
     mediaRepo.findById.mockRejectedValue(new Error('DB error'));
 
-    await useCase.execute({ mediaId: 'media-1' }, presenter);
+    const input: GetMediaInput = { mediaId: 'media-1' };
+    const result = await useCase.execute(input);
 
     expect((logger.error as unknown as Mock)).toHaveBeenCalled();
-    expect((presenter.present as unknown as Mock)).toHaveBeenCalledWith({
-      success: false,
-      errorMessage: 'Internal error occurred while retrieving media',
-    });
+    expect(result.isErr()).toBe(true);
+    const err = result.unwrapErr() as ApplicationErrorCode<GetMediaErrorCode, { message: string }>;
+    expect(err.code).toBe('REPOSITORY_ERROR');
   });
 });