refactor

core/racing/application/use-cases/GetDriverTeamUseCase.test.ts

@@ -1,46 +1,43 @@
-import { describe, it, expect, beforeEach, vi, Mock } from 'vitest';
+import { describe, it, expect, beforeEach, vi } from 'vitest';
 import { GetDriverTeamUseCase } from './GetDriverTeamUseCase';
 import type { ITeamRepository } from '../../domain/repositories/ITeamRepository';
 import type { ITeamMembershipRepository } from '../../domain/repositories/ITeamMembershipRepository';
 import type { Logger } from '@core/shared/application';
 
 describe('GetDriverTeamUseCase', () => {
-  let mockTeamRepo: ITeamRepository;
-  let mockMembershipRepo: ITeamMembershipRepository;
-  let mockLogger: Logger;
-  let mockFindById: Mock;
-  let mockGetActiveMembershipForDriver: Mock;
+  const mockFindById = vi.fn();
+  const mockGetActiveMembershipForDriver = vi.fn();
+  const mockTeamRepo: ITeamRepository = {
+    findById: mockFindById,
+    findAll: vi.fn(),
+    findByLeagueId: vi.fn(),
+    create: vi.fn(),
+    update: vi.fn(),
+    delete: vi.fn(),
+    exists: vi.fn(),
+  };
+
+  const mockMembershipRepo: ITeamMembershipRepository = {
+    getActiveMembershipForDriver: mockGetActiveMembershipForDriver,
+    getMembership: vi.fn(),
+    getTeamMembers: vi.fn(),
+    saveMembership: vi.fn(),
+    removeMembership: vi.fn(),
+    getJoinRequests: vi.fn(),
+    countByTeamId: vi.fn(),
+    saveJoinRequest: vi.fn(),
+    removeJoinRequest: vi.fn(),
+  };
+
+  const mockLogger: Logger = {
+    debug: vi.fn(),
+    info: vi.fn(),
+    warn: vi.fn(),
+    error: vi.fn(),
+  };
 
   beforeEach(() => {
-    mockFindById = vi.fn();
-    mockGetActiveMembershipForDriver = vi.fn();
-    mockTeamRepo = {
-      findById: mockFindById,
-      findAll: vi.fn(),
-      findByLeagueId: vi.fn(),
-      create: vi.fn(),
-      update: vi.fn(),
-      delete: vi.fn(),
-      exists: vi.fn(),
-    } as ITeamRepository;
-    mockMembershipRepo = {
-      getActiveMembershipForDriver: mockGetActiveMembershipForDriver,
-      getMembership: vi.fn(),
-      getTeamMembers: vi.fn(),
-      saveMembership: vi.fn(),
-      removeMembership: vi.fn(),
-      getJoinRequests: vi.fn(),
-      getMembershipsForDriver: vi.fn(),
-      countByTeamId: vi.fn(),
-      saveJoinRequest: vi.fn(),
-      removeJoinRequest: vi.fn(),
-    } as ITeamMembershipRepository;
-    mockLogger = {
-      debug: vi.fn(),
-      info: vi.fn(),
-      warn: vi.fn(),
-      error: vi.fn(),
-    };
+    vi.clearAllMocks();
   });
 
   it('should return driver team data when membership and team exist', async () => {
@@ -69,8 +66,8 @@ describe('GetDriverTeamUseCase', () => {
 
   it('should return error when no active membership found', async () => {
     const useCase = new GetDriverTeamUseCase(
-      mockTeamRepo as unknown as ITeamRepository,
-      mockMembershipRepo as unknown as ITeamMembershipRepository,
+      mockTeamRepo,
+      mockMembershipRepo,
       mockLogger,
     );
 
@@ -87,8 +84,8 @@ describe('GetDriverTeamUseCase', () => {
 
   it('should return error when team not found', async () => {
     const useCase = new GetDriverTeamUseCase(
-      mockTeamRepo as unknown as ITeamRepository,
-      mockMembershipRepo as unknown as ITeamMembershipRepository,
+      mockTeamRepo,
+      mockMembershipRepo,
       mockLogger,
     );
 
@@ -107,8 +104,8 @@ describe('GetDriverTeamUseCase', () => {
 
   it('should return error when repository throws', async () => {
     const useCase = new GetDriverTeamUseCase(
-      mockTeamRepo as unknown as ITeamRepository,
-      mockMembershipRepo as unknown as ITeamMembershipRepository,
+      mockTeamRepo,
+      mockMembershipRepo,
       mockLogger,
     );