website refactor

apps/website/lib/services/teams/TeamService.ts

@@ -1,3 +1,4 @@
+import { injectable, unmanaged } from 'inversify';
 import { TeamsApiClient } from '@/lib/api/teams/TeamsApiClient';
 import type { TeamListItemDTO } from '@/lib/types/generated/TeamListItemDTO';
 import type { CreateTeamInputDTO } from '@/lib/types/generated/CreateTeamInputDTO';
@@ -7,6 +8,7 @@ import type { UpdateTeamOutputDTO } from '@/lib/types/generated/UpdateTeamOutput
 import type { GetDriverTeamOutputDTO } from '@/lib/types/generated/GetDriverTeamOutputDTO';
 import type { GetTeamMembershipOutputDTO } from '@/lib/types/generated/GetTeamMembershipOutputDTO';
 import type { GetTeamJoinRequestsOutputDTO } from '@/lib/types/generated/GetTeamJoinRequestsOutputDTO';
+import type { GetTeamDetailsOutputDTO } from '@/lib/types/generated/GetTeamDetailsOutputDTO';
 import { TeamMemberViewModel } from '@/lib/view-models/TeamMemberViewModel';
 import { TeamSummaryViewModel } from '@/lib/view-models/TeamSummaryViewModel';
 import { TeamDetailsViewModel } from '@/lib/view-models/TeamDetailsViewModel';
@@ -23,10 +25,11 @@ import { isProductionEnvironment } from '@/lib/config/env';
  * Returns raw API DTOs. No ViewModels or UX logic.
  * All client-side presentation logic must be handled by hooks/components.
  */
+@injectable()
 export class TeamService implements Service {
   private apiClient: TeamsApiClient;
 
-  constructor(apiClient?: TeamsApiClient) {
+  constructor(@unmanaged() apiClient?: TeamsApiClient) {
     if (apiClient) {
       this.apiClient = apiClient;
     } else {
@@ -51,86 +54,86 @@ export class TeamService implements Service {
   }
 
   async update(teamId: string, input: UpdateTeamInputDTO): Promise<Result<UpdateTeamOutputDTO, DomainError>> {
-    return this.updateTeam(teamId, input);
+    try {
+      const result = await this.apiClient.update(teamId, input);
+      return Result.ok((result as any).value || result);
+    } catch (error: unknown) {
+      return Result.err({ type: 'unknown', message: (error as Error).message || 'Failed to update team' });
+    }
   }
 
   async create(input: CreateTeamInputDTO): Promise<Result<CreateTeamOutputDTO, DomainError>> {
-    return this.createTeam(input);
+    try {
+      const result = await this.apiClient.create(input);
+      return Result.ok((result as any).value || result);
+    } catch (error: unknown) {
+      return Result.err({ type: 'unknown', message: (error as Error).message || 'Failed to create team' });
+    }
   }
 
-  async getTeamDetails(teamId: string, _: string): Promise<any> {
+  async getTeamDetails(teamId: string, _: string): Promise<Result<GetTeamDetailsOutputDTO, DomainError>> {
     try {
       const result = await this.apiClient.getDetails(teamId);
       if (!result) {
-        return null;
+        return Result.err({ type: 'notFound', message: 'Team not found' });
       }
-      const data = (result as any).value || result;
-      return new TeamDetailsViewModel(data, {} as any);
+      return Result.ok((result as any).value || result);
     } catch (error: unknown) {
-      throw error;
+      return Result.err({ type: 'unknown', message: (error as Error).message || 'Failed to fetch team details' });
     }
   }
 
-  async getTeamMembers(teamId: string, currentDriverId: string, ownerId: string): Promise<any> {
+  async getTeamMembers(teamId: string, currentDriverId: string, ownerId: string): Promise<Result<TeamMemberViewModel[], DomainError>> {
     try {
       const result = await this.apiClient.getMembers(teamId);
       const members = (result as any).members || result;
-      return members.map((member: any) => new TeamMemberViewModel(member, currentDriverId, ownerId));
+      const viewModels = members.map((member: any) => new TeamMemberViewModel(member, currentDriverId, ownerId));
+      return Result.ok(viewModels);
     } catch (error: unknown) {
-      throw error;
+      return Result.err({ type: 'unknown', message: (error as Error).message || 'Failed to fetch team members' });
     }
   }
 
-  async getTeamJoinRequests(teamId: string): Promise<any> {
+  async getTeamJoinRequests(teamId: string): Promise<Result<any, DomainError>> {
     try {
       const result = await this.apiClient.getJoinRequests(teamId);
-      return (result as any).value || result;
+      return Result.ok((result as any).value || result);
     } catch (error: unknown) {
-      throw error;
+      return Result.err({ type: 'unknown', message: (error as Error).message || 'Failed to fetch join requests' });
     }
   }
 
-  async createTeam(input: CreateTeamInputDTO): Promise<any> {
-    try {
-      const result = await this.apiClient.create(input);
-      return (result as any).value || result;
-    } catch (error: unknown) {
-      throw error;
-    }
+  async createTeam(input: CreateTeamInputDTO): Promise<Result<any, DomainError>> {
+    return this.create(input);
   }
 
-  async updateTeam(teamId: string, input: UpdateTeamInputDTO): Promise<any> {
-    try {
-      const result = await this.apiClient.update(teamId, input);
-      return (result as any).value || result;
-    } catch (error: unknown) {
-      throw error;
-    }
+  async updateTeam(teamId: string, input: UpdateTeamInputDTO): Promise<Result<any, DomainError>> {
+    return this.update(teamId, input);
   }
 
-  async getDriverTeam(driverId: string): Promise<any> {
+  async getDriverTeam(driverId: string): Promise<Result<any, DomainError>> {
     try {
       const result = await this.apiClient.getDriverTeam(driverId);
-      if (!result) return null;
+      if (!result) return Result.ok(null);
       const data = (result as any).value || result;
-      if (!data.team) return null;
-      return {
+      if (!data.team) return Result.ok(null);
+      return Result.ok({
         teamId: data.team.id,
         teamName: data.team.name,
         role: data.membership?.role,
-      };
+      });
     } catch (error: unknown) {
-      throw error;
+      return Result.err({ type: 'unknown', message: (error as Error).message || 'Failed to fetch driver team' });
     }
   }
 
-  async getAllTeams(): Promise<any> {
+  async getAllTeams(): Promise<Result<TeamListItemDTO[], DomainError>> {
     try {
       const result = await this.apiClient.getAll();
       const teams = (result as any).teams || result;
-      return teams.map((t: any) => new TeamSummaryViewModel(t));
+      return Result.ok(teams);
     } catch (error: unknown) {
-      throw error;
+      return Result.err({ type: 'unknown', message: (error as Error).message || 'Failed to fetch all teams' });
     }
   }
 
@@ -142,4 +145,4 @@ export class TeamService implements Service {
       return Result.err({ type: 'unknown', message: (error as Error).message || 'Failed to fetch team membership' });
     }
   }
-}
+}