website refactor

apps/website/lib/services/teams/TeamJoinService.ts

@@ -1,3 +1,4 @@
+import { injectable, unmanaged } from 'inversify';
 import { TeamsApiClient } from '@/lib/api/teams/TeamsApiClient';
 import { TeamJoinRequestViewModel } from '@/lib/view-models/TeamJoinRequestViewModel';
 import { Result } from '@/lib/contracts/Result';
@@ -13,10 +14,11 @@ import { isProductionEnvironment } from '@/lib/config/env';
  * Returns ViewModels for team join requests.
  * Handles presentation logic for join request management.
  */
+@injectable()
 export class TeamJoinService implements Service {
   private apiClient: TeamsApiClient;
 
-  constructor(apiClient?: TeamsApiClient) {
+  constructor(@unmanaged() apiClient?: TeamsApiClient) {
     if (apiClient) {
       this.apiClient = apiClient;
     } else {
@@ -31,23 +33,24 @@ export class TeamJoinService implements Service {
     }
   }
 
-  async getJoinRequests(teamId: string, currentDriverId: string, isOwner: boolean): Promise<any[]> {
+  async getJoinRequests(teamId: string, currentDriverId: string, isOwner: boolean): Promise<Result<TeamJoinRequestViewModel[], DomainError>> {
     try {
       const result = await this.apiClient.getJoinRequests(teamId);
       const requests = (result as any).requests || result;
-      return requests.map((request: any) => 
+      const viewModels = requests.map((request: any) => 
         new TeamJoinRequestViewModel(request, currentDriverId, isOwner)
       );
+      return Result.ok(viewModels);
     } catch (error: any) {
-      throw error;
+      return Result.err({ type: 'serverError', message: error.message || 'Failed to fetch join requests' });
     }
   }
 
-  async approveJoinRequest(): Promise<void> {
-    throw new Error('Not implemented: API endpoint for approving join requests');
+  async approveJoinRequest(): Promise<Result<void, DomainError>> {
+    return Result.err({ type: 'notImplemented', message: 'Not implemented: API endpoint for approving join requests' });
   }
 
-  async rejectJoinRequest(): Promise<void> {
-    throw new Error('Not implemented: API endpoint for rejecting join requests');
+  async rejectJoinRequest(): Promise<Result<void, DomainError>> {
+    return Result.err({ type: 'notImplemented', message: 'Not implemented: API endpoint for rejecting join requests' });
   }
 }