refactor

core/racing/application/use-cases/GetTeamMembersUseCase.ts

@@ -1,34 +1,26 @@
 import type { ITeamMembershipRepository } from '../../domain/repositories/ITeamMembershipRepository';
 import type { IDriverRepository } from '../../domain/repositories/IDriverRepository';
 import type { IImageServicePort } from '../ports/IImageServicePort';
-import type {
-  ITeamMembersPresenter,
-  TeamMembersResultDTO,
-  TeamMembersViewModel,
-} from '../presenters/ITeamMembersPresenter';
-import type { UseCase } from '@core/shared/application';
+import type { TeamMembersResultDTO } from '../presenters/ITeamMembersPresenter';
+import { Result } from '@core/shared/application/Result';
+import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
+import type { AsyncUseCase } from '@core/shared/application';
 import type { Logger } from '@core/shared/application';
 
 /**
  * Use Case for retrieving team members.
- * Orchestrates domain logic and delegates presentation to the presenter.
  */
-export class GetTeamMembersUseCase
-  implements UseCase<{ teamId: string }, TeamMembersResultDTO, TeamMembersViewModel, ITeamMembersPresenter>
+export class GetTeamMembersUseCase implements AsyncUseCase<{ teamId: string }, TeamMembersResultDTO, 'REPOSITORY_ERROR'>
 {
   constructor(
     private readonly membershipRepository: ITeamMembershipRepository,
     private readonly driverRepository: IDriverRepository,
     private readonly imageService: IImageServicePort,
     private readonly logger: Logger,
-    // Kept for backward compatibility; callers must pass their own presenter.
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    public readonly presenter: ITeamMembersPresenter,
   ) {}
 
-  async execute(input: { teamId: string }, presenter: ITeamMembersPresenter): Promise<void> {
+  async execute(input: { teamId: string }): Promise<Result<TeamMembersResultDTO, ApplicationErrorCode<'REPOSITORY_ERROR'>>> {
     this.logger.debug(`Executing GetTeamMembersUseCase for teamId: ${input.teamId}`);
-    presenter.reset();
 
     try {
       const memberships = await this.membershipRepository.getTeamMembers(input.teamId);
@@ -54,11 +46,10 @@ export class GetTeamMembersUseCase
         avatarUrls,
       };
 
-      presenter.present(dto);
-      this.logger.info(`Successfully presented team members for teamId: ${input.teamId}`);
+      return Result.ok(dto);
     } catch (error) {
-      this.logger.error(`Error in GetTeamMembersUseCase for teamId: ${input.teamId}, error: ${error instanceof Error ? error.message : String(error)}`);
-      throw error;
+      this.logger.error(`Error in GetTeamMembersUseCase for teamId: ${input.teamId}`, error as Error, { teamId: input.teamId });
+      return Result.err({ code: 'REPOSITORY_ERROR', details: { message: 'Failed to retrieve team members' } });
     }
   }
 }