refactor

core/racing/application/use-cases/GetRaceWithSOFUseCase.ts

@@ -3,9 +3,11 @@
  *
  * Returns race details enriched with calculated Strength of Field (SOF).
  * SOF is calculated from participant ratings if not already stored on the race.
- * Orchestrates domain logic and delegates presentation to the presenter.
  */
 
+import { Result } from '@core/shared/application/Result';
+import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
+import type { AsyncUseCase } from '@core/shared/application/AsyncUseCase';
 import type { IRaceRepository } from '../../domain/repositories/IRaceRepository';
 import type { IRaceRegistrationRepository } from '../../domain/repositories/IRaceRegistrationRepository';
 import type { IResultRepository } from '../../domain/repositories/IResultRepository';
@@ -14,16 +16,30 @@ import {
   AverageStrengthOfFieldCalculator,
   type StrengthOfFieldCalculator,
 } from '../../domain/services/StrengthOfFieldCalculator';
-import type { IRaceWithSOFPresenter, RaceWithSOFResultDTO } from '../presenters/IRaceWithSOFPresenter';
-import type { UseCase } from '@core/shared/application/UseCase';
 
 export interface GetRaceWithSOFQueryParams {
   raceId: string;
 }
 
-export class GetRaceWithSOFUseCase
-  implements UseCase<GetRaceWithSOFQueryParams, RaceWithSOFResultDTO, import('../presenters/IRaceWithSOFPresenter').RaceWithSOFViewModel, IRaceWithSOFPresenter>
-{
+export interface RaceWithSOFResultDTO {
+  raceId: string;
+  leagueId: string;
+  scheduledAt: Date;
+  track: string;
+  trackId: string;
+  car: string;
+  carId: string;
+  sessionType: string;
+  status: string;
+  strengthOfField: number | null;
+  registeredCount: number;
+  maxParticipants: number;
+  participantCount: number;
+}
+
+type GetRaceWithSOFErrorCode = 'RACE_NOT_FOUND';
+
+export class GetRaceWithSOFUseCase implements AsyncUseCase<GetRaceWithSOFQueryParams, RaceWithSOFResultDTO, GetRaceWithSOFErrorCode> {
   private readonly sofCalculator: StrengthOfFieldCalculator;
 
   constructor(
@@ -36,19 +52,17 @@ export class GetRaceWithSOFUseCase
     this.sofCalculator = sofCalculator ?? new AverageStrengthOfFieldCalculator();
   }
 
-  async execute(params: GetRaceWithSOFQueryParams, presenter: IRaceWithSOFPresenter): Promise<void> {
-    presenter.reset();
-
+  async execute(params: GetRaceWithSOFQueryParams): Promise<Result<RaceWithSOFResultDTO, ApplicationErrorCode<GetRaceWithSOFErrorCode>>> {
     const { raceId } = params;
 
     const race = await this.raceRepository.findById(raceId);
     if (!race) {
-      return;
+      return Result.err({ code: 'RACE_NOT_FOUND' });
     }
 
     // Get participant IDs based on race status
     let participantIds: string[] = [];
-    
+
     if (race.status === 'completed') {
       // For completed races, use results
       const results = await this.resultRepository.findByRaceId(raceId);
@@ -70,8 +84,6 @@ export class GetRaceWithSOFUseCase
       strengthOfField = this.sofCalculator.calculate(driverRatings);
     }
 
-    presenter.reset();
-
     const dto: RaceWithSOFResultDTO = {
       raceId: race.id,
       leagueId: race.leagueId,
@@ -80,14 +92,14 @@ export class GetRaceWithSOFUseCase
       trackId: race.trackId ?? '',
       car: race.car ?? '',
       carId: race.carId ?? '',
-      sessionType: race.sessionType,
-      status: race.status,
+      sessionType: race.sessionType as string,
+      status: race.status as string,
       strengthOfField,
       registeredCount: race.registeredCount ?? participantIds.length,
       maxParticipants: race.maxParticipants ?? participantIds.length,
       participantCount: participantIds.length,
     };
 
-    presenter.present(dto);
+    return Result.ok(dto);
   }
 }