refactor

core/racing/application/use-cases/ApproveTeamJoinRequestUseCase.ts

@@ -1,36 +1,34 @@
 import type { ITeamMembershipRepository } from '../../domain/repositories/ITeamMembershipRepository';
 import type {
   TeamMembership,
-  TeamMembershipStatus,
-  TeamRole,
   TeamJoinRequest,
 } from '../../domain/types/TeamMembership';
 import type { ApproveTeamJoinRequestCommandDTO } from '../dto/TeamCommandAndQueryDTO';
 import type { AsyncUseCase } from '@core/shared/application';
-import { Result } from '@core/shared/result/Result';
-import { RacingDomainValidationError } from '../../domain/errors/RacingDomainError';
+import { Result } from '@core/shared/application/Result';
+import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
 
 export class ApproveTeamJoinRequestUseCase
-  implements AsyncUseCase<ApproveTeamJoinRequestCommandDTO, Result<void, RacingDomainValidationError>> {
+  implements AsyncUseCase<ApproveTeamJoinRequestCommandDTO, void, string> {
   constructor(
     private readonly membershipRepository: ITeamMembershipRepository,
   ) {}
 
-  async execute(command: ApproveTeamJoinRequestCommandDTO): Promise<Result<void, RacingDomainValidationError>> {
+  async execute(command: ApproveTeamJoinRequestCommandDTO): Promise<Result<void, ApplicationErrorCode<string>>> {
     const { teamId, requestId } = command;
 
     const allRequests: TeamJoinRequest[] = await this.membershipRepository.getJoinRequests(teamId);
     const request = allRequests.find((r) => r.id === requestId);
 
     if (!request) {
-      return Result.err(new RacingDomainValidationError('Join request not found'));
+      return Result.err({ code: 'JOIN_REQUEST_NOT_FOUND' });
     }
 
     const membership: TeamMembership = {
       teamId: request.teamId,
       driverId: request.driverId,
-      role: 'driver' as TeamRole,
-      status: 'active' as TeamMembershipStatus,
+      role: 'driver',
+      status: 'active',
       joinedAt: new Date(),
     };