refactor

core/racing/application/use-cases/ApproveLeagueJoinRequestUseCase.test.ts

@@ -1,45 +1,54 @@
-import { ApproveLeagueJoinRequestUseCase } from '@core/racing/application/use-cases/ApproveLeagueJoinRequestUseCase';
-import { ApproveLeagueJoinRequestPresenter } from '@apps/api/src/modules/league/presenters/ApproveLeagueJoinRequestPresenter';
-
+import { describe, it, expect, beforeEach, vi, Mock } from 'vitest';
+import { ApproveLeagueJoinRequestUseCase } from './ApproveLeagueJoinRequestUseCase';
+import type { ILeagueMembershipRepository } from '../../domain/repositories/ILeagueMembershipRepository';
 
 describe('ApproveLeagueJoinRequestUseCase', () => {
-  let useCase: ApproveLeagueJoinRequestUseCase;
-  let leagueMembershipRepository: jest.Mocked<ILeagueMembershipRepository>;
-  let presenter: ApproveLeagueJoinRequestPresenter;
+  let mockLeagueMembershipRepo: {
+    getJoinRequests: Mock;
+    removeJoinRequest: Mock;
+    saveMembership: Mock;
+  };
 
   beforeEach(() => {
-    leagueMembershipRepository = {
-      getJoinRequests: jest.fn(),
-      removeJoinRequest: jest.fn(),
-      saveMembership: jest.fn(),
-    } as unknown;
-    presenter = new ApproveLeagueJoinRequestPresenter();
-    useCase = new ApproveLeagueJoinRequestUseCase(leagueMembershipRepository);
+    mockLeagueMembershipRepo = {
+      getJoinRequests: vi.fn(),
+      removeJoinRequest: vi.fn(),
+      saveMembership: vi.fn(),
+    };
   });
 
   it('should approve join request and save membership', async () => {
+    const useCase = new ApproveLeagueJoinRequestUseCase(mockLeagueMembershipRepo as unknown as ILeagueMembershipRepository);
+
     const leagueId = 'league-1';
     const requestId = 'req-1';
     const joinRequests = [{ id: requestId, leagueId, driverId: 'driver-1', requestedAt: new Date(), message: 'msg' }];
 
-    leagueMembershipRepository.getJoinRequests.mockResolvedValue(joinRequests);
+    mockLeagueMembershipRepo.getJoinRequests.mockResolvedValue(joinRequests);
 
-    await useCase.execute({ leagueId, requestId }, presenter);
+    const result = await useCase.execute({ leagueId, requestId });
 
-    expect(leagueMembershipRepository.removeJoinRequest).toHaveBeenCalledWith(requestId);
-    expect(leagueMembershipRepository.saveMembership).toHaveBeenCalledWith({
+    expect(result.isOk()).toBe(true);
+    expect(result.value).toEqual({ success: true, message: 'Join request approved.' });
+    expect(mockLeagueMembershipRepo.removeJoinRequest).toHaveBeenCalledWith(requestId);
+    expect(mockLeagueMembershipRepo.saveMembership).toHaveBeenCalledWith({
+      id: expect.any(String),
       leagueId,
       driverId: 'driver-1',
       role: 'member',
       status: 'active',
       joinedAt: expect.any(Date),
     });
-    expect(presenter.viewModel).toEqual({ success: true, message: 'Join request approved.' });
   });
 
-  it('should throw error if request not found', async () => {
-    leagueMembershipRepository.getJoinRequests.mockResolvedValue([]);
+  it('should return error if request not found', async () => {
+    const useCase = new ApproveLeagueJoinRequestUseCase(mockLeagueMembershipRepo as unknown as ILeagueMembershipRepository);
 
-    await expect(useCase.execute({ leagueId: 'league-1', requestId: 'req-1' }, presenter)).rejects.toThrow('Join request not found');
+    mockLeagueMembershipRepo.getJoinRequests.mockResolvedValue([]);
+
+    const result = await useCase.execute({ leagueId: 'league-1', requestId: 'req-1' });
+
+    expect(result.isOk()).toBe(false);
+    expect(result.error!.code).toBe('JOIN_REQUEST_NOT_FOUND');
   });
 });