fix issues

apps/website/lib/services/leagues/LeagueService.test.ts

@@ -1,8 +1,15 @@
 import { describe, it, expect, vi, Mocked } from 'vitest';
 import { LeagueService } from './LeagueService';
 import { LeaguesApiClient } from '../../api/leagues/LeaguesApiClient';
-import { LeagueSummaryViewModel, LeagueStandingsViewModel, LeagueStatsViewModel, LeagueScheduleViewModel, LeagueMembershipsViewModel, CreateLeagueViewModel, RemoveMemberViewModel, LeagueMemberViewModel } from '../../view-models';
-import type { LeagueWithCapacityDTO, CreateLeagueInputDTO, CreateLeagueOutputDTO, RemoveLeagueMemberOutputDTO, LeagueMemberDTO } from '../../types/generated';
+import { LeagueStandingsViewModel } from '../../view-models/LeagueStandingsViewModel';
+import { LeagueStatsViewModel } from '../../view-models/LeagueStatsViewModel';
+import { LeagueScheduleViewModel } from '../../view-models/LeagueScheduleViewModel';
+import { LeagueMembershipsViewModel } from '../../view-models/LeagueMembershipsViewModel';
+import { RemoveMemberViewModel } from '../../view-models/RemoveMemberViewModel';
+import { LeagueMemberViewModel } from '../../view-models/LeagueMemberViewModel';
+import type { CreateLeagueInputDTO } from '../../types/generated/CreateLeagueInputDTO';
+import type { CreateLeagueOutputDTO } from '../../types/generated/CreateLeagueOutputDTO';
+import type { RemoveLeagueMemberOutputDTO } from '../../types/generated/RemoveLeagueMemberOutputDTO';
 
 describe('LeagueService', () => {
   let mockApiClient: Mocked<LeaguesApiClient>;
@@ -17,7 +24,7 @@ describe('LeagueService', () => {
       getMemberships: vi.fn(),
       create: vi.fn(),
       removeMember: vi.fn(),
-    } as Mocked<LeaguesApiClient>;
+    } as unknown as Mocked<LeaguesApiClient>;
 
     service = new LeagueService(mockApiClient);
   });
@@ -25,11 +32,12 @@ describe('LeagueService', () => {
   describe('getAllLeagues', () => {
     it('should call apiClient.getAllWithCapacity and return array of LeagueSummaryViewModel', async () => {
       const mockDto = {
+        totalCount: 2,
         leagues: [
           { id: 'league-1', name: 'League One' },
           { id: 'league-2', name: 'League Two' },
-        ] as LeagueWithCapacityDTO[],
-      };
+        ],
+      } as any;
 
       mockApiClient.getAllWithCapacity.mockResolvedValue(mockDto);
 
@@ -37,16 +45,11 @@ describe('LeagueService', () => {
 
       expect(mockApiClient.getAllWithCapacity).toHaveBeenCalled();
       expect(result).toHaveLength(2);
-      expect(result[0]).toBeInstanceOf(LeagueSummaryViewModel);
-      expect(result[0].id).toBe('league-1');
-      expect(result[1]).toBeInstanceOf(LeagueSummaryViewModel);
-      expect(result[1].id).toBe('league-2');
+      expect(result.map((l) => l.id)).toEqual(['league-1', 'league-2']);
     });
 
     it('should handle empty leagues array', async () => {
-      const mockDto = {
-        leagues: [] as LeagueWithCapacityDTO[],
-      };
+      const mockDto = { totalCount: 0, leagues: [] } as any;
 
       mockApiClient.getAllWithCapacity.mockResolvedValue(mockDto);
 
@@ -68,12 +71,8 @@ describe('LeagueService', () => {
       const leagueId = 'league-123';
       const currentUserId = 'user-456';
 
-      const mockDto = {
-        id: leagueId,
-        name: 'Test League',
-      };
-
-      mockApiClient.getStandings.mockResolvedValue(mockDto);
+      mockApiClient.getStandings.mockResolvedValue({ standings: [] } as any);
+      mockApiClient.getMemberships.mockResolvedValue({ members: [] } as any);
 
       const result = await service.getLeagueStandings(leagueId, currentUserId);
 
@@ -116,7 +115,12 @@ describe('LeagueService', () => {
   describe('getLeagueSchedule', () => {
     it('should call apiClient.getSchedule and return LeagueScheduleViewModel', async () => {
       const leagueId = 'league-123';
-      const mockDto = { races: [{ id: 'race-1' }, { id: 'race-2' }] };
+      const mockDto = {
+        races: [
+          { id: 'race-1', name: 'Race One', date: new Date().toISOString() },
+          { id: 'race-2', name: 'Race Two', date: new Date().toISOString() },
+        ],
+      } as any;
 
       mockApiClient.getSchedule.mockResolvedValue(mockDto);
 
@@ -155,11 +159,8 @@ describe('LeagueService', () => {
       const currentUserId = 'user-456';
 
       const mockDto = {
-        memberships: [
-          { driverId: 'driver-1' },
-          { driverId: 'driver-2' },
-        ] as LeagueMemberDTO[],
-      };
+        members: [{ driverId: 'driver-1' }, { driverId: 'driver-2' }],
+      } as any;
 
       mockApiClient.getMemberships.mockResolvedValue(mockDto);
 
@@ -168,17 +169,17 @@ describe('LeagueService', () => {
       expect(mockApiClient.getMemberships).toHaveBeenCalledWith(leagueId);
       expect(result).toBeInstanceOf(LeagueMembershipsViewModel);
       expect(result.memberships).toHaveLength(2);
-      expect(result.memberships[0]).toBeInstanceOf(LeagueMemberViewModel);
-      expect(result.memberships[0].driverId).toBe('driver-1');
+
+      const first = result.memberships[0]!;
+      expect(first).toBeInstanceOf(LeagueMemberViewModel);
+      expect(first.driverId).toBe('driver-1');
     });
 
     it('should handle empty memberships array', async () => {
       const leagueId = 'league-123';
       const currentUserId = 'user-456';
 
-      const mockDto = {
-        memberships: [] as LeagueMemberDTO[],
-      };
+      const mockDto = { members: [] } as any;
 
       mockApiClient.getMemberships.mockResolvedValue(mockDto);
 
@@ -204,6 +205,8 @@ describe('LeagueService', () => {
       const input: CreateLeagueInputDTO = {
         name: 'New League',
         description: 'A new league',
+        visibility: 'public',
+        ownerId: 'owner-1',
       };
 
       const mockDto: CreateLeagueOutputDTO = {
@@ -222,6 +225,8 @@ describe('LeagueService', () => {
       const input: CreateLeagueInputDTO = {
         name: 'New League',
         description: 'A new league',
+        visibility: 'public',
+        ownerId: 'owner-1',
       };
 
       const error = new Error('API call failed');
@@ -234,6 +239,8 @@ describe('LeagueService', () => {
       const input: CreateLeagueInputDTO = {
         name: 'New League',
         description: 'A new league',
+        visibility: 'public',
+        ownerId: 'owner-1',
       };
 
       // First call should succeed
@@ -257,6 +264,8 @@ describe('LeagueService', () => {
       const input: CreateLeagueInputDTO = {
         name: 'New League',
         description: 'A new league',
+        visibility: 'public',
+        ownerId: 'owner-1',
       };
 
       // First call