integration tests

tests/integration/drivers/drivers-list-use-cases.integration.test.ts

@@ -1,281 +1,236 @@
 /**
- * Integration Test: Drivers List Use Case Orchestration
+ * Integration Test: GetDriversLeaderboardUseCase Orchestration
  * 
- * Tests the orchestration logic of drivers list-related Use Cases:
- * - GetDriversListUseCase: Retrieves list of drivers with search, filter, sort, pagination
- * - Validates that Use Cases correctly interact with their Ports (Repositories, Event Publishers)
+ * Tests the orchestration logic of GetDriversLeaderboardUseCase:
+ * - GetDriversLeaderboardUseCase: Retrieves list of drivers with rankings and statistics
+ * - Validates that Use Cases correctly interact with their Ports (Repositories, other Use Cases)
  * - Uses In-Memory adapters for fast, deterministic testing
  * 
  * Focus: Business logic orchestration, NOT UI rendering
  */
 
-import { describe, it, expect, beforeAll, afterAll, beforeEach } from 'vitest';
-import { InMemoryDriverRepository } from '../../../adapters/drivers/persistence/inmemory/InMemoryDriverRepository';
-import { InMemoryEventPublisher } from '../../../adapters/events/InMemoryEventPublisher';
-import { GetDriversListUseCase } from '../../../core/drivers/use-cases/GetDriversListUseCase';
-import { DriversListQuery } from '../../../core/drivers/ports/DriversListQuery';
+import { describe, it, expect, beforeAll, beforeEach } from 'vitest';
+import { InMemoryDriverRepository } from '../../../adapters/racing/persistence/inmemory/InMemoryDriverRepository';
+import { InMemoryDriverStatsRepository } from '../../../adapters/racing/persistence/inmemory/InMemoryDriverStatsRepository';
+import { GetDriversLeaderboardUseCase } from '../../../core/racing/application/use-cases/GetDriversLeaderboardUseCase';
+import { RankingUseCase } from '../../../core/racing/application/use-cases/RankingUseCase';
+import { DriverStatsUseCase } from '../../../core/racing/application/use-cases/DriverStatsUseCase';
+import { Driver } from '../../../core/racing/domain/entities/Driver';
+import { Logger } from '../../../core/shared/domain/Logger';
 
-describe('Drivers List Use Case Orchestration', () => {
+describe('GetDriversLeaderboardUseCase Orchestration', () => {
   let driverRepository: InMemoryDriverRepository;
-  let eventPublisher: InMemoryEventPublisher;
-  let getDriversListUseCase: GetDriversListUseCase;
+  let driverStatsRepository: InMemoryDriverStatsRepository;
+  let rankingUseCase: RankingUseCase;
+  let driverStatsUseCase: DriverStatsUseCase;
+  let getDriversLeaderboardUseCase: GetDriversLeaderboardUseCase;
+  let mockLogger: Logger;
 
   beforeAll(() => {
-    // TODO: Initialize In-Memory repositories and event publisher
-    // driverRepository = new InMemoryDriverRepository();
-    // eventPublisher = new InMemoryEventPublisher();
-    // getDriversListUseCase = new GetDriversListUseCase({
-    //   driverRepository,
-    //   eventPublisher,
-    // });
+    mockLogger = {
+      info: () => {},
+      debug: () => {},
+      warn: () => {},
+      error: () => {},
+    } as unknown as Logger;
+    
+    driverRepository = new InMemoryDriverRepository(mockLogger);
+    driverStatsRepository = new InMemoryDriverStatsRepository(mockLogger);
+    
+    // RankingUseCase and DriverStatsUseCase are dependencies of GetDriversLeaderboardUseCase
+    rankingUseCase = new RankingUseCase(
+      {} as any, // standingRepository not used in getAllDriverRankings
+      {} as any, // driverRepository not used in getAllDriverRankings
+      driverStatsRepository,
+      mockLogger
+    );
+    
+    driverStatsUseCase = new DriverStatsUseCase(
+      {} as any, // resultRepository not used in getDriverStats
+      {} as any, // standingRepository not used in getDriverStats
+      driverStatsRepository,
+      mockLogger
+    );
+
+    getDriversLeaderboardUseCase = new GetDriversLeaderboardUseCase(
+      driverRepository,
+      rankingUseCase,
+      driverStatsUseCase,
+      mockLogger
+    );
   });
 
   beforeEach(() => {
-    // TODO: Clear all In-Memory repositories before each test
-    // driverRepository.clear();
-    // eventPublisher.clear();
+    driverRepository.clear();
+    driverStatsRepository.clear();
   });
 
-  describe('GetDriversListUseCase - Success Path', () => {
+  describe('GetDriversLeaderboardUseCase - Success Path', () => {
     it('should retrieve complete list of drivers with all data', async () => {
-      // TODO: Implement test
       // Scenario: System has multiple drivers
-      // Given: 20 drivers exist with various data
-      // And: Each driver has name, avatar, rating, and rank
-      // When: GetDriversListUseCase.execute() is called with default parameters
+      // Given: 3 drivers exist with various data
+      const drivers = [
+        Driver.create({ id: 'd1', iracingId: '1', name: 'Driver 1', country: 'US' }),
+        Driver.create({ id: 'd2', iracingId: '2', name: 'Driver 2', country: 'UK' }),
+        Driver.create({ id: 'd3', iracingId: '3', name: 'Driver 3', country: 'DE' }),
+      ];
+      
+      for (const d of drivers) {
+        await driverRepository.create(d);
+      }
+
+      // And: Each driver has statistics
+      await driverStatsRepository.saveDriverStats('d1', {
+        rating: 2000,
+        totalRaces: 10,
+        wins: 2,
+        podiums: 5,
+        overallRank: 1,
+        safetyRating: 4.5,
+        sportsmanshipRating: 95,
+        dnfs: 0,
+        avgFinish: 3.5,
+        bestFinish: 1,
+        worstFinish: 10,
+        consistency: 85,
+        experienceLevel: 'pro'
+      });
+      await driverStatsRepository.saveDriverStats('d2', {
+        rating: 1800,
+        totalRaces: 8,
+        wins: 1,
+        podiums: 3,
+        overallRank: 2,
+        safetyRating: 4.0,
+        sportsmanshipRating: 90,
+        dnfs: 1,
+        avgFinish: 5.2,
+        bestFinish: 1,
+        worstFinish: 15,
+        consistency: 75,
+        experienceLevel: 'intermediate'
+      });
+      await driverStatsRepository.saveDriverStats('d3', {
+        rating: 1500,
+        totalRaces: 5,
+        wins: 0,
+        podiums: 1,
+        overallRank: 3,
+        safetyRating: 3.5,
+        sportsmanshipRating: 80,
+        dnfs: 0,
+        avgFinish: 8.0,
+        bestFinish: 3,
+        worstFinish: 12,
+        consistency: 65,
+        experienceLevel: 'rookie'
+      });
+
+      // When: GetDriversLeaderboardUseCase.execute() is called
+      const result = await getDriversLeaderboardUseCase.execute({});
+
       // Then: The result should contain all drivers
-      // And: Each driver should have name, avatar, rating, and rank
-      // And: Drivers should be sorted by rating (high to low) by default
-      // And: EventPublisher should emit DriversListAccessedEvent
+      expect(result.isOk()).toBe(true);
+      const leaderboard = result.unwrap();
+      
+      expect(leaderboard.items).toHaveLength(3);
+      expect(leaderboard.totalRaces).toBe(23);
+      expect(leaderboard.totalWins).toBe(3);
+      expect(leaderboard.activeCount).toBe(3);
+
+      // And: Drivers should be sorted by rating (high to low)
+      expect(leaderboard.items[0].driver.id).toBe('d1');
+      expect(leaderboard.items[1].driver.id).toBe('d2');
+      expect(leaderboard.items[2].driver.id).toBe('d3');
+      
+      expect(leaderboard.items[0].rating).toBe(2000);
+      expect(leaderboard.items[1].rating).toBe(1800);
+      expect(leaderboard.items[2].rating).toBe(1500);
     });
 
-    it('should retrieve drivers list with pagination', async () => {
-      // TODO: Implement test
-      // Scenario: System has many drivers requiring pagination
-      // Given: 50 drivers exist
-      // When: GetDriversListUseCase.execute() is called with page=1, limit=20
-      // Then: The result should contain 20 drivers
-      // And: The result should include pagination info (total, page, limit)
-      // And: EventPublisher should emit DriversListAccessedEvent
-    });
-
-    it('should retrieve drivers list with search filter', async () => {
-      // TODO: Implement test
-      // Scenario: User searches for drivers by name
-      // Given: 10 drivers exist with names containing "John"
-      // And: 5 drivers exist with names containing "Jane"
-      // When: GetDriversListUseCase.execute() is called with search="John"
-      // Then: The result should contain only drivers with "John" in name
-      // And: The result should not contain drivers with "Jane" in name
-      // And: EventPublisher should emit DriversListAccessedEvent
-    });
-
-    it('should retrieve drivers list with rating filter', async () => {
-      // TODO: Implement test
-      // Scenario: User filters drivers by rating range
-      // Given: 15 drivers exist with rating >= 4.0
-      // And: 10 drivers exist with rating < 4.0
-      // When: GetDriversListUseCase.execute() is called with minRating=4.0
-      // Then: The result should contain only drivers with rating >= 4.0
-      // And: The result should not contain drivers with rating < 4.0
-      // And: EventPublisher should emit DriversListAccessedEvent
-    });
-
-    it('should retrieve drivers list sorted by rating (high to low)', async () => {
-      // TODO: Implement test
-      // Scenario: User sorts drivers by rating
-      // Given: 10 drivers exist with various ratings
-      // When: GetDriversListUseCase.execute() is called with sortBy="rating", sortOrder="desc"
-      // Then: The result should be sorted by rating in descending order
-      // And: The highest rated driver should be first
-      // And: The lowest rated driver should be last
-      // And: EventPublisher should emit DriversListAccessedEvent
-    });
-
-    it('should retrieve drivers list sorted by name (A-Z)', async () => {
-      // TODO: Implement test
-      // Scenario: User sorts drivers by name
-      // Given: 10 drivers exist with various names
-      // When: GetDriversListUseCase.execute() is called with sortBy="name", sortOrder="asc"
-      // Then: The result should be sorted by name in alphabetical order
-      // And: EventPublisher should emit DriversListAccessedEvent
-    });
-
-    it('should retrieve drivers list with combined search and filter', async () => {
-      // TODO: Implement test
-      // Scenario: User applies multiple filters
-      // Given: 5 drivers exist with "John" in name and rating >= 4.0
-      // And: 3 drivers exist with "John" in name but rating < 4.0
-      // And: 2 drivers exist with "Jane" in name and rating >= 4.0
-      // When: GetDriversListUseCase.execute() is called with search="John", minRating=4.0
-      // Then: The result should contain only the 5 drivers with "John" and rating >= 4.0
-      // And: EventPublisher should emit DriversListAccessedEvent
-    });
-
-    it('should retrieve drivers list with combined search, filter, and sort', async () => {
-      // TODO: Implement test
-      // Scenario: User applies all available filters
-      // Given: 10 drivers exist with various names and ratings
-      // When: GetDriversListUseCase.execute() is called with search="D", minRating=3.0, sortBy="rating", sortOrder="desc", page=1, limit=5
-      // Then: The result should contain only drivers with "D" in name and rating >= 3.0
-      // And: The result should be sorted by rating (high to low)
-      // And: The result should contain at most 5 drivers
-      // And: EventPublisher should emit DriversListAccessedEvent
-    });
-  });
-
-  describe('GetDriversListUseCase - Edge Cases', () => {
     it('should handle empty drivers list', async () => {
-      // TODO: Implement test
       // Scenario: System has no registered drivers
       // Given: No drivers exist in the system
-      // When: GetDriversListUseCase.execute() is called
+      // When: GetDriversLeaderboardUseCase.execute() is called
+      const result = await getDriversLeaderboardUseCase.execute({});
+
       // Then: The result should contain an empty array
-      // And: The result should indicate no drivers found
-      // And: EventPublisher should emit DriversListAccessedEvent
+      expect(result.isOk()).toBe(true);
+      const leaderboard = result.unwrap();
+      expect(leaderboard.items).toHaveLength(0);
+      expect(leaderboard.totalRaces).toBe(0);
+      expect(leaderboard.totalWins).toBe(0);
+      expect(leaderboard.activeCount).toBe(0);
     });
 
-    it('should handle search with no matching results', async () => {
-      // TODO: Implement test
-      // Scenario: User searches for non-existent driver
-      // Given: 10 drivers exist
-      // When: GetDriversListUseCase.execute() is called with search="NonExistentDriver123"
-      // Then: The result should contain an empty array
-      // And: The result should indicate no drivers found
-      // And: EventPublisher should emit DriversListAccessedEvent
-    });
+    it('should correctly identify active drivers', async () => {
+      // Scenario: Some drivers have no races
+      // Given: 2 drivers exist, one with races, one without
+      await driverRepository.create(Driver.create({ id: 'active', iracingId: '1', name: 'Active', country: 'US' }));
+      await driverRepository.create(Driver.create({ id: 'inactive', iracingId: '2', name: 'Inactive', country: 'UK' }));
+      
+      await driverStatsRepository.saveDriverStats('active', {
+        rating: 1500,
+        totalRaces: 1,
+        wins: 0,
+        podiums: 0,
+        overallRank: 1,
+        safetyRating: 3.0,
+        sportsmanshipRating: 70,
+        dnfs: 0,
+        avgFinish: 10,
+        bestFinish: 10,
+        worstFinish: 10,
+        consistency: 50,
+        experienceLevel: 'rookie'
+      });
+      // No stats for inactive driver or totalRaces = 0
+      await driverStatsRepository.saveDriverStats('inactive', {
+        rating: 1000,
+        totalRaces: 0,
+        wins: 0,
+        podiums: 0,
+        overallRank: null,
+        safetyRating: 2.5,
+        sportsmanshipRating: 50,
+        dnfs: 0,
+        avgFinish: 0,
+        bestFinish: 0,
+        worstFinish: 0,
+        consistency: 0,
+        experienceLevel: 'rookie'
+      });
 
-    it('should handle filter with no matching results', async () => {
-      // TODO: Implement test
-      // Scenario: User filters with criteria that match no drivers
-      // Given: All drivers have rating < 5.0
-      // When: GetDriversListUseCase.execute() is called with minRating=5.0
-      // Then: The result should contain an empty array
-      // And: The result should indicate no drivers found
-      // And: EventPublisher should emit DriversListAccessedEvent
-    });
+      // When: GetDriversLeaderboardUseCase.execute() is called
+      const result = await getDriversLeaderboardUseCase.execute({});
 
-    it('should handle pagination beyond available results', async () => {
-      // TODO: Implement test
-      // Scenario: User requests page beyond available data
-      // Given: 15 drivers exist
-      // When: GetDriversListUseCase.execute() is called with page=10, limit=20
-      // Then: The result should contain an empty array
-      // And: The result should indicate no drivers found
-      // And: EventPublisher should emit DriversListAccessedEvent
-    });
-
-    it('should handle empty search string', async () => {
-      // TODO: Implement test
-      // Scenario: User clears search field
-      // Given: 10 drivers exist
-      // When: GetDriversListUseCase.execute() is called with search=""
-      // Then: The result should contain all drivers
-      // And: EventPublisher should emit DriversListAccessedEvent
-    });
-
-    it('should handle null or undefined filter values', async () => {
-      // TODO: Implement test
-      // Scenario: User provides null/undefined filter values
-      // Given: 10 drivers exist
-      // When: GetDriversListUseCase.execute() is called with minRating=null
-      // Then: The result should contain all drivers (filter should be ignored)
-      // And: EventPublisher should emit DriversListAccessedEvent
+      // Then: Only one driver should be active
+      const leaderboard = result.unwrap();
+      expect(leaderboard.activeCount).toBe(1);
+      expect(leaderboard.items.find(i => i.driver.id === 'active')?.isActive).toBe(true);
+      expect(leaderboard.items.find(i => i.driver.id === 'inactive')?.isActive).toBe(false);
     });
   });
 
-  describe('GetDriversListUseCase - Error Handling', () => {
-    it('should throw error when repository query fails', async () => {
-      // TODO: Implement test
+  describe('GetDriversLeaderboardUseCase - Error Handling', () => {
+    it('should handle repository errors gracefully', async () => {
       // Scenario: Repository throws error
       // Given: DriverRepository throws an error during query
-      // When: GetDriversListUseCase.execute() is called
-      // Then: Should propagate the error appropriately
-      // And: EventPublisher should NOT emit any events
-    });
+      const originalFindAll = driverRepository.findAll.bind(driverRepository);
+      driverRepository.findAll = async () => {
+        throw new Error('Repository error');
+      };
 
-    it('should throw error with invalid pagination parameters', async () => {
-      // TODO: Implement test
-      // Scenario: Invalid pagination parameters
-      // Given: Invalid parameters (e.g., negative page, zero limit)
-      // When: GetDriversListUseCase.execute() is called with invalid parameters
-      // Then: Should throw ValidationError
-      // And: EventPublisher should NOT emit any events
-    });
+      // When: GetDriversLeaderboardUseCase.execute() is called
+      const result = await getDriversLeaderboardUseCase.execute({});
 
-    it('should throw error with invalid filter parameters', async () => {
-      // TODO: Implement test
-      // Scenario: Invalid filter parameters
-      // Given: Invalid parameters (e.g., negative minRating)
-      // When: GetDriversListUseCase.execute() is called with invalid parameters
-      // Then: Should throw ValidationError
-      // And: EventPublisher should NOT emit any events
-    });
-  });
+      // Then: Should return a repository error
+      expect(result.isErr()).toBe(true);
+      const error = result.unwrapErr();
+      expect(error.code).toBe('REPOSITORY_ERROR');
 
-  describe('Drivers List Data Orchestration', () => {
-    it('should correctly calculate driver count information', async () => {
-      // TODO: Implement test
-      // Scenario: Driver count calculation
-      // Given: 25 drivers exist
-      // When: GetDriversListUseCase.execute() is called with page=1, limit=20
-      // Then: The result should show:
-      // - Total drivers: 25
-      // - Drivers on current page: 20
-      // - Total pages: 2
-      // - Current page: 1
-    });
-
-    it('should correctly format driver cards with consistent information', async () => {
-      // TODO: Implement test
-      // Scenario: Driver card formatting
-      // Given: 10 drivers exist
-      // When: GetDriversListUseCase.execute() is called
-      // Then: Each driver card should contain:
-      // - Driver ID (for navigation)
-      // - Driver name
-      // - Driver avatar URL
-      // - Driver rating (formatted as decimal)
-      // - Driver rank (formatted as ordinal, e.g., "1st", "2nd", "3rd")
-    });
-
-    it('should correctly handle search case-insensitivity', async () => {
-      // TODO: Implement test
-      // Scenario: Search is case-insensitive
-      // Given: Drivers exist with names "John Doe", "john smith", "JOHNathan"
-      // When: GetDriversListUseCase.execute() is called with search="john"
-      // Then: The result should contain all three drivers
-      // And: EventPublisher should emit DriversListAccessedEvent
-    });
-
-    it('should correctly handle search with partial matches', async () => {
-      // TODO: Implement test
-      // Scenario: Search matches partial names
-      // Given: Drivers exist with names "John Doe", "Jonathan", "Johnson"
-      // When: GetDriversListUseCase.execute() is called with search="John"
-      // Then: The result should contain all three drivers
-      // And: EventPublisher should emit DriversListAccessedEvent
-    });
-
-    it('should correctly handle multiple filter combinations', async () => {
-      // TODO: Implement test
-      // Scenario: Multiple filters applied together
-      // Given: 20 drivers exist with various names and ratings
-      // When: GetDriversListUseCase.execute() is called with search="D", minRating=3.5, sortBy="name", sortOrder="asc"
-      // Then: The result should:
-      // - Only contain drivers with "D" in name
-      // - Only contain drivers with rating >= 3.5
-      // - Be sorted alphabetically by name
-    });
-
-    it('should correctly handle pagination with filters', async () => {
-      // TODO: Implement test
-      // Scenario: Pagination with active filters
-      // Given: 30 drivers exist with "A" in name
-      // When: GetDriversListUseCase.execute() is called with search="A", page=2, limit=10
-      // Then: The result should contain drivers 11-20 (alphabetically sorted)
-      // And: The result should show total drivers: 30
-      // And: The result should show current page: 2
+      // Restore original method
+      driverRepository.findAll = originalFindAll;
     });
   });
 });