refactor use cases
This commit is contained in:
@@ -6,7 +6,6 @@ import {
|
||||
type UpdateLeagueMemberRoleErrorCode,
|
||||
} from './UpdateLeagueMemberRoleUseCase';
|
||||
import type { ILeagueMembershipRepository } from '../../domain/repositories/ILeagueMembershipRepository';
|
||||
import type { UseCaseOutputPort } from '@core/shared/application';
|
||||
import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
|
||||
|
||||
describe('UpdateLeagueMemberRoleUseCase', () => {
|
||||
@@ -25,11 +24,11 @@ describe('UpdateLeagueMemberRoleUseCase', () => {
|
||||
saveMembership: vi.fn().mockResolvedValue(undefined),
|
||||
} as unknown as ILeagueMembershipRepository;
|
||||
|
||||
const output: UseCaseOutputPort<UpdateLeagueMemberRoleResult> & { present: Mock } = {
|
||||
const output: { present: Mock } = {
|
||||
present: vi.fn(),
|
||||
};
|
||||
|
||||
const useCase = new UpdateLeagueMemberRoleUseCase(mockLeagueMembershipRepository, output);
|
||||
const useCase = new UpdateLeagueMemberRoleUseCase(mockLeagueMembershipRepository);
|
||||
|
||||
const input: UpdateLeagueMemberRoleInput = {
|
||||
leagueId: 'league-1',
|
||||
@@ -45,10 +44,7 @@ describe('UpdateLeagueMemberRoleUseCase', () => {
|
||||
expect(mockLeagueMembershipRepository.getLeagueMembers).toHaveBeenCalledWith('league-1');
|
||||
expect(mockLeagueMembershipRepository.saveMembership).toHaveBeenCalledTimes(1);
|
||||
|
||||
expect(output.present).toHaveBeenCalledTimes(1);
|
||||
const presented = (output.present as Mock).mock.calls[0]![0] as UpdateLeagueMemberRoleResult;
|
||||
|
||||
expect(presented.membership.id).toBe('league-1:driver-1');
|
||||
const presented = (expect(presented.membership.id).toBe('league-1:driver-1');
|
||||
expect(presented.membership.leagueId.toString()).toBe('league-1');
|
||||
expect(presented.membership.driverId.toString()).toBe('driver-1');
|
||||
expect(presented.membership.role.toString()).toBe('admin');
|
||||
@@ -59,11 +55,11 @@ describe('UpdateLeagueMemberRoleUseCase', () => {
|
||||
getLeagueMembers: vi.fn().mockResolvedValue([]),
|
||||
} as unknown as ILeagueMembershipRepository;
|
||||
|
||||
const output: UseCaseOutputPort<UpdateLeagueMemberRoleResult> & { present: Mock } = {
|
||||
const output: { present: Mock } = {
|
||||
present: vi.fn(),
|
||||
};
|
||||
|
||||
const useCase = new UpdateLeagueMemberRoleUseCase(mockLeagueMembershipRepository, output);
|
||||
const useCase = new UpdateLeagueMemberRoleUseCase(mockLeagueMembershipRepository);
|
||||
|
||||
const input: UpdateLeagueMemberRoleInput = {
|
||||
leagueId: 'league-1',
|
||||
@@ -81,8 +77,7 @@ describe('UpdateLeagueMemberRoleUseCase', () => {
|
||||
|
||||
expect(error.code).toBe('MEMBERSHIP_NOT_FOUND');
|
||||
expect(error.details.message).toBe('League membership not found');
|
||||
expect(output.present).not.toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
|
||||
it('handles repository errors', async () => {
|
||||
const mockLeagueMembershipRepository = {
|
||||
@@ -91,11 +86,11 @@ describe('UpdateLeagueMemberRoleUseCase', () => {
|
||||
.mockRejectedValue(new Error('Database connection failed')),
|
||||
} as unknown as ILeagueMembershipRepository;
|
||||
|
||||
const output: UseCaseOutputPort<UpdateLeagueMemberRoleResult> & { present: Mock } = {
|
||||
const output: { present: Mock } = {
|
||||
present: vi.fn(),
|
||||
};
|
||||
|
||||
const useCase = new UpdateLeagueMemberRoleUseCase(mockLeagueMembershipRepository, output);
|
||||
const useCase = new UpdateLeagueMemberRoleUseCase(mockLeagueMembershipRepository);
|
||||
|
||||
const input: UpdateLeagueMemberRoleInput = {
|
||||
leagueId: 'league-1',
|
||||
@@ -113,8 +108,7 @@ describe('UpdateLeagueMemberRoleUseCase', () => {
|
||||
|
||||
expect(error.code).toBe('REPOSITORY_ERROR');
|
||||
expect(error.details.message).toBe('Database connection failed');
|
||||
expect(output.present).not.toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
|
||||
it('rejects invalid roles', async () => {
|
||||
const mockMembership = {
|
||||
@@ -131,11 +125,11 @@ describe('UpdateLeagueMemberRoleUseCase', () => {
|
||||
saveMembership: vi.fn().mockResolvedValue(undefined),
|
||||
} as unknown as ILeagueMembershipRepository;
|
||||
|
||||
const output: UseCaseOutputPort<UpdateLeagueMemberRoleResult> & { present: Mock } = {
|
||||
const output: { present: Mock } = {
|
||||
present: vi.fn(),
|
||||
};
|
||||
|
||||
const useCase = new UpdateLeagueMemberRoleUseCase(mockLeagueMembershipRepository, output);
|
||||
const useCase = new UpdateLeagueMemberRoleUseCase(mockLeagueMembershipRepository);
|
||||
|
||||
const result = await useCase.execute({
|
||||
leagueId: 'league-1',
|
||||
@@ -150,7 +144,6 @@ describe('UpdateLeagueMemberRoleUseCase', () => {
|
||||
>;
|
||||
|
||||
expect(error.code).toBe('INVALID_ROLE');
|
||||
expect(output.present).not.toHaveBeenCalled();
|
||||
expect(mockLeagueMembershipRepository.saveMembership).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
@@ -169,11 +162,11 @@ describe('UpdateLeagueMemberRoleUseCase', () => {
|
||||
saveMembership: vi.fn().mockResolvedValue(undefined),
|
||||
} as unknown as ILeagueMembershipRepository;
|
||||
|
||||
const output: UseCaseOutputPort<UpdateLeagueMemberRoleResult> & { present: Mock } = {
|
||||
const output: { present: Mock } = {
|
||||
present: vi.fn(),
|
||||
};
|
||||
|
||||
const useCase = new UpdateLeagueMemberRoleUseCase(mockLeagueMembershipRepository, output);
|
||||
const useCase = new UpdateLeagueMemberRoleUseCase(mockLeagueMembershipRepository);
|
||||
|
||||
const result = await useCase.execute({
|
||||
leagueId: 'league-1',
|
||||
@@ -188,7 +181,6 @@ describe('UpdateLeagueMemberRoleUseCase', () => {
|
||||
>;
|
||||
|
||||
expect(error.code).toBe('CANNOT_DOWNGRADE_LAST_OWNER');
|
||||
expect(output.present).not.toHaveBeenCalled();
|
||||
expect(mockLeagueMembershipRepository.saveMembership).not.toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user