refactor use cases

core/racing/application/use-cases/RequestProtestDefenseUseCase.test.ts

@@ -8,7 +8,6 @@ import {
 import type { IProtestRepository } from '../../domain/repositories/IProtestRepository';
 import type { IRaceRepository } from '../../domain/repositories/IRaceRepository';
 import type { ILeagueMembershipRepository } from '../../domain/repositories/ILeagueMembershipRepository';
-import type { UseCaseOutputPort } from '@core/shared/application';
 import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
 import { Result } from '@core/shared/application/Result';
 import type { Logger } from '@core/shared/application/Logger';
@@ -19,8 +18,6 @@ describe('RequestProtestDefenseUseCase', () => {
   let raceRepository: { findById: Mock };
   let membershipRepository: { getMembership: Mock };
   let logger: Logger;
-  let output: UseCaseOutputPort<RequestProtestDefenseResult> & { present: Mock };
-
   beforeEach(() => {
     protestRepository = { findById: vi.fn(), update: vi.fn() };
     raceRepository = { findById: vi.fn() };
@@ -31,15 +28,10 @@ describe('RequestProtestDefenseUseCase', () => {
       warn: vi.fn(),
       error: vi.fn(),
     };
-    output = { present: vi.fn() } as unknown as UseCaseOutputPort<RequestProtestDefenseResult> & { present: Mock };
-
-    useCase = new RequestProtestDefenseUseCase(
-      protestRepository as unknown as IProtestRepository,
+    useCase = new RequestProtestDefenseUseCase(protestRepository as unknown as IProtestRepository,
       raceRepository as unknown as IRaceRepository,
       membershipRepository as unknown as ILeagueMembershipRepository,
-      logger,
-      output,
-    );
+      logger);
   });
 
   const createInput = (overrides: Partial<RequestProtestDefenseInput> = {}): RequestProtestDefenseInput => ({
@@ -63,8 +55,7 @@ describe('RequestProtestDefenseUseCase', () => {
     const error = unwrapError(result);
     expect(error.code).toBe('PROTEST_NOT_FOUND');
     expect(error.details?.message).toBe('Protest not found');
-    expect(output.present).not.toHaveBeenCalled();
-  });
+    });
 
   it('should return race not found error', async () => {
     const mockProtest = {
@@ -81,8 +72,7 @@ describe('RequestProtestDefenseUseCase', () => {
     const error = unwrapError(result);
     expect(error.code).toBe('RACE_NOT_FOUND');
     expect(error.details?.message).toBe('Race not found');
-    expect(output.present).not.toHaveBeenCalled();
-  });
+    });
 
   it('should return insufficient permissions error', async () => {
     const mockProtest = {
@@ -101,8 +91,7 @@ describe('RequestProtestDefenseUseCase', () => {
     const error = unwrapError(result);
     expect(error.code).toBe('INSUFFICIENT_PERMISSIONS');
     expect(error.details?.message).toBe('Insufficient permissions to request defense');
-    expect(output.present).not.toHaveBeenCalled();
-  });
+    });
 
   it('should return defense cannot be requested error', async () => {
     const mockProtest = {
@@ -122,8 +111,7 @@ describe('RequestProtestDefenseUseCase', () => {
     const error = unwrapError(result);
     expect(error.code).toBe('DEFENSE_CANNOT_BE_REQUESTED');
     expect(error.details?.message).toBe('Defense cannot be requested for this protest');
-    expect(output.present).not.toHaveBeenCalled();
-  });
+    });
 
   it('should request defense successfully', async () => {
     const updatedProtest = {};
@@ -148,9 +136,7 @@ describe('RequestProtestDefenseUseCase', () => {
 
     expect(protestRepository.update).toHaveBeenCalledWith(updatedProtest);
 
-    expect(output.present).toHaveBeenCalledTimes(1);
-    const presentedRaw = output.present.mock.calls[0]?.[0];
-    expect(presentedRaw).toBeDefined();
+    const presentedRaw = expect(presentedRaw).toBeDefined();
     const presented = presentedRaw as RequestProtestDefenseResult;
     expect(presented).toEqual({
       leagueId: 'league-1',
@@ -169,7 +155,6 @@ describe('RequestProtestDefenseUseCase', () => {
     const error = unwrapError(result);
     expect(error.code).toBe('REPOSITORY_ERROR');
     expect(error.details?.message).toBe('Repository failed');
-    expect(output.present).not.toHaveBeenCalled();
     expect(logger.error).toHaveBeenCalled();
   });
 });