refactor use cases

core/racing/application/use-cases/RejectTeamJoinRequestUseCase.test.ts

@@ -7,7 +7,6 @@ import {
 } from './RejectTeamJoinRequestUseCase';
 import type { ITeamMembershipRepository } from '../../domain/repositories/ITeamMembershipRepository';
 import type { ITeamRepository } from '../../domain/repositories/ITeamRepository';
-import type { Logger, UseCaseOutputPort } from '@core/shared/application';
 import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
 
 interface TeamRepositoryMock {
@@ -24,7 +23,6 @@ describe('RejectTeamJoinRequestUseCase', () => {
   let teamRepository: TeamRepositoryMock;
   let membershipRepository: TeamMembershipRepositoryMock;
   let logger: Logger & { info: Mock; warn: Mock; error: Mock; debug: Mock };
-  let output: UseCaseOutputPort<RejectTeamJoinRequestResult> & { present: Mock };
   let useCase: RejectTeamJoinRequestUseCase;
 
   beforeEach(() => {
@@ -45,16 +43,9 @@ describe('RejectTeamJoinRequestUseCase', () => {
       error: vi.fn(),
     } as unknown as Logger & { info: Mock; warn: Mock; error: Mock; debug: Mock };
 
-    output = {
-      present: vi.fn(),
-    } as unknown as UseCaseOutputPort<RejectTeamJoinRequestResult> & { present: Mock };
-
-    useCase = new RejectTeamJoinRequestUseCase(
-      teamRepository as unknown as ITeamRepository,
+    useCase = new RejectTeamJoinRequestUseCase(teamRepository as unknown as ITeamRepository,
       membershipRepository as unknown as ITeamMembershipRepository,
-      logger,
-      output,
-    );
+      logger);
   });
 
   it('rejects a pending join request successfully and presents result', async () => {
@@ -88,9 +79,7 @@ describe('RejectTeamJoinRequestUseCase', () => {
 
     expect(result.isOk()).toBe(true);
     expect(result.unwrap()).toBeUndefined();
-    expect(output.present).toHaveBeenCalledTimes(1);
-    const presented = output.present.mock.calls[0]![0] as RejectTeamJoinRequestResult;
-    expect(presented.teamId).toBe('team-1');
+    const presented = expect(presented.teamId).toBe('team-1');
     expect(presented.requestId).toBe('req-1');
     expect(presented.status).toBe('rejected');
     expect(membershipRepository.removeJoinRequest).toHaveBeenCalledWith('req-1');
@@ -113,7 +102,6 @@ describe('RejectTeamJoinRequestUseCase', () => {
       { message: string }
     >;
     expect(err.code).toBe('TEAM_NOT_FOUND');
-    expect(output.present).not.toHaveBeenCalled();
     expect(membershipRepository.removeJoinRequest).not.toHaveBeenCalled();
   });
 
@@ -135,7 +123,6 @@ describe('RejectTeamJoinRequestUseCase', () => {
       { message: string }
     >;
     expect(err.code).toBe('UNAUTHORIZED');
-    expect(output.present).not.toHaveBeenCalled();
     expect(membershipRepository.removeJoinRequest).not.toHaveBeenCalled();
   });
 
@@ -164,7 +151,6 @@ describe('RejectTeamJoinRequestUseCase', () => {
       { message: string }
     >;
     expect(err.code).toBe('REQUEST_NOT_FOUND');
-    expect(output.present).not.toHaveBeenCalled();
     expect(membershipRepository.removeJoinRequest).not.toHaveBeenCalled();
   });
 
@@ -202,7 +188,6 @@ describe('RejectTeamJoinRequestUseCase', () => {
       { message: string }
     >;
     expect(err.code).toBe('INVALID_REQUEST_STATE');
-    expect(output.present).not.toHaveBeenCalled();
     expect(membershipRepository.removeJoinRequest).not.toHaveBeenCalled();
   });
 
@@ -225,7 +210,6 @@ describe('RejectTeamJoinRequestUseCase', () => {
     >;
     expect(err.code).toBe('REPOSITORY_ERROR');
     expect(err.details.message).toBe('Repository failure');
-    expect(output.present).not.toHaveBeenCalled();
     expect(membershipRepository.removeJoinRequest).not.toHaveBeenCalled();
   });
 });