refactor use cases

core/racing/application/use-cases/RegisterForRaceUseCase.test.ts

@@ -7,7 +7,6 @@ import {
 } from './RegisterForRaceUseCase';
 import type { IRaceRegistrationRepository } from '../../domain/repositories/IRaceRegistrationRepository';
 import type { ILeagueMembershipRepository } from '../../domain/repositories/ILeagueMembershipRepository';
-import type { Logger, UseCaseOutputPort } from '@core/shared/application';
 import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
 import { Result } from '@core/shared/application/Result';
 
@@ -16,20 +15,13 @@ describe('RegisterForRaceUseCase', () => {
   let registrationRepository: { isRegistered: Mock; register: Mock };
   let membershipRepository: { getMembership: Mock };
   let logger: { debug: Mock; warn: Mock; error: Mock; info: Mock };
-  let output: UseCaseOutputPort<RegisterForRaceResult> & { present: Mock };
-
   beforeEach(() => {
     registrationRepository = { isRegistered: vi.fn(), register: vi.fn() };
     membershipRepository = { getMembership: vi.fn() };
     logger = { debug: vi.fn(), warn: vi.fn(), error: vi.fn(), info: vi.fn() };
-    output = { present: vi.fn() } as unknown as UseCaseOutputPort<RegisterForRaceResult> & { present: Mock };
-
-    useCase = new RegisterForRaceUseCase(
-      registrationRepository as unknown as IRaceRegistrationRepository,
+    useCase = new RegisterForRaceUseCase(registrationRepository as unknown as IRaceRegistrationRepository,
       membershipRepository as unknown as ILeagueMembershipRepository,
-      logger as unknown as Logger,
-      output,
-    );
+      logger as unknown as Logger);
   });
 
   const buildInput = (overrides: Partial<RegisterForRaceInput> = {}): RegisterForRaceInput => ({
@@ -60,8 +52,7 @@ describe('RegisterForRaceUseCase', () => {
     const error = unwrapErr(result);
     expect(error.code).toBe('ALREADY_REGISTERED');
     expect(error.details.message).toBe('Already registered for this race');
-    expect(output.present).not.toHaveBeenCalled();
-  });
+    });
 
   it('returns not active member error when membership is missing', async () => {
     registrationRepository.isRegistered.mockResolvedValue(false);
@@ -73,8 +64,7 @@ describe('RegisterForRaceUseCase', () => {
     const error = unwrapErr(result);
     expect(error.code).toBe('NOT_ACTIVE_MEMBER');
     expect(error.details.message).toBe('Must be an active league member to register for races');
-    expect(output.present).not.toHaveBeenCalled();
-  });
+    });
 
   it('returns not active member error for inactive membership', async () => {
     registrationRepository.isRegistered.mockResolvedValue(false);
@@ -86,8 +76,7 @@ describe('RegisterForRaceUseCase', () => {
     const error = unwrapErr(result);
     expect(error.code).toBe('NOT_ACTIVE_MEMBER');
     expect(error.details.message).toBe('Must be an active league member to register for races');
-    expect(output.present).not.toHaveBeenCalled();
-  });
+    });
 
   it('registers successfully and presents result', async () => {
     registrationRepository.isRegistered.mockResolvedValue(false);
@@ -99,9 +88,7 @@ describe('RegisterForRaceUseCase', () => {
     expect(result.isOk()).toBe(true);
     expect(result.unwrap()).toBeUndefined();
 
-    expect(output.present).toHaveBeenCalledTimes(1);
-    const presentedRaw = output.present.mock.calls[0]?.[0];
-    expect(presentedRaw).toBeDefined();
+    const presentedRaw = expect(presentedRaw).toBeDefined();
     const presented = presentedRaw as RegisterForRaceResult;
     expect(presented).toEqual<RegisterForRaceResult>({
       raceId: 'race-1',
@@ -120,6 +107,5 @@ describe('RegisterForRaceUseCase', () => {
     const err = unwrapErr(result);
     expect(err.code).toBe('REPOSITORY_ERROR');
     expect(err.details.message).toBe('db is down');
-    expect(output.present).not.toHaveBeenCalled();
-  });
+    });
 });