refactor use cases

core/racing/application/use-cases/QuickPenaltyUseCase.test.ts

@@ -3,9 +3,8 @@ import { QuickPenaltyUseCase, type QuickPenaltyInput, type QuickPenaltyResult, t
 import type { IPenaltyRepository } from '../../domain/repositories/IPenaltyRepository';
 import type { IRaceRepository } from '../../domain/repositories/IRaceRepository';
 import type { ILeagueMembershipRepository } from '../../domain/repositories/ILeagueMembershipRepository';
-import type { Logger, UseCaseOutputPort } from '@core/shared/application';
 import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
-
+import type { Logger } from '@core/shared/application';
 
 describe('QuickPenaltyUseCase', () => {
   let useCase: QuickPenaltyUseCase;
@@ -24,7 +23,6 @@ describe('QuickPenaltyUseCase', () => {
     warn: Mock;
     error: Mock;
   };
-  let output: (UseCaseOutputPort<QuickPenaltyResult> & { present: Mock });
 
   beforeEach(() => {
     penaltyRepository = {
@@ -42,18 +40,12 @@ describe('QuickPenaltyUseCase', () => {
       warn: vi.fn(),
       error: vi.fn(),
     };
-    output = {
-      present: vi.fn(),
-    } as unknown as UseCaseOutputPort<QuickPenaltyResult> & { present: Mock };
-
-    useCase = new QuickPenaltyUseCase(
-      penaltyRepository as unknown as IPenaltyRepository,
+    useCase = new QuickPenaltyUseCase(penaltyRepository as unknown as IPenaltyRepository,
       raceRepository as unknown as IRaceRepository,
       leagueMembershipRepository as unknown as ILeagueMembershipRepository,
-      logger as unknown as Logger,
-      output,
-    );
+      logger as unknown as Logger);
   });
+
   it('should apply penalty successfully', async () => {
     const input: QuickPenaltyInput = {
       raceId: 'race-1',
@@ -73,14 +65,11 @@ describe('QuickPenaltyUseCase', () => {
     const result = await useCase.execute(input);
 
     expect(result.isOk()).toBe(true);
-    expect(result.unwrap()).toBeUndefined();
-    expect(output.present).toHaveBeenCalledTimes(1);
-
-    const presented = output.present.mock.calls[0]![0] as QuickPenaltyResult;
-    expect(presented.raceId).toBe('race-1');
-    expect(presented.driverId).toBe('driver-1');
-    expect(presented.penaltyId).toBeDefined();
-    expect(presented.type).toBeDefined();
+    const penaltyResult = result.unwrap();
+    expect(penaltyResult.raceId).toBe('race-1');
+    expect(penaltyResult.driverId).toBe('driver-1');
+    expect(penaltyResult.penaltyId).toBeDefined();
+    expect(penaltyResult.type).toBeDefined();
   });
 
   it('should return error when race not found', async () => {
@@ -102,7 +91,6 @@ describe('QuickPenaltyUseCase', () => {
       code: 'RACE_NOT_FOUND',
       details: { message: 'Race not found' },
     });
-    expect(output.present).not.toHaveBeenCalled();
   });
 
   it('should return error when admin unauthorized', async () => {
@@ -127,7 +115,6 @@ describe('QuickPenaltyUseCase', () => {
       code: 'UNAUTHORIZED',
       details: { message: 'Only league owners and admins can issue penalties' },
     });
-    expect(output.present).not.toHaveBeenCalled();
   });
 
   it('should handle other infraction type', async () => {
@@ -148,7 +135,8 @@ describe('QuickPenaltyUseCase', () => {
     const result = await useCase.execute(input);
 
     expect(result.isOk()).toBe(true);
-    expect(result.unwrap()).toBeUndefined();
-    expect(output.present).toHaveBeenCalledTimes(1);
+    const penaltyResult = result.unwrap();
+    expect(penaltyResult.raceId).toBe('race-1');
+    expect(penaltyResult.driverId).toBe('driver-1');
   });
-});
+});