refactor use cases

core/racing/application/use-cases/JoinTeamUseCase.test.ts

@@ -7,26 +7,19 @@ import {
 } from './JoinTeamUseCase';
 import type { ITeamRepository } from '../../domain/repositories/ITeamRepository';
 import type { ITeamMembershipRepository } from '../../domain/repositories/ITeamMembershipRepository';
-import type { Logger, UseCaseOutputPort } from '@core/shared/application';
+import type { Logger } from '@core/shared/application';
+import { Team } from '../../domain/entities/Team';
 import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
 
 describe('JoinTeamUseCase', () => {
   let useCase: JoinTeamUseCase;
-  let teamRepository: {
-    findById: Mock;
-  };
+  let teamRepository: { findById: Mock };
   let membershipRepository: {
     getActiveMembershipForDriver: Mock;
     getMembership: Mock;
     saveMembership: Mock;
   };
-  let logger: {
-    debug: Mock;
-    info: Mock;
-    warn: Mock;
-    error: Mock;
-  };
-  let output: UseCaseOutputPort<JoinTeamResult> & { present: Mock };
+  let logger: Logger & { debug: Mock; warn: Mock; error: Mock; info: Mock };
 
   beforeEach(() => {
     teamRepository = {
@@ -39,100 +32,84 @@ describe('JoinTeamUseCase', () => {
     };
     logger = {
       debug: vi.fn(),
-      info: vi.fn(),
       warn: vi.fn(),
       error: vi.fn(),
+      info: vi.fn(),
     };
-    output = {
-      present: vi.fn(),
-    } as unknown as UseCaseOutputPort<JoinTeamResult> & { present: Mock };
 
     useCase = new JoinTeamUseCase(
       teamRepository as unknown as ITeamRepository,
       membershipRepository as unknown as ITeamMembershipRepository,
-      logger as unknown as Logger,
-      output,
+      logger,
     );
   });
 
-  it('should join team successfully', async () => {
+  it('should successfully join a team', async () => {
     const input: JoinTeamInput = { teamId: 'team-1', driverId: 'driver-1' };
+    const team = Team.create({ id: 'team-1', name: 'Test Team', ownerId: 'owner-1' });
+    const membership = {
+      teamId: 'team-1',
+      driverId: 'driver-1',
+      role: 'driver' as const,
+      status: 'active' as const,
+      joinedAt: new Date(),
+    };
 
     membershipRepository.getActiveMembershipForDriver.mockResolvedValue(null);
     membershipRepository.getMembership.mockResolvedValue(null);
-    teamRepository.findById.mockResolvedValue({ id: 'team-1' });
-    membershipRepository.saveMembership.mockResolvedValue({
-      teamId: 'team-1',
-      driverId: 'driver-1',
-      role: 'driver',
-      status: 'active',
-      joinedAt: new Date(),
-    });
+    teamRepository.findById.mockResolvedValue(team);
+    membershipRepository.saveMembership.mockResolvedValue(membership);
 
     const result = await useCase.execute(input);
 
     expect(result.isOk()).toBe(true);
-    expect(result.unwrap()).toBeUndefined();
-    expect(output.present).toHaveBeenCalledTimes(1);
-
-    const presented = output.present.mock.calls[0]![0] as JoinTeamResult;
-    expect(presented.team.id).toBe('team-1');
-    expect(presented.membership.teamId).toBe('team-1');
-    expect(presented.membership.driverId).toBe('driver-1');
-    expect(presented.membership.role).toBe('driver');
-    expect(presented.membership.status).toBe('active');
+    const successResult = result.unwrap();
+    expect(successResult.team).toBe(team);
+    expect(successResult.membership).toBe(membership);
   });
 
-  it('should return error when driver already in a team', async () => {
+  it('should return ALREADY_IN_TEAM error when driver already has active membership', async () => {
     const input: JoinTeamInput = { teamId: 'team-1', driverId: 'driver-1' };
-
-    membershipRepository.getActiveMembershipForDriver.mockResolvedValue({
+    const existingMembership = {
       teamId: 'team-2',
       driverId: 'driver-1',
-      role: 'driver',
-      status: 'active',
+      role: 'driver' as const,
+      status: 'active' as const,
       joinedAt: new Date(),
-    });
+    };
+
+    membershipRepository.getActiveMembershipForDriver.mockResolvedValue(existingMembership);
 
     const result = await useCase.execute(input);
 
     expect(result.isErr()).toBe(true);
-    const err = result.unwrapErr() as ApplicationErrorCode<
-      JoinTeamErrorCode,
-      { message: string }
-    >;
+    const err = result.unwrapErr() as ApplicationErrorCode<JoinTeamErrorCode, { message: string }>;
     expect(err.code).toBe('ALREADY_IN_TEAM');
     expect(err.details.message).toBe('Driver already belongs to a team');
-    expect(output.present).not.toHaveBeenCalled();
   });
 
-  it('should return error when already a member', async () => {
+  it('should return ALREADY_MEMBER error when membership already exists', async () => {
     const input: JoinTeamInput = { teamId: 'team-1', driverId: 'driver-1' };
-
-    membershipRepository.getActiveMembershipForDriver.mockResolvedValue(null);
-    membershipRepository.getMembership.mockResolvedValue({
+    const existingMembership = {
       teamId: 'team-1',
       driverId: 'driver-1',
-      role: 'driver',
-      status: 'pending',
+      role: 'driver' as const,
+      status: 'pending' as const,
       joinedAt: new Date(),
-    });
+    };
+
+    membershipRepository.getActiveMembershipForDriver.mockResolvedValue(null);
+    membershipRepository.getMembership.mockResolvedValue(existingMembership);
 
     const result = await useCase.execute(input);
 
     expect(result.isErr()).toBe(true);
-    const err = result.unwrapErr() as ApplicationErrorCode<
-      JoinTeamErrorCode,
-      { message: string }
-    >;
+    const err = result.unwrapErr() as ApplicationErrorCode<JoinTeamErrorCode, { message: string }>;
     expect(err.code).toBe('ALREADY_MEMBER');
-    expect(err.details.message).toBe(
-      'Already a member or have a pending request',
-    );
-    expect(output.present).not.toHaveBeenCalled();
+    expect(err.details.message).toBe('Already a member or have a pending request');
   });
 
-  it('should return error when team not found', async () => {
+  it('should return TEAM_NOT_FOUND error when team does not exist', async () => {
     const input: JoinTeamInput = { teamId: 'team-1', driverId: 'driver-1' };
 
     membershipRepository.getActiveMembershipForDriver.mockResolvedValue(null);
@@ -142,30 +119,22 @@ describe('JoinTeamUseCase', () => {
     const result = await useCase.execute(input);
 
     expect(result.isErr()).toBe(true);
-    const err = result.unwrapErr() as ApplicationErrorCode<
-      JoinTeamErrorCode,
-      { message: string }
-    >;
+    const err = result.unwrapErr() as ApplicationErrorCode<JoinTeamErrorCode, { message: string }>;
     expect(err.code).toBe('TEAM_NOT_FOUND');
     expect(err.details.message).toBe('Team team-1 not found');
-    expect(output.present).not.toHaveBeenCalled();
   });
 
-  it('should return error on repository failure', async () => {
+  it('should return REPOSITORY_ERROR when repository throws', async () => {
     const input: JoinTeamInput = { teamId: 'team-1', driverId: 'driver-1' };
-    const error = new Error('Repository error');
+    const error = new Error('Repository failure');
 
     membershipRepository.getActiveMembershipForDriver.mockRejectedValue(error);
 
     const result = await useCase.execute(input);
 
     expect(result.isErr()).toBe(true);
-    const err = result.unwrapErr() as ApplicationErrorCode<
-      JoinTeamErrorCode,
-      { message: string }
-    >;
+    const err = result.unwrapErr() as ApplicationErrorCode<JoinTeamErrorCode, { message: string }>;
     expect(err.code).toBe('REPOSITORY_ERROR');
-    expect(err.details.message).toBe('Repository error');
-    expect(output.present).not.toHaveBeenCalled();
+    expect(err.details.message).toBe('Repository failure');
   });
 });