refactor use cases

core/racing/application/use-cases/CreateSponsorUseCase.test.ts

@@ -2,7 +2,6 @@ import { describe, it, expect, beforeEach, vi, Mock } from 'vitest';
 import { CreateSponsorUseCase, type CreateSponsorInput } from './CreateSponsorUseCase';
 import type { ISponsorRepository } from '../../domain/repositories/ISponsorRepository';
 import type { Logger } from '@core/shared/application';
-import type { UseCaseOutputPort } from '@core/shared/application/UseCaseOutputPort';
 
 describe('CreateSponsorUseCase', () => {
   let useCase: CreateSponsorUseCase;
@@ -15,9 +14,6 @@ describe('CreateSponsorUseCase', () => {
     warn: Mock;
     error: Mock;
   };
-  let output: {
-    present: Mock;
-  };
 
   beforeEach(() => {
     sponsorRepository = {
@@ -29,13 +25,9 @@ describe('CreateSponsorUseCase', () => {
       warn: vi.fn(),
       error: vi.fn(),
     };
-    output = {
-      present: vi.fn(),
-    };
     useCase = new CreateSponsorUseCase(
       sponsorRepository as unknown as ISponsorRepository,
       logger as unknown as Logger,
-      output as unknown as UseCaseOutputPort<unknown>,
     );
   });
 
@@ -52,17 +44,13 @@ describe('CreateSponsorUseCase', () => {
     const result = await useCase.execute(input);
 
     expect(result.isOk()).toBe(true);
-    expect(result.unwrap()).toBeUndefined();
-    expect(output.present).toHaveBeenCalledTimes(1);
-    const presented = (output.present as Mock).mock.calls[0]?.[0];
-    expect(presented?.sponsor.id).toBeDefined();
-
-    const sponsor = presented!.sponsor;
-    expect(sponsor.name.toString()).toBe('Test Sponsor');
-    expect(sponsor.contactEmail.toString()).toBe('test@example.com');
-    expect(sponsor.websiteUrl?.toString()).toBe('https://example.com');
-    expect(sponsor.logoUrl?.toString()).toBe('https://example.com/logo.png');
-    expect(sponsor.createdAt.toDate()).toBeInstanceOf(Date);
+    const successResult = result.unwrap();
+    expect(successResult.sponsor.id).toBeDefined();
+    expect(successResult.sponsor.name.toString()).toBe('Test Sponsor');
+    expect(successResult.sponsor.contactEmail.toString()).toBe('test@example.com');
+    expect(successResult.sponsor.websiteUrl?.toString()).toBe('https://example.com');
+    expect(successResult.sponsor.logoUrl?.toString()).toBe('https://example.com/logo.png');
+    expect(successResult.sponsor.createdAt.toDate()).toBeInstanceOf(Date);
 
     expect(sponsorRepository.create).toHaveBeenCalledTimes(1);
   });
@@ -78,11 +66,9 @@ describe('CreateSponsorUseCase', () => {
     const result = await useCase.execute(input);
 
     expect(result.isOk()).toBe(true);
-    expect(result.unwrap()).toBeUndefined();
-    expect(output.present).toHaveBeenCalledTimes(1);
-    const presented = (output.present as Mock).mock.calls[0]?.[0];
-    expect(presented.sponsor.websiteUrl).toBeUndefined();
-    expect(presented.sponsor.logoUrl).toBeUndefined();
+    const successResult = result.unwrap();
+    expect(successResult.sponsor.websiteUrl).toBeUndefined();
+    expect(successResult.sponsor.logoUrl).toBeUndefined();
   });
 
   it('should return error when name is empty', async () => {
@@ -95,7 +81,6 @@ describe('CreateSponsorUseCase', () => {
 
     expect(result.isErr()).toBe(true);
     expect(result.unwrapErr().details.message).toBe('Sponsor name is required');
-    expect(output.present).not.toHaveBeenCalled();
   });
 
   it('should return error when contactEmail is empty', async () => {
@@ -108,7 +93,6 @@ describe('CreateSponsorUseCase', () => {
 
     expect(result.isErr()).toBe(true);
     expect(result.unwrapErr().details.message).toBe('Sponsor contact email is required');
-    expect(output.present).not.toHaveBeenCalled();
   });
 
   it('should return error when contactEmail is invalid', async () => {
@@ -121,7 +105,6 @@ describe('CreateSponsorUseCase', () => {
 
     expect(result.isErr()).toBe(true);
     expect(result.unwrapErr().details.message).toBe('Invalid sponsor contact email format');
-    expect(output.present).not.toHaveBeenCalled();
   });
 
   it('should return error when websiteUrl is invalid', async () => {
@@ -135,7 +118,6 @@ describe('CreateSponsorUseCase', () => {
 
     expect(result.isErr()).toBe(true);
     expect(result.unwrapErr().details.message).toBe('Invalid sponsor website URL');
-    expect(output.present).not.toHaveBeenCalled();
   });
 
   it('should return error when repository throws', async () => {
@@ -150,6 +132,5 @@ describe('CreateSponsorUseCase', () => {
 
     expect(result.isErr()).toBe(true);
     expect(result.unwrapErr().details.message).toBe('DB error');
-    expect(output.present).not.toHaveBeenCalled();
   });
-});
+});