refactor use cases

core/racing/application/use-cases/ApplyPenaltyUseCase.test.ts

@@ -4,9 +4,6 @@ import type { IPenaltyRepository } from '../../domain/repositories/IPenaltyRepos
 import type { IProtestRepository } from '../../domain/repositories/IProtestRepository';
 import type { IRaceRepository } from '../../domain/repositories/IRaceRepository';
 import type { ILeagueMembershipRepository } from '../../domain/repositories/ILeagueMembershipRepository';
-import type { Logger } from '@core/shared/application';
-import type { UseCaseOutputPort } from '@core/shared/application/UseCaseOutputPort';
-
 describe('ApplyPenaltyUseCase', () => {
   let mockPenaltyRepo: {
     create: Mock;
@@ -49,18 +46,15 @@ describe('ApplyPenaltyUseCase', () => {
   });
 
   it('should return error when race does not exist', async () => {
-    const output: UseCaseOutputPort<ApplyPenaltyResult> & { present: Mock } = {
+    const output: { present: Mock } = {
       present: vi.fn(),
     };
 
-    const useCase = new ApplyPenaltyUseCase(
-      mockPenaltyRepo as unknown as IPenaltyRepository,
+    const useCase = new ApplyPenaltyUseCase(mockPenaltyRepo as unknown as IPenaltyRepository,
       mockProtestRepo as unknown as IProtestRepository,
       mockRaceRepo as unknown as IRaceRepository,
       mockLeagueMembershipRepo as unknown as ILeagueMembershipRepository,
-      mockLogger as unknown as Logger,
-      output,
-    );
+      mockLogger as unknown as Logger);
 
     mockRaceRepo.findById.mockResolvedValue(null);
 
@@ -78,18 +72,15 @@ describe('ApplyPenaltyUseCase', () => {
   });
 
   it('should return error when steward does not have authority', async () => {
-    const output: UseCaseOutputPort<ApplyPenaltyResult> & { present: Mock } = {
+    const output: { present: Mock } = {
       present: vi.fn(),
     };
 
-    const useCase = new ApplyPenaltyUseCase(
-      mockPenaltyRepo as unknown as IPenaltyRepository,
+    const useCase = new ApplyPenaltyUseCase(mockPenaltyRepo as unknown as IPenaltyRepository,
       mockProtestRepo as unknown as IProtestRepository,
       mockRaceRepo as unknown as IRaceRepository,
       mockLeagueMembershipRepo as unknown as ILeagueMembershipRepository,
-      mockLogger as unknown as Logger,
-      output,
-    );
+      mockLogger as unknown as Logger);
 
     mockRaceRepo.findById.mockResolvedValue({ id: 'race1', leagueId: 'league1' });
 
@@ -115,18 +106,15 @@ describe('ApplyPenaltyUseCase', () => {
   });
 
   it('should return error when protest does not exist', async () => {
-    const output: UseCaseOutputPort<ApplyPenaltyResult> & { present: Mock } = {
+    const output: { present: Mock } = {
       present: vi.fn(),
     };
 
-    const useCase = new ApplyPenaltyUseCase(
-      mockPenaltyRepo as unknown as IPenaltyRepository,
+    const useCase = new ApplyPenaltyUseCase(mockPenaltyRepo as unknown as IPenaltyRepository,
       mockProtestRepo as unknown as IProtestRepository,
       mockRaceRepo as unknown as IRaceRepository,
       mockLeagueMembershipRepo as unknown as ILeagueMembershipRepository,
-      mockLogger as unknown as Logger,
-      output,
-    );
+      mockLogger as unknown as Logger);
 
     mockRaceRepo.findById.mockResolvedValue({ id: 'race1', leagueId: 'league1' });
 
@@ -154,18 +142,15 @@ describe('ApplyPenaltyUseCase', () => {
   });
 
   it('should return error when protest is not upheld', async () => {
-    const output: UseCaseOutputPort<ApplyPenaltyResult> & { present: Mock } = {
+    const output: { present: Mock } = {
       present: vi.fn(),
     };
 
-    const useCase = new ApplyPenaltyUseCase(
-      mockPenaltyRepo as unknown as IPenaltyRepository,
+    const useCase = new ApplyPenaltyUseCase(mockPenaltyRepo as unknown as IPenaltyRepository,
       mockProtestRepo as unknown as IProtestRepository,
       mockRaceRepo as unknown as IRaceRepository,
       mockLeagueMembershipRepo as unknown as ILeagueMembershipRepository,
-      mockLogger as unknown as Logger,
-      output,
-    );
+      mockLogger as unknown as Logger);
 
     mockRaceRepo.findById.mockResolvedValue({ id: 'race1', leagueId: 'league1' });
 
@@ -193,18 +178,15 @@ describe('ApplyPenaltyUseCase', () => {
   });
 
   it('should return error when protest is not for this race', async () => {
-    const output: UseCaseOutputPort<ApplyPenaltyResult> & { present: Mock } = {
+    const output: { present: Mock } = {
       present: vi.fn(),
     };
 
-    const useCase = new ApplyPenaltyUseCase(
-      mockPenaltyRepo as unknown as IPenaltyRepository,
+    const useCase = new ApplyPenaltyUseCase(mockPenaltyRepo as unknown as IPenaltyRepository,
       mockProtestRepo as unknown as IProtestRepository,
       mockRaceRepo as unknown as IRaceRepository,
       mockLeagueMembershipRepo as unknown as ILeagueMembershipRepository,
-      mockLogger as unknown as Logger,
-      output,
-    );
+      mockLogger as unknown as Logger);
 
     mockRaceRepo.findById.mockResolvedValue({ id: 'race1', leagueId: 'league1' });
 
@@ -232,18 +214,15 @@ describe('ApplyPenaltyUseCase', () => {
   });
 
   it('should create penalty and return result on success', async () => {
-    const output: UseCaseOutputPort<ApplyPenaltyResult> & { present: Mock } = {
+    const output: { present: Mock } = {
       present: vi.fn(),
     };
 
-    const useCase = new ApplyPenaltyUseCase(
-      mockPenaltyRepo as unknown as IPenaltyRepository,
+    const useCase = new ApplyPenaltyUseCase(mockPenaltyRepo as unknown as IPenaltyRepository,
       mockProtestRepo as unknown as IProtestRepository,
       mockRaceRepo as unknown as IRaceRepository,
       mockLeagueMembershipRepo as unknown as ILeagueMembershipRepository,
-      mockLogger as unknown as Logger,
-      output,
-    );
+      mockLogger as unknown as Logger);
 
     mockRaceRepo.findById.mockResolvedValue({ id: 'race1', leagueId: 'league1' });
 
@@ -269,9 +248,7 @@ describe('ApplyPenaltyUseCase', () => {
     expect(result.isOk()).toBe(true);
     expect(result.unwrap()).toBeUndefined();
 
-    expect(output.present).toHaveBeenCalledTimes(1);
-    const presented = (output.present as Mock).mock.calls[0]?.[0] as ApplyPenaltyResult;
-    expect(presented).toEqual({ penaltyId: expect.any(String) });
+    const presented = (expect(presented).toEqual({ penaltyId: expect.any(String) });
 
     expect(mockPenaltyRepo.create).toHaveBeenCalledTimes(1);
     const createdPenalty = (mockPenaltyRepo.create as Mock).mock.calls[0]?.[0] as unknown as {