mmintel/gridpilot.gg
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

refactor use cases

Browse Source
This commit is contained in:
Marc Mintel
2026-01-08 15:34:51 +01:00
parent d984ab24a8
commit 52e9a2f6a7
362 changed files with 5192 additions and 8409 deletions
Download Patch File Download Diff File Expand all files Collapse all files

143
core/ports/media/MediaResolverPort.test.ts
View File

@@ -9,11 +9,8 @@
*/
import { MediaReference } from '@core/domain/media/MediaReference';
// Mock interface for testing
interface MediaResolverPort {
resolve(ref: MediaReference, baseUrl: string): Promise<string | null>;
}
import { MediaResolverPort } from './MediaResolverPort';
import { vi, describe, it, expect, beforeEach } from 'vitest';
describe('MediaResolverPort', () => {
let mockResolver: MediaResolverPort;
@@ -21,15 +18,15 @@ describe('MediaResolverPort', () => {
beforeEach(() => {
// Create a mock implementation for testing
mockResolver = {
resolve: jest.fn(async (ref: MediaReference, baseUrl: string): Promise<string | null> => {
resolve: vi.fn(async (ref: MediaReference): Promise<string | null> => {
// Mock implementation that returns different URLs based on type
switch (ref.type) {
case 'system-default':
return `${baseUrl}/defaults/${ref.variant}`;
return `/defaults/${ref.variant}`;
case 'generated':
return `${baseUrl}/generated/${ref.generationRequestId}`;
return `/generated/${ref.generationRequestId}`;
case 'uploaded':
return `${baseUrl}/media/${ref.mediaId}`;
return `/media/${ref.mediaId}`;
case 'none':
return null;
default:
@@ -44,18 +41,16 @@ describe('MediaResolverPort', () => {
expect(typeof mockResolver.resolve).toBe('function');
});
it('should accept MediaReference and string parameters', async () => {
it('should accept MediaReference parameter', async () => {
const ref = MediaReference.createSystemDefault('avatar');
const baseUrl = 'https://api.example.com';
await expect(mockResolver.resolve(ref, baseUrl)).resolves.toBeDefined();
await expect(mockResolver.resolve(ref)).resolves.toBeDefined();
});
it('should return Promise<string | null>', async () => {
const ref = MediaReference.createSystemDefault('avatar');
const baseUrl = 'https://api.example.com';
const result = await mockResolver.resolve(ref, baseUrl);
const result = await mockResolver.resolve(ref);
expect(result === null || typeof result === 'string').toBe(true);
});
});
@@ -63,154 +58,83 @@ describe('MediaResolverPort', () => {
describe('System Default Resolution', () => {
it('should resolve system-default avatar to correct URL', async () => {
const ref = MediaReference.createSystemDefault('avatar');
const baseUrl = 'https://api.example.com';
const result = await mockResolver.resolve(ref, baseUrl);
const result = await mockResolver.resolve(ref);
expect(result).toBe('https://api.example.com/defaults/avatar');
expect(result).toBe('/defaults/avatar');
});
it('should resolve system-default logo to correct URL', async () => {
const ref = MediaReference.createSystemDefault('logo');
const baseUrl = 'https://api.example.com';
const result = await mockResolver.resolve(ref, baseUrl);
const result = await mockResolver.resolve(ref);
expect(result).toBe('https://api.example.com/defaults/logo');
expect(result).toBe('/defaults/logo');
});
});
describe('Generated Resolution', () => {
it('should resolve generated reference to correct URL', async () => {
const ref = MediaReference.createGenerated('req-123');
const baseUrl = 'https://api.example.com';
const result = await mockResolver.resolve(ref, baseUrl);
const result = await mockResolver.resolve(ref);
expect(result).toBe('https://api.example.com/generated/req-123');
expect(result).toBe('/generated/req-123');
});
it('should handle generated reference with special characters', async () => {
const ref = MediaReference.createGenerated('req-abc-123_XYZ');
const baseUrl = 'https://api.example.com';
const result = await mockResolver.resolve(ref, baseUrl);
const result = await mockResolver.resolve(ref);
expect(result).toBe('https://api.example.com/generated/req-abc-123_XYZ');
expect(result).toBe('/generated/req-abc-123_XYZ');
});
});
describe('Uploaded Resolution', () => {
it('should resolve uploaded reference to correct URL', async () => {
const ref = MediaReference.createUploaded('media-456');
const baseUrl = 'https://api.example.com';
const result = await mockResolver.resolve(ref, baseUrl);
const result = await mockResolver.resolve(ref);
expect(result).toBe('https://api.example.com/media/media-456');
expect(result).toBe('/media/media-456');
});
it('should handle uploaded reference with special characters', async () => {
const ref = MediaReference.createUploaded('media-abc-456_XYZ');
const baseUrl = 'https://api.example.com';
const result = await mockResolver.resolve(ref, baseUrl);
const result = await mockResolver.resolve(ref);
expect(result).toBe('https://api.example.com/media/media-abc-456_XYZ');
expect(result).toBe('/media/media-abc-456_XYZ');
});
});
describe('None Resolution', () => {
it('should resolve none reference to null', async () => {
const ref = MediaReference.createNone();
const baseUrl = 'https://api.example.com';
const result = await mockResolver.resolve(ref, baseUrl);
const result = await mockResolver.resolve(ref);
expect(result).toBeNull();
});
});
describe('Base URL Handling', () => {
it('should handle base URL without trailing slash', async () => {
const ref = MediaReference.createSystemDefault('avatar');
const baseUrl = 'https://api.example.com';
const result = await mockResolver.resolve(ref, baseUrl);
expect(result).toBe('https://api.example.com/defaults/avatar');
});
it('should handle base URL with trailing slash', async () => {
const ref = MediaReference.createSystemDefault('avatar');
const baseUrl = 'https://api.example.com/';
const result = await mockResolver.resolve(ref, baseUrl);
// Implementation should handle this consistently
expect(result).toBeTruthy();
});
it('should handle localhost URLs', async () => {
const ref = MediaReference.createSystemDefault('avatar');
const baseUrl = 'http://localhost:3000';
const result = await mockResolver.resolve(ref, baseUrl);
expect(result).toBe('http://localhost:3000/defaults/avatar');
});
it('should handle relative URLs', async () => {
const ref = MediaReference.createSystemDefault('avatar');
const baseUrl = '/api';
const result = await mockResolver.resolve(ref, baseUrl);
expect(result).toBe('/api/defaults/avatar');
});
});
describe('Error Handling', () => {
it('should handle null baseUrl gracefully', async () => {
const ref = MediaReference.createSystemDefault('avatar');
// This should not throw but handle gracefully
await expect(mockResolver.resolve(ref, null as any)).resolves.toBeDefined();
});
it('should handle empty baseUrl gracefully', async () => {
const ref = MediaReference.createSystemDefault('avatar');
// This should not throw but handle gracefully
await expect(mockResolver.resolve(ref, '')).resolves.toBeDefined();
});
it('should handle undefined baseUrl gracefully', async () => {
const ref = MediaReference.createSystemDefault('avatar');
// This should not throw but handle gracefully
await expect(mockResolver.resolve(ref, undefined as any)).resolves.toBeDefined();
});
});
describe('Edge Cases', () => {
it('should handle very long media IDs', async () => {
const longId = 'a'.repeat(1000);
const ref = MediaReference.createUploaded(longId);
const baseUrl = 'https://api.example.com';
const result = await mockResolver.resolve(ref, baseUrl);
const result = await mockResolver.resolve(ref);
expect(result).toBe(`https://api.example.com/media/${longId}`);
expect(result).toBe(`/media/${longId}`);
});
it('should handle Unicode characters in IDs', async () => {
const ref = MediaReference.createUploaded('media-日本語-123');
const baseUrl = 'https://api.example.com';
const result = await mockResolver.resolve(ref, baseUrl);
const result = await mockResolver.resolve(ref);
expect(result).toBe('https://api.example.com/media/media-日本語-123');
expect(result).toBe('/media/media-日本語-123');
});
it('should handle multiple calls with different references', async () => {
@@ -220,14 +144,13 @@ describe('MediaResolverPort', () => {
MediaReference.createUploaded('media-456'),
MediaReference.createNone()
];
const baseUrl = 'https://api.example.com';
const results = await Promise.all(refs.map(ref => mockResolver.resolve(ref, baseUrl)));
const results = await Promise.all(refs.map(ref => mockResolver.resolve(ref)));
expect(results).toEqual([
'https://api.example.com/defaults/avatar',
'https://api.example.com/generated/req-123',
'https://api.example.com/media/media-456',
'/defaults/avatar',
'/generated/req-123',
'/media/media-456',
null
]);
});
@@ -236,10 +159,9 @@ describe('MediaResolverPort', () => {
describe('Performance Considerations', () => {
it('should resolve quickly for simple cases', async () => {
const ref = MediaReference.createSystemDefault('avatar');
const baseUrl = 'https://api.example.com';
const start = Date.now();
await mockResolver.resolve(ref, baseUrl);
await mockResolver.resolve(ref);
const duration = Date.now() - start;
expect(duration).toBeLessThan(100); // Should be very fast
@@ -249,10 +171,9 @@ describe('MediaResolverPort', () => {
const refs = Array.from({ length: 100 }, (_, i) =>
MediaReference.createUploaded(`media-${i}`)
);
const baseUrl = 'https://api.example.com';
const start = Date.now();
const results = await Promise.all(refs.map(ref => mockResolver.resolve(ref, baseUrl)));
const results = await Promise.all(refs.map(ref => mockResolver.resolve(ref)));
const duration = Date.now() - start;
expect(results.length).toBe(100);