refactor use cases

core/media/application/use-cases/UploadMediaUseCase.test.ts

@@ -1,6 +1,6 @@
 import { describe, it, expect, vi, type Mock } from 'vitest';
 import { Readable } from 'node:stream';
-import type { Logger, UseCaseOutputPort } from '@core/shared/application';
+import type { Logger } from '@core/shared/application';
 import { Result } from '@core/shared/application/Result';
 import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
 import {
@@ -18,16 +18,10 @@ vi.mock('uuid', () => ({
   v4: () => 'media-1',
 }));
 
-interface TestOutputPort extends UseCaseOutputPort<UploadMediaResult> {
-  present: Mock;
-  result?: UploadMediaResult;
-}
-
 describe('UploadMediaUseCase', () => {
   let mediaRepo: { save: Mock };
   let mediaStorage: { uploadMedia: Mock };
   let logger: Logger;
-  let output: TestOutputPort;
   let useCase: UploadMediaUseCase;
 
   const baseFile: MulterFile = {
@@ -59,16 +53,9 @@ describe('UploadMediaUseCase', () => {
       error: vi.fn(),
     } as unknown as Logger;
 
-    output = {
-      present: vi.fn((result: UploadMediaResult) => {
-        output.result = result;
-      }),
-    } as unknown as TestOutputPort;
-
     useCase = new UploadMediaUseCase(
       mediaRepo as unknown as IMediaRepository,
       mediaStorage as unknown as MediaStoragePort,
-      output,
       logger,
     );
   });
@@ -80,7 +67,7 @@ describe('UploadMediaUseCase', () => {
     });
 
     const input: UploadMediaInput = { file: baseFile, uploadedBy: 'user-1' };
-    const result: Result<void, ApplicationErrorCode<UploadMediaErrorCode, { message: string }>> =
+    const result: Result<UploadMediaResult, ApplicationErrorCode<UploadMediaErrorCode, { message: string }>> =
       await useCase.execute(input);
 
     expect(result.isErr()).toBe(true);
@@ -89,10 +76,9 @@ describe('UploadMediaUseCase', () => {
     expect(err.details?.message).toBe('Upload error');
 
     expect(mediaRepo.save).not.toHaveBeenCalled();
-    expect(output.present).not.toHaveBeenCalled();
   });
 
-  it('creates media and presents mediaId/url on success (includes metadata)', async () => {
+  it('returns UploadMediaResult on success (includes metadata)', async () => {
     mediaStorage.uploadMedia.mockResolvedValue({
       success: true,
       url: 'https://example.com/media.png',
@@ -128,7 +114,8 @@ describe('UploadMediaUseCase', () => {
     expect(saved.uploadedBy).toBe('user-1');
     expect(saved.metadata).toEqual({ foo: 'bar' });
 
-    expect(output.present).toHaveBeenCalledWith({
+    const successResult = result.unwrap();
+    expect(successResult).toEqual({
       mediaId: 'media-1',
       url: 'https://example.com/media.png',
     });
@@ -142,7 +129,7 @@ describe('UploadMediaUseCase', () => {
     mediaRepo.save.mockRejectedValue(new Error('DB error'));
 
     const input: UploadMediaInput = { file: baseFile, uploadedBy: 'user-1' };
-    const result: Result<void, ApplicationErrorCode<UploadMediaErrorCode, { message: string }>> =
+    const result: Result<UploadMediaResult, ApplicationErrorCode<UploadMediaErrorCode, { message: string }>> =
       await useCase.execute(input);
 
     expect(result.isErr()).toBe(true);
@@ -150,7 +137,6 @@ describe('UploadMediaUseCase', () => {
     expect(err.code).toBe('REPOSITORY_ERROR');
     expect(err.details?.message).toBe('DB error');
 
-    expect(output.present).not.toHaveBeenCalled();
     expect((logger.error as unknown as Mock)).toHaveBeenCalled();
   });
 });