refactor use cases

core/media/application/use-cases/SelectAvatarUseCase.test.ts

@@ -1,25 +1,18 @@
 import { describe, it, expect, vi, type Mock } from 'vitest';
-import type { Logger, UseCaseOutputPort } from '@core/shared/application';
+import type { Logger } from '@core/shared/application';
 import { Result } from '@core/shared/application/Result';
 import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
 import {
   SelectAvatarUseCase,
   type SelectAvatarErrorCode,
   type SelectAvatarInput,
-  type SelectAvatarResult,
 } from './SelectAvatarUseCase';
 import type { IAvatarGenerationRepository } from '../../domain/repositories/IAvatarGenerationRepository';
 import { AvatarGenerationRequest } from '../../domain/entities/AvatarGenerationRequest';
 
-interface TestOutputPort extends UseCaseOutputPort<SelectAvatarResult> {
-  present: Mock;
-  result?: SelectAvatarResult;
-}
-
 describe('SelectAvatarUseCase', () => {
   let avatarRepo: { findById: Mock; save: Mock };
   let logger: Logger;
-  let output: TestOutputPort;
   let useCase: SelectAvatarUseCase;
 
   beforeEach(() => {
@@ -35,15 +28,8 @@ describe('SelectAvatarUseCase', () => {
       error: vi.fn(),
     } as unknown as Logger;
 
-    output = {
-      present: vi.fn((result: SelectAvatarResult) => {
-        output.result = result;
-      }),
-    } as unknown as TestOutputPort;
-
     useCase = new SelectAvatarUseCase(
       avatarRepo as unknown as IAvatarGenerationRepository,
-      output,
       logger,
     );
   });
@@ -60,7 +46,6 @@ describe('SelectAvatarUseCase', () => {
 
     const err = result.unwrapErr() as ApplicationErrorCode<SelectAvatarErrorCode, { message: string }>;
     expect(err.code).toBe('REQUEST_NOT_FOUND');
-    expect(output.present).not.toHaveBeenCalled();
   });
 
   it('returns REQUEST_NOT_COMPLETED when request is not completed', async () => {
@@ -81,10 +66,9 @@ describe('SelectAvatarUseCase', () => {
     expect(err.code).toBe('REQUEST_NOT_COMPLETED');
 
     expect(avatarRepo.save).not.toHaveBeenCalled();
-    expect(output.present).not.toHaveBeenCalled();
   });
 
-  it('selects avatar and presents selected URL when request is completed', async () => {
+  it('returns SelectAvatarResult when request is completed', async () => {
     const request = AvatarGenerationRequest.create({
       id: 'req-1',
       userId: 'user-1',
@@ -103,7 +87,9 @@ describe('SelectAvatarUseCase', () => {
     expect(request.selectedAvatarUrl).toBe('https://example.com/b.png');
 
     expect(avatarRepo.save).toHaveBeenCalledWith(request);
-    expect(output.present).toHaveBeenCalledWith({
+
+    const successResult = result.unwrap();
+    expect(successResult).toEqual({
       requestId: 'req-1',
       selectedAvatarUrl: 'https://example.com/b.png',
     });
@@ -120,7 +106,6 @@ describe('SelectAvatarUseCase', () => {
     expect(err.code).toBe('REPOSITORY_ERROR');
     expect(err.details?.message).toBe('DB error');
 
-    expect(output.present).not.toHaveBeenCalled();
     expect((logger.error as unknown as Mock)).toHaveBeenCalled();
   });
 });