refactor use cases

core/media/application/use-cases/DeleteMediaUseCase.test.ts

@@ -2,21 +2,15 @@ import { describe, it, expect, vi, type Mock } from 'vitest';
 import {
   DeleteMediaUseCase,
   type DeleteMediaInput,
-  type DeleteMediaResult,
   type DeleteMediaErrorCode,
 } from './DeleteMediaUseCase';
 import type { IMediaRepository } from '../../domain/repositories/IMediaRepository';
 import type { MediaStoragePort } from '../ports/MediaStoragePort';
-import type { Logger, UseCaseOutputPort } from '@core/shared/application';
+import type { Logger } from '@core/shared/application';
 import { Result } from '@core/shared/application/Result';
 import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
 import { Media } from '../../domain/entities/Media';
 
-interface TestOutputPort extends UseCaseOutputPort<DeleteMediaResult> {
-  present: Mock;
-  result?: DeleteMediaResult;
-}
-
 describe('DeleteMediaUseCase', () => {
   let mediaRepo: {
     findById: Mock;
@@ -26,7 +20,6 @@ describe('DeleteMediaUseCase', () => {
     deleteMedia: Mock;
   };
   let logger: Logger;
-  let output: TestOutputPort;
   let useCase: DeleteMediaUseCase;
 
   beforeEach(() => {
@@ -46,16 +39,9 @@ describe('DeleteMediaUseCase', () => {
       error: vi.fn(),
     } as unknown as Logger;
 
-    output = {
-      present: vi.fn((result: DeleteMediaResult) => {
-        output.result = result;
-      }),
-    } as unknown as TestOutputPort;
-
     useCase = new DeleteMediaUseCase(
       mediaRepo as unknown as IMediaRepository,
       mediaStorage as unknown as MediaStoragePort,
-      output,
       logger,
     );
   });
@@ -74,10 +60,9 @@ describe('DeleteMediaUseCase', () => {
       { message: string }
     >;
     expect(err.code).toBe('MEDIA_NOT_FOUND');
-    expect(output.present).not.toHaveBeenCalled();
   });
 
-  it('deletes media from storage and repository on success', async () => {
+  it('returns DeleteMediaResult on success', async () => {
     const media = Media.create({
       id: 'media-1',
       filename: 'file.png',
@@ -98,7 +83,9 @@ describe('DeleteMediaUseCase', () => {
     expect(mediaRepo.findById).toHaveBeenCalledWith('media-1');
     expect(mediaStorage.deleteMedia).toHaveBeenCalledWith(media.url.value);
     expect(mediaRepo.delete).toHaveBeenCalledWith('media-1');
-    expect(output.present).toHaveBeenCalledWith({
+
+    const successResult = result.unwrap();
+    expect(successResult).toEqual({
       mediaId: 'media-1',
       deleted: true,
     });
@@ -117,6 +104,5 @@ describe('DeleteMediaUseCase', () => {
       { message: string }
     >;
     expect(err.code).toBe('REPOSITORY_ERROR');
-    expect(output.present).not.toHaveBeenCalled();
   });
-});
+});