refactor use cases
This commit is contained in:
@@ -1,17 +1,14 @@
|
||||
import { describe, it, expect, vi, type Mock, beforeEach } from 'vitest';
|
||||
import { describe, it, expect, vi, type Mock } from 'vitest';
|
||||
import { ResetPasswordUseCase } from './ResetPasswordUseCase';
|
||||
import { EmailAddress } from '../../domain/value-objects/EmailAddress';
|
||||
import { UserId } from '../../domain/value-objects/UserId';
|
||||
import { User } from '../../domain/entities/User';
|
||||
import type { IAuthRepository } from '../../domain/repositories/IAuthRepository';
|
||||
import type { IMagicLinkRepository } from '../../domain/repositories/IMagicLinkRepository';
|
||||
import type { IPasswordHashingService } from '../../domain/services/PasswordHashingService';
|
||||
import type { Logger, UseCaseOutputPort } from '@core/shared/application';
|
||||
import type { Logger } from '@core/shared/application';
|
||||
import { Result } from '@core/shared/application/Result';
|
||||
|
||||
type ResetPasswordOutput = {
|
||||
message: string;
|
||||
};
|
||||
import { User } from '../../domain/entities/User';
|
||||
import { UserId } from '../../domain/value-objects/UserId';
|
||||
import { PasswordHash } from '../../domain/value-objects/PasswordHash';
|
||||
import { EmailAddress } from '../../domain/value-objects/EmailAddress';
|
||||
|
||||
describe('ResetPasswordUseCase', () => {
|
||||
let authRepo: {
|
||||
@@ -26,7 +23,6 @@ describe('ResetPasswordUseCase', () => {
|
||||
hash: Mock;
|
||||
};
|
||||
let logger: Logger;
|
||||
let output: UseCaseOutputPort<ResetPasswordOutput> & { present: Mock };
|
||||
let useCase: ResetPasswordUseCase;
|
||||
|
||||
beforeEach(() => {
|
||||
@@ -34,206 +30,129 @@ describe('ResetPasswordUseCase', () => {
|
||||
findByEmail: vi.fn(),
|
||||
save: vi.fn(),
|
||||
};
|
||||
|
||||
magicLinkRepo = {
|
||||
findByToken: vi.fn(),
|
||||
markAsUsed: vi.fn(),
|
||||
};
|
||||
|
||||
passwordService = {
|
||||
hash: vi.fn(),
|
||||
};
|
||||
|
||||
logger = {
|
||||
debug: vi.fn(),
|
||||
info: vi.fn(),
|
||||
warn: vi.fn(),
|
||||
error: vi.fn(),
|
||||
} as unknown as Logger;
|
||||
output = {
|
||||
present: vi.fn(),
|
||||
};
|
||||
|
||||
useCase = new ResetPasswordUseCase(
|
||||
authRepo as unknown as IAuthRepository,
|
||||
magicLinkRepo as unknown as IMagicLinkRepository,
|
||||
passwordService as unknown as IPasswordHashingService,
|
||||
logger,
|
||||
output,
|
||||
);
|
||||
});
|
||||
|
||||
it('should reset password with valid token', async () => {
|
||||
const input = {
|
||||
token: 'valid-token-12345678901234567890123456789012',
|
||||
newPassword: 'NewPass123!',
|
||||
};
|
||||
|
||||
it('successfully resets password with valid token', async () => {
|
||||
const user = User.create({
|
||||
id: UserId.create(),
|
||||
displayName: 'John Smith',
|
||||
email: 'test@example.com',
|
||||
passwordHash: PasswordHash.fromHash('old-hash'),
|
||||
});
|
||||
|
||||
const resetRequest = {
|
||||
const validToken = 'a'.repeat(32); // 32 characters minimum
|
||||
magicLinkRepo.findByToken.mockResolvedValue({
|
||||
email: 'test@example.com',
|
||||
token: input.token,
|
||||
expiresAt: new Date(Date.now() + 60000), // 1 minute from now
|
||||
token: validToken,
|
||||
expiresAt: new Date(Date.now() + 60000),
|
||||
userId: user.getId().value,
|
||||
};
|
||||
|
||||
magicLinkRepo.findByToken.mockResolvedValue(resetRequest);
|
||||
authRepo.findByEmail.mockResolvedValue(user);
|
||||
passwordService.hash.mockResolvedValue('hashed-new-password');
|
||||
|
||||
const result = await useCase.execute(input);
|
||||
|
||||
expect(magicLinkRepo.findByToken).toHaveBeenCalledWith(input.token);
|
||||
expect(authRepo.findByEmail).toHaveBeenCalledWith(EmailAddress.create('test@example.com'));
|
||||
expect(passwordService.hash).toHaveBeenCalledWith(input.newPassword);
|
||||
expect(authRepo.save).toHaveBeenCalled();
|
||||
expect(magicLinkRepo.markAsUsed).toHaveBeenCalledWith(input.token);
|
||||
expect(output.present).toHaveBeenCalledWith({
|
||||
message: 'Password reset successfully. You can now log in with your new password.',
|
||||
used: false,
|
||||
});
|
||||
authRepo.findByEmail.mockResolvedValue(user);
|
||||
passwordService.hash.mockResolvedValue('new-hashed-password');
|
||||
|
||||
const result = await useCase.execute({
|
||||
token: validToken,
|
||||
newPassword: 'NewPassword123',
|
||||
});
|
||||
|
||||
expect(result.isOk()).toBe(true);
|
||||
const resetResult = result.unwrap();
|
||||
expect(resetResult.message).toBe('Password reset successfully. You can now log in with your new password.');
|
||||
expect(authRepo.save).toHaveBeenCalled();
|
||||
expect(magicLinkRepo.markAsUsed).toHaveBeenCalledWith(validToken);
|
||||
});
|
||||
|
||||
it('should reject invalid token', async () => {
|
||||
const input = {
|
||||
token: 'invalid-token',
|
||||
newPassword: 'NewPass123!',
|
||||
};
|
||||
|
||||
it('returns error for invalid token', async () => {
|
||||
magicLinkRepo.findByToken.mockResolvedValue(null);
|
||||
|
||||
const result = await useCase.execute(input);
|
||||
const result = await useCase.execute({
|
||||
token: 'invalid-token-that-is-too-short',
|
||||
newPassword: 'NewPassword123',
|
||||
});
|
||||
|
||||
expect(result.isErr()).toBe(true);
|
||||
const error = result.unwrapErr();
|
||||
expect(error.code).toBe('INVALID_TOKEN');
|
||||
expect(result.unwrapErr().code).toBe('INVALID_TOKEN');
|
||||
});
|
||||
|
||||
it('should reject expired token', async () => {
|
||||
const input = {
|
||||
token: 'expired-token-12345678901234567890123456789012',
|
||||
newPassword: 'NewPass123!',
|
||||
};
|
||||
|
||||
const resetRequest = {
|
||||
it('returns error for expired token', async () => {
|
||||
const expiredToken = 'b'.repeat(32);
|
||||
magicLinkRepo.findByToken.mockResolvedValue({
|
||||
email: 'test@example.com',
|
||||
token: input.token,
|
||||
expiresAt: new Date(Date.now() - 60000), // 1 minute ago
|
||||
userId: 'user-123',
|
||||
};
|
||||
token: expiredToken,
|
||||
expiresAt: new Date(Date.now() - 60000),
|
||||
userId: 'user-1',
|
||||
used: false,
|
||||
});
|
||||
|
||||
magicLinkRepo.findByToken.mockResolvedValue(resetRequest);
|
||||
|
||||
const result = await useCase.execute(input);
|
||||
const result = await useCase.execute({
|
||||
token: expiredToken,
|
||||
newPassword: 'NewPassword123',
|
||||
});
|
||||
|
||||
expect(result.isErr()).toBe(true);
|
||||
const error = result.unwrapErr();
|
||||
expect(error.code).toBe('EXPIRED_TOKEN');
|
||||
expect(result.unwrapErr().code).toBe('EXPIRED_TOKEN');
|
||||
});
|
||||
|
||||
it('should reject weak password', async () => {
|
||||
const input = {
|
||||
token: 'valid-token-12345678901234567890123456789012',
|
||||
newPassword: 'weak',
|
||||
};
|
||||
|
||||
const result = await useCase.execute(input);
|
||||
|
||||
expect(result.isErr()).toBe(true);
|
||||
const error = result.unwrapErr();
|
||||
expect(error.code).toBe('WEAK_PASSWORD');
|
||||
});
|
||||
|
||||
it('should reject password without uppercase', async () => {
|
||||
const input = {
|
||||
token: 'valid-token-12345678901234567890123456789012',
|
||||
newPassword: 'newpass123!',
|
||||
};
|
||||
|
||||
const result = await useCase.execute(input);
|
||||
|
||||
expect(result.isErr()).toBe(true);
|
||||
const error = result.unwrapErr();
|
||||
expect(error.code).toBe('WEAK_PASSWORD');
|
||||
});
|
||||
|
||||
it('should reject password without number', async () => {
|
||||
const input = {
|
||||
token: 'valid-token-12345678901234567890123456789012',
|
||||
newPassword: 'NewPass!',
|
||||
};
|
||||
|
||||
const result = await useCase.execute(input);
|
||||
|
||||
expect(result.isErr()).toBe(true);
|
||||
const error = result.unwrapErr();
|
||||
expect(error.code).toBe('WEAK_PASSWORD');
|
||||
});
|
||||
|
||||
it('should reject password shorter than 8 characters', async () => {
|
||||
const input = {
|
||||
token: 'valid-token-12345678901234567890123456789012',
|
||||
newPassword: 'New1!',
|
||||
};
|
||||
|
||||
const result = await useCase.execute(input);
|
||||
|
||||
expect(result.isErr()).toBe(true);
|
||||
const error = result.unwrapErr();
|
||||
expect(error.code).toBe('WEAK_PASSWORD');
|
||||
});
|
||||
|
||||
it('should handle user no longer exists', async () => {
|
||||
const input = {
|
||||
token: 'valid-token-12345678901234567890123456789012',
|
||||
newPassword: 'NewPass123!',
|
||||
};
|
||||
|
||||
const resetRequest = {
|
||||
email: 'deleted@example.com',
|
||||
token: input.token,
|
||||
it('returns error for weak password', async () => {
|
||||
const validToken = 'c'.repeat(32);
|
||||
magicLinkRepo.findByToken.mockResolvedValue({
|
||||
email: 'test@example.com',
|
||||
token: validToken,
|
||||
expiresAt: new Date(Date.now() + 60000),
|
||||
userId: 'user-123',
|
||||
};
|
||||
userId: 'user-1',
|
||||
used: false,
|
||||
});
|
||||
|
||||
magicLinkRepo.findByToken.mockResolvedValue(resetRequest);
|
||||
const result = await useCase.execute({
|
||||
token: validToken,
|
||||
newPassword: 'weak',
|
||||
});
|
||||
|
||||
expect(result.isErr()).toBe(true);
|
||||
expect(result.unwrapErr().code).toBe('WEAK_PASSWORD');
|
||||
});
|
||||
|
||||
it('returns error when user no longer exists', async () => {
|
||||
const validToken = 'd'.repeat(32);
|
||||
magicLinkRepo.findByToken.mockResolvedValue({
|
||||
email: 'test@example.com',
|
||||
token: validToken,
|
||||
expiresAt: new Date(Date.now() + 60000),
|
||||
userId: 'user-1',
|
||||
used: false,
|
||||
});
|
||||
authRepo.findByEmail.mockResolvedValue(null);
|
||||
|
||||
const result = await useCase.execute(input);
|
||||
const result = await useCase.execute({
|
||||
token: validToken,
|
||||
newPassword: 'NewPassword123',
|
||||
});
|
||||
|
||||
expect(result.isErr()).toBe(true);
|
||||
const error = result.unwrapErr();
|
||||
expect(error.code).toBe('INVALID_TOKEN');
|
||||
});
|
||||
|
||||
it('should handle token format validation', async () => {
|
||||
const input = {
|
||||
token: 'short',
|
||||
newPassword: 'NewPass123!',
|
||||
};
|
||||
|
||||
const result = await useCase.execute(input);
|
||||
|
||||
expect(result.isErr()).toBe(true);
|
||||
const error = result.unwrapErr();
|
||||
expect(error.code).toBe('INVALID_TOKEN');
|
||||
});
|
||||
|
||||
it('should handle repository errors', async () => {
|
||||
const input = {
|
||||
token: 'valid-token-12345678901234567890123456789012',
|
||||
newPassword: 'NewPass123!',
|
||||
};
|
||||
|
||||
magicLinkRepo.findByToken.mockRejectedValue(new Error('Database error'));
|
||||
|
||||
const result = await useCase.execute(input);
|
||||
|
||||
expect(result.isErr()).toBe(true);
|
||||
const error = result.unwrapErr();
|
||||
expect(error.code).toBe('REPOSITORY_ERROR');
|
||||
expect(error.details.message).toContain('Database error');
|
||||
expect(result.unwrapErr().code).toBe('INVALID_TOKEN');
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user