refactor use cases

core/analytics/application/use-cases/GetAnalyticsMetricsUseCase.ts

@@ -1,4 +1,4 @@
-import type { Logger, UseCase, UseCaseOutputPort } from '@core/shared/application';
+import type { Logger, UseCase } from '@core/shared/application';
 import { Result } from '@core/shared/application/Result';
 import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
 import type { IPageViewRepository } from '../repositories/IPageViewRepository';
@@ -17,16 +17,15 @@ export interface GetAnalyticsMetricsOutput {
 
 export type GetAnalyticsMetricsErrorCode = 'REPOSITORY_ERROR';
 
-export class GetAnalyticsMetricsUseCase implements UseCase<GetAnalyticsMetricsInput, void, GetAnalyticsMetricsErrorCode> {
+export class GetAnalyticsMetricsUseCase implements UseCase<GetAnalyticsMetricsInput, GetAnalyticsMetricsOutput, GetAnalyticsMetricsErrorCode> {
   constructor(
     private readonly logger: Logger,
-    private readonly output: UseCaseOutputPort<GetAnalyticsMetricsOutput>,
     private readonly pageViewRepository?: IPageViewRepository,
   ) {}
 
   async execute(
     input: GetAnalyticsMetricsInput = {},
-  ): Promise<Result<void, ApplicationErrorCode<GetAnalyticsMetricsErrorCode, { message: string }>>> {
+  ): Promise<Result<GetAnalyticsMetricsOutput, ApplicationErrorCode<GetAnalyticsMetricsErrorCode, { message: string }>>> {
     try {
       const startDate = input.startDate ?? new Date(Date.now() - 30 * 24 * 60 * 60 * 1000); // 30 days ago
       const endDate = input.endDate ?? new Date();
@@ -47,8 +46,6 @@ export class GetAnalyticsMetricsUseCase implements UseCase<GetAnalyticsMetricsIn
         bounceRate,
       };
 
-      this.output.present(resultModel);
-
       this.logger.info('Analytics metrics retrieved', {
         startDate,
         endDate,
@@ -56,7 +53,7 @@ export class GetAnalyticsMetricsUseCase implements UseCase<GetAnalyticsMetricsIn
         uniqueVisitors,
       });
 
-      return Result.ok(undefined);
+      return Result.ok(resultModel);
     } catch (error) {
       const err = error as Error;
       this.logger.error('Failed to get analytics metrics', err, { input });