diff --git a/apps/website/eslint-rules/client-only-rules.js b/apps/website/eslint-rules/client-only-rules.js index 15bc2a868..d3e000659 100644 --- a/apps/website/eslint-rules/client-only-rules.js +++ b/apps/website/eslint-rules/client-only-rules.js @@ -14,7 +14,7 @@ module.exports = { category: 'Client-Only', }, messages: { - message: 'Client-only files cannot contain server-side code', + message: 'Client-only files cannot contain server-side code - see apps/website/lib/contracts/view-models/ViewModel.ts', }, }, create(context) { @@ -61,7 +61,7 @@ module.exports = { category: 'Client-Only', }, messages: { - message: 'Client-only files must have "use client" directive at the top', + message: 'Client-only files must have "use client" directive at the top - see apps/website/lib/contracts/view-models/ViewModel.ts', }, }, create(context) { diff --git a/apps/website/eslint-rules/component-no-data-manipulation.js b/apps/website/eslint-rules/component-no-data-manipulation.js new file mode 100644 index 000000000..43b5fd5cb --- /dev/null +++ b/apps/website/eslint-rules/component-no-data-manipulation.js @@ -0,0 +1,36 @@ +/** + * ESLint rule: Components must not manipulate data + */ + +module.exports = { + meta: { + type: 'problem', + docs: { + description: 'Forbid data manipulation in components', + category: 'Components', + }, + messages: { + message: 'Components must not manipulate data - see apps/website/lib/contracts/view-data/ViewData.ts', + }, + }, + create(context) { + return { + CallExpression(node) { + const filename = context.getFilename(); + if (filename.includes('/components/')) { + // Check for mutation methods + if (node.callee.type === 'MemberExpression') { + const property = node.callee.property; + if (property.type === 'Identifier' && + ['push', 'pop', 'shift', 'unshift', 'splice', 'sort', 'reverse', 'assign'].includes(property.name)) { + context.report({ + node, + messageId: 'message', + }); + } + } + } + }, + }; + }, +}; \ No newline at end of file diff --git a/apps/website/eslint-rules/display-object-rules.js b/apps/website/eslint-rules/display-object-rules.js index 9fd15698c..fb025b225 100644 --- a/apps/website/eslint-rules/display-object-rules.js +++ b/apps/website/eslint-rules/display-object-rules.js @@ -14,7 +14,7 @@ module.exports = { category: 'Display Objects', }, messages: { - message: 'DisplayObjects cannot import from api, services, page-queries, or view-models', + message: 'DisplayObjects cannot import from api, services, page-queries, or view-models - see apps/website/lib/contracts/display-objects/DisplayObject.ts', }, }, create(context) { @@ -50,7 +50,7 @@ module.exports = { category: 'Display Objects', }, messages: { - message: 'Display Objects must be class-based and export only classes', + message: 'Display Objects must be class-based and export only classes - see apps/website/lib/contracts/display-objects/DisplayObject.ts', }, }, create(context) { diff --git a/apps/website/eslint-rules/filename-presenter-match.js b/apps/website/eslint-rules/filename-presenter-match.js index 73512995c..b47452289 100644 --- a/apps/website/eslint-rules/filename-presenter-match.js +++ b/apps/website/eslint-rules/filename-presenter-match.js @@ -1,5 +1,5 @@ /** - * Filename rule: Presenter filename must match class name + * ESLint rule: Presenter filename must match class name */ module.exports = { @@ -10,7 +10,7 @@ module.exports = { category: 'Filename', }, messages: { - message: 'Presenter filename must match class name (e.g., FooPresenter.ts contains class FooPresenter)', + message: 'Presenter filename must match class name (e.g., FooPresenter.ts contains class FooPresenter) - see apps/website/lib/contracts/presenters/Presenter.ts', }, }, create(context) { diff --git a/apps/website/eslint-rules/filename-rules.js b/apps/website/eslint-rules/filename-rules.js index 976acd47e..e0abf3b48 100644 --- a/apps/website/eslint-rules/filename-rules.js +++ b/apps/website/eslint-rules/filename-rules.js @@ -14,7 +14,7 @@ module.exports = { category: 'Filename', }, messages: { - message: 'Presenter filename must match class name (e.g., FooPresenter.ts contains class FooPresenter)', + message: 'Presenter filename must match class name (e.g., FooPresenter.ts contains class FooPresenter) - see apps/website/lib/contracts/presenters/Presenter.ts', }, }, create(context) { @@ -46,7 +46,7 @@ module.exports = { category: 'Filename', }, messages: { - message: 'Service filename must match function name (e.g., getUser.ts contains function getUser)', + message: 'Service filename must match function name (e.g., getUser.ts contains function getUser) - see apps/website/lib/contracts/services/Service.ts', }, }, create(context) { diff --git a/apps/website/eslint-rules/index.js b/apps/website/eslint-rules/index.js index d7e095565..e526c75b1 100644 --- a/apps/website/eslint-rules/index.js +++ b/apps/website/eslint-rules/index.js @@ -24,6 +24,7 @@ const clientOnlyRules = require('./client-only-rules'); const writeBoundaryRules = require('./write-boundary-rules'); const modelTaxonomyRules = require('./model-taxonomy-rules'); const filenameRules = require('./filename-rules'); +const componentNoDataManipulation = require('./component-no-data-manipulation'); module.exports = { rules: { @@ -84,6 +85,9 @@ module.exports = { // Filename Rules 'filename-presenter-match': filenameRules['presenter-filename-must-match-class'], 'filename-service-match': filenameRules['service-filename-must-match-function'], + + // Component Data Manipulation Rules + 'component-no-data-manipulation': componentNoDataManipulation, }, // Configurations for different use cases diff --git a/apps/website/eslint-rules/model-taxonomy-rules.js b/apps/website/eslint-rules/model-taxonomy-rules.js index 379f04cc8..4016b50ad 100644 --- a/apps/website/eslint-rules/model-taxonomy-rules.js +++ b/apps/website/eslint-rules/model-taxonomy-rules.js @@ -14,7 +14,7 @@ module.exports = { category: 'Model Taxonomy', }, messages: { - message: 'Display objects cannot contain domain models', + message: 'Display objects cannot contain domain models - see apps/website/lib/contracts/view-models/ViewModel.ts', }, }, create(context) { @@ -49,7 +49,7 @@ module.exports = { category: 'Model Taxonomy', }, messages: { - message: 'Domain models cannot contain display objects', + message: 'Domain models cannot contain display objects - see apps/website/lib/contracts/view-models/ViewModel.ts', }, }, create(context) { diff --git a/apps/website/eslint-rules/page-query-rules.js b/apps/website/eslint-rules/page-query-rules.js index 2c8ca238d..d7a558951 100644 --- a/apps/website/eslint-rules/page-query-rules.js +++ b/apps/website/eslint-rules/page-query-rules.js @@ -14,7 +14,7 @@ module.exports = { category: 'Page Query', }, messages: { - message: 'PageQueries must return PageQueryResult union, not null', + message: 'PageQueries must return PageQueryResult union, not null - see apps/website/lib/contracts/page-queries/PageQuery.ts', }, }, create(context) { @@ -43,7 +43,7 @@ module.exports = { category: 'Page Query', }, messages: { - message: 'PageQuery files must end with PageQuery.ts', + message: 'PageQuery files must end with PageQuery.ts - see apps/website/lib/contracts/page-queries/PageQuery.ts', }, }, create(context) { @@ -67,7 +67,7 @@ module.exports = { category: 'Page Query', }, messages: { - message: 'PageQuery class must implement PageQuery interface', + message: 'PageQuery class must implement PageQuery interface - see apps/website/lib/contracts/page-queries/PageQuery.ts', }, }, create(context) { @@ -99,7 +99,7 @@ module.exports = { category: 'Page Query', }, messages: { - message: 'PageQuery class must have execute(params) method', + message: 'PageQuery class must have execute(params) method - see apps/website/lib/contracts/page-queries/PageQuery.ts', }, }, create(context) { @@ -134,7 +134,7 @@ module.exports = { category: 'Page Query', }, messages: { - message: 'PageQuery execute() must return Promise>', + message: 'PageQuery execute() must return Promise> - see apps/website/lib/contracts/page-queries/PageQuery.ts', }, }, create(context) { diff --git a/apps/website/eslint-rules/presenter-contract.js b/apps/website/eslint-rules/presenter-contract.js index 1aec96a22..b4a884f06 100644 --- a/apps/website/eslint-rules/presenter-contract.js +++ b/apps/website/eslint-rules/presenter-contract.js @@ -18,9 +18,9 @@ module.exports = { fixable: null, schema: [], messages: { - missingImplements: 'Presenter class must implement Presenter interface', - missingPresentMethod: 'Presenter class must have present(input) method', - missingUseClient: 'Presenter must have \'use client\' directive at top-level', + missingImplements: 'Presenter class must implement Presenter interface - see apps/website/lib/contracts/presenters/Presenter.ts', + missingPresentMethod: 'Presenter class must have present(input) method - see apps/website/lib/contracts/presenters/Presenter.ts', + missingUseClient: 'Presenter must have \'use client\' directive at top-level - see apps/website/lib/contracts/presenters/Presenter.ts', }, }, diff --git a/apps/website/eslint-rules/rsc-boundary-rules.js b/apps/website/eslint-rules/rsc-boundary-rules.js index d9c083310..fc5f79d83 100644 --- a/apps/website/eslint-rules/rsc-boundary-rules.js +++ b/apps/website/eslint-rules/rsc-boundary-rules.js @@ -14,7 +14,7 @@ module.exports = { category: 'RSC Boundary', }, messages: { - message: 'ContainerManager usage forbidden in server code', + message: 'ContainerManager usage forbidden in server code - see apps/website/lib/contracts/view-models/ViewModel.ts', }, }, create(context) { @@ -40,7 +40,7 @@ module.exports = { category: 'RSC Boundary', }, messages: { - message: 'PageDataFetcher.fetch() forbidden in server code', + message: 'PageDataFetcher.fetch() forbidden in server code - see apps/website/lib/contracts/view-models/ViewModel.ts', }, }, create(context) { @@ -69,7 +69,7 @@ module.exports = { category: 'RSC Boundary', }, messages: { - message: 'ViewModels or Presenters import forbidden in server code', + message: 'ViewModels or Presenters import forbidden in server code - see apps/website/lib/contracts/view-models/ViewModel.ts', }, }, create(context) { @@ -98,7 +98,7 @@ module.exports = { category: 'RSC Boundary', }, messages: { - message: 'Presenter import forbidden in server code', + message: 'Presenter import forbidden in server code - see apps/website/lib/contracts/view-models/ViewModel.ts', }, }, create(context) { @@ -127,7 +127,7 @@ module.exports = { category: 'RSC Boundary', }, messages: { - message: 'Intl.* or toLocale* usage forbidden in presentation paths', + message: 'Intl.* or toLocale* usage forbidden in presentation paths - see apps/website/lib/contracts/view-models/ViewModel.ts', }, }, create(context) { @@ -155,7 +155,7 @@ module.exports = { category: 'RSC Boundary', }, messages: { - message: 'Sorting/filtering/reduce operations forbidden in server code', + message: 'Sorting/filtering/reduce operations forbidden in server code - see apps/website/lib/contracts/view-models/ViewModel.ts', }, }, create(context) { @@ -184,7 +184,7 @@ module.exports = { category: 'RSC Boundary', }, messages: { - message: 'DisplayObjects import forbidden in server code', + message: 'DisplayObjects import forbidden in server code - see apps/website/lib/contracts/view-models/ViewModel.ts', }, }, create(context) { @@ -212,7 +212,7 @@ module.exports = { category: 'RSC Boundary', }, messages: { - message: 'Services import must be explicitly marked as server-safe', + message: 'Services import must be explicitly marked as server-safe - see apps/website/lib/contracts/view-models/ViewModel.ts', }, }, create(context) { @@ -241,7 +241,7 @@ module.exports = { category: 'RSC Boundary', }, messages: { - message: 'DI import forbidden in server code', + message: 'DI import forbidden in server code - see apps/website/lib/contracts/view-models/ViewModel.ts', }, }, create(context) { @@ -269,7 +269,7 @@ module.exports = { category: 'RSC Boundary', }, messages: { - message: 'Local helper functions forbidden (only assert*/invariant* allowed)', + message: 'Local helper functions forbidden (only assert*/invariant* allowed) - see apps/website/lib/contracts/view-models/ViewModel.ts', }, }, create(context) { @@ -309,7 +309,7 @@ module.exports = { category: 'RSC Boundary', }, messages: { - message: 'Object construction with new forbidden (use PageQueries)', + message: 'Object construction with new forbidden (use PageQueries) - see apps/website/lib/contracts/view-models/ViewModel.ts', }, }, create(context) { @@ -337,7 +337,7 @@ module.exports = { category: 'RSC Boundary', }, messages: { - message: 'ContainerManager calls forbidden in server code', + message: 'ContainerManager calls forbidden in server code - see apps/website/lib/contracts/view-models/ViewModel.ts', }, }, create(context) { diff --git a/apps/website/eslint-rules/services-rules.js b/apps/website/eslint-rules/services-rules.js index 38ef1be9f..36625e624 100644 --- a/apps/website/eslint-rules/services-rules.js +++ b/apps/website/eslint-rules/services-rules.js @@ -14,7 +14,7 @@ module.exports = { category: 'Services', }, messages: { - message: 'Services must be explicitly marked with @server-safe or @client-only comment', + message: 'Services must be explicitly marked with @server-safe or @client-only comment - see apps/website/lib/contracts/services/Service.ts', }, }, create(context) { @@ -49,7 +49,7 @@ module.exports = { category: 'Services', }, messages: { - message: 'External API calls must be in adapters, not services', + message: 'External API calls must be in adapters, not services - see apps/website/lib/contracts/services/Service.ts', }, }, create(context) { @@ -96,7 +96,7 @@ module.exports = { category: 'Services', }, messages: { - message: 'Services must be pure functions, no side effects allowed', + message: 'Services must be pure functions, no side effects allowed - see apps/website/lib/contracts/services/Service.ts', }, }, create(context) { diff --git a/apps/website/eslint-rules/template-purity-rules.js b/apps/website/eslint-rules/template-purity-rules.js index 138f0930f..8df02da73 100644 --- a/apps/website/eslint-rules/template-purity-rules.js +++ b/apps/website/eslint-rules/template-purity-rules.js @@ -14,7 +14,7 @@ module.exports = { category: 'Template Purity', }, messages: { - message: 'ViewModels or DisplayObjects import forbidden in templates', + message: 'ViewModels or DisplayObjects import forbidden in templates - see apps/website/lib/contracts/view-data/ViewData.ts', }, }, create(context) { @@ -44,7 +44,7 @@ module.exports = { category: 'Template Purity', }, messages: { - message: 'State hooks forbidden in templates (use *PageClient.tsx)', + message: 'State hooks forbidden in templates (use *PageClient.tsx) - see apps/website/lib/contracts/view-data/ViewData.ts', }, }, create(context) { @@ -72,7 +72,7 @@ module.exports = { category: 'Template Purity', }, messages: { - message: 'Derived computations forbidden in templates', + message: 'Derived computations forbidden in templates - see apps/website/lib/contracts/view-data/ViewData.ts', }, }, create(context) { @@ -100,7 +100,7 @@ module.exports = { category: 'Template Purity', }, messages: { - message: 'Templates cannot import from page-queries, services, api, di, or contracts', + message: 'Templates cannot import from page-queries, services, api, di, or contracts - see apps/website/lib/contracts/view-data/ViewData.ts', }, }, create(context) { @@ -136,7 +136,7 @@ module.exports = { category: 'Template Purity', }, messages: { - message: 'Template component must accept *ViewData type as first parameter', + message: 'Template component must accept *ViewData type as first parameter - see apps/website/lib/contracts/view-data/ViewData.ts', }, }, create(context) { @@ -164,7 +164,7 @@ module.exports = { category: 'Template Purity', }, messages: { - message: 'Templates must not export helper functions', + message: 'Templates must not export helper functions - see apps/website/lib/contracts/view-data/ViewData.ts', }, }, create(context) { @@ -192,7 +192,7 @@ module.exports = { category: 'Template Purity', }, messages: { - message: 'Template files must end with Template.tsx', + message: 'Template files must end with Template.tsx - see apps/website/lib/contracts/view-data/ViewData.ts', }, }, create(context) { diff --git a/apps/website/eslint-rules/write-boundary-rules.js b/apps/website/eslint-rules/write-boundary-rules.js index 3211b4c5e..7d142803a 100644 --- a/apps/website/eslint-rules/write-boundary-rules.js +++ b/apps/website/eslint-rules/write-boundary-rules.js @@ -14,7 +14,7 @@ module.exports = { category: 'Write Boundary', }, messages: { - message: 'Write boundaries must use mutation functions, not direct mutations', + message: 'Write boundaries must use mutation functions, not direct mutations - see apps/website/lib/contracts/write-boundaries/WriteBoundary.ts', }, }, create(context) { @@ -55,7 +55,7 @@ module.exports = { category: 'Write Boundary', }, messages: { - message: 'Write boundaries must use repository pattern for data access', + message: 'Write boundaries must use repository pattern for data access - see apps/website/lib/contracts/write-boundaries/WriteBoundary.ts', }, }, create(context) {