refactor

core/racing/application/use-cases/GetDriversLeaderboardUseCase.ts

@@ -1,16 +1,15 @@
-import type { IDriverRepository } from '../../domain/repositories/IDriverRepository';
-import type { IRankingService } from '../../domain/services/IRankingService';
-import type { IDriverStatsService } from '../../domain/services/IDriverStatsService';
-import { SkillLevelService, type SkillLevel } from '../../domain/services/SkillLevelService';
 import type { Logger } from '@core/shared/application';
 import { Result } from '@core/shared/application/Result';
 import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
-import type { UseCaseOutputPort } from '@core/shared/application/UseCaseOutputPort';
 import type { Driver } from '../../domain/entities/Driver';
 import type { Team } from '../../domain/entities/Team';
+import type { IDriverRepository } from '../../domain/repositories/IDriverRepository';
+import type { IDriverStatsService } from '../../domain/services/IDriverStatsService';
+import type { IRankingService } from '../../domain/services/IRankingService';
+import { SkillLevelService, type SkillLevel } from '../../domain/services/SkillLevelService';
 
 export type GetDriversLeaderboardInput = {
-  leagueId: string;
+  leagueId?: string;
   seasonId?: string;
 };
 
@@ -34,11 +33,14 @@ export interface GetDriversLeaderboardResult {
   activeCount: number;
 }
 
-export type GetDriversLeaderboardErrorCode = 'LEAGUE_NOT_FOUND' | 'SEASON_NOT_FOUND' | 'REPOSITORY_ERROR';
+export type GetDriversLeaderboardErrorCode =
+  | 'LEAGUE_NOT_FOUND'
+  | 'SEASON_NOT_FOUND'
+  | 'REPOSITORY_ERROR';
 
 /**
  * Use Case for retrieving driver leaderboard data.
- * Orchestrates domain logic and returns result.
+ * Returns a Result containing the domain leaderboard model.
  */
 export class GetDriversLeaderboardUseCase {
   constructor(
@@ -47,13 +49,18 @@ export class GetDriversLeaderboardUseCase {
     private readonly driverStatsService: IDriverStatsService,
     private readonly getDriverAvatar: (driverId: string) => Promise<string | undefined>,
     private readonly logger: Logger,
-    private readonly output: UseCaseOutputPort<GetDriversLeaderboardResult>,
   ) {}
 
   async execute(
-    _input: GetDriversLeaderboardInput,
-  ): Promise<Result<GetDriversLeaderboardResult, ApplicationErrorCode<GetDriversLeaderboardErrorCode, { message: string }>>> {
-    this.logger.debug('Executing GetDriversLeaderboardUseCase');
+    input: GetDriversLeaderboardInput,
+  ): Promise<
+    Result<
+      GetDriversLeaderboardResult,
+      ApplicationErrorCode<GetDriversLeaderboardErrorCode, { message: string }>
+    >
+  > {
+    this.logger.debug('Executing GetDriversLeaderboardUseCase', { input });
+
     try {
       const drivers = await this.driverRepository.findAll();
       const rankings = this.rankingService.getAllDriverRankings();
@@ -64,12 +71,15 @@ export class GetDriversLeaderboardUseCase {
         avatarUrls[driver.id] = await this.getDriverAvatar(driver.id);
       }
 
-      const items: DriverLeaderboardItem[] = drivers.map((driver) => {
-        const ranking = rankings.find((r) => r.driverId === driver.id);
+      // TODO maps way too much data, should just create Domain Objects
+
+      const items: DriverLeaderboardItem[] = drivers.map(driver => {
+        const ranking = rankings.find(r => r.driverId === driver.id);
         const stats = this.driverStatsService.getDriverStats(driver.id);
         const rating = ranking?.rating ?? 0;
         const racesCompleted = stats?.totalRaces ?? 0;
         const skillLevel: SkillLevel = SkillLevelService.getSkillLevel(rating);
+        const avatarUrl = avatarUrls[driver.id];
 
         return {
           driver,
@@ -80,30 +90,32 @@ export class GetDriversLeaderboardUseCase {
           podiums: stats?.podiums ?? 0,
           isActive: racesCompleted > 0,
           rank: ranking?.overallRank ?? 0,
-          avatarUrl: avatarUrls[driver.id],
+          ...(avatarUrl !== undefined ? { avatarUrl } : {}),
         };
       });
 
       const totalRaces = items.reduce((sum, d) => sum + d.racesCompleted, 0);
       const totalWins = items.reduce((sum, d) => sum + d.wins, 0);
-      const activeCount = items.filter((d) => d.isActive).length;
+      const activeCount = items.filter(d => d.isActive).length;
 
-      this.logger.debug('Successfully retrieved drivers leaderboard.');
-
-      return Result.ok({
+      const result: GetDriversLeaderboardResult = {
         items: items.sort((a, b) => b.rating - a.rating),
         totalRaces,
         totalWins,
         activeCount,
-      });
+      };
+
+      this.logger.debug('Successfully computed drivers leaderboard');
+
+      return Result.ok(result);
     } catch (error) {
-      this.logger.error(
-        'Error executing GetDriversLeaderboardUseCase',
-        error instanceof Error ? error : new Error(String(error)),
-      );
+      const err = error instanceof Error ? error : new Error(String(error));
+
+      this.logger.error('Error executing GetDriversLeaderboardUseCase', err);
+
       return Result.err({
         code: 'REPOSITORY_ERROR',
-        details: { message: error instanceof Error ? error.message : 'Unknown error occurred' },
+        details: { message: err.message ?? 'Unknown error occurred' },
       });
     }
   }